Re: [Mesa-dev] [PATCH 3/3] egl: dri3 changes to support surface primitive wrap around dri2

[Marathe, Yogesh]

>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Emil Velikov
>Sent: Friday, September 15, 2017 10:00 PM
>To: Marathe, Yogesh <yogesh.mara...@intel.com>
>Cc: ML mesa-dev <mesa-dev@lists.freedesktop.org>
>Subject: Re: [Mesa-dev] [PATCH 3/3] egl: dri3 changes to support surface
>primitive wrap around dri2
>
>On 15 September 2017 at 07:36,  <yogesh.mara...@intel.com> wrote:
>> From: Yogesh Marathe <yogesh.mara...@intel.com>
>>
>> As base is moved one level down corresponding implementation in
>> dri3 needs a change.
>>
>> Tested with Intel Mesa CI
>>
>> Signed-off-by: Yogesh Marathe <yogesh.mara...@intel.com>
>> ---
>>  src/egl/drivers/dri2/platform_x11_dri3.c | 18 +-
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>This patch should be squashed with 2/3, and the result must be the first one 
>in the
>series.
>Thus as you build and do tests (locally) there is no intermittent
>breakage/regression.
>
>These and more details are part of the Submitting Patches [1] which I'd
>encourage you to read through.

Sorry I saw this after intermediate reply, I should wait!!
So only two patches now 

1/2 all changes in platform_x11_dri3.
2/2 all changes in current 1/3.

Both being atomically compliable/executable now. I definitely didn’t 
get this on irc. Thanks.

>
>Thanks
>Emil
>
>[1] https://www.mesa3d.org/submittingpatches.html

Thanks.

>___
>mesa-dev mailing list
>mesa-dev@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] egl: dri3 changes to support surface primitive wrap around dri2

[Emil Velikov]

On 15 September 2017 at 07:36,   wrote:
> From: Yogesh Marathe 
>
> As base is moved one level down corresponding implementation in
> dri3 needs a change.
>
> Tested with Intel Mesa CI
>
> Signed-off-by: Yogesh Marathe 
> ---
>  src/egl/drivers/dri2/platform_x11_dri3.c | 18 +-
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
This patch should be squashed with 2/3, and the result must be the
first one in the series.
Thus as you build and do tests (locally) there is no intermittent
breakage/regression.

These and more details are part of the Submitting Patches [1] which
I'd encourage you to read through.

Thanks
Emil

[1] https://www.mesa3d.org/submittingpatches.html
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] egl: dri3 changes to support surface primitive wrap around dri2

[yogesh . marathe]

From: Yogesh Marathe 

As base is moved one level down corresponding implementation in
dri3 needs a change.

Tested with Intel Mesa CI

Signed-off-by: Yogesh Marathe 
---
 src/egl/drivers/dri2/platform_x11_dri3.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_x11_dri3.c 
b/src/egl/drivers/dri2/platform_x11_dri3.c
index 5c4be4d..45bb56c 100644
--- a/src/egl/drivers/dri2/platform_x11_dri3.c
+++ b/src/egl/drivers/dri2/platform_x11_dri3.c
@@ -51,8 +51,8 @@ egl_dri3_set_drawable_size(struct loader_dri3_drawable *draw,
 {
struct dri3_egl_surface *dri3_surf = loader_drawable_to_egl_surface(draw);
 
-   dri3_surf->base.Width = width;
-   dri3_surf->base.Height = height;
+   dri3_surf->surf.base.Width = width;
+   dri3_surf->surf.base.Height = height;
 }
 
 static bool
@@ -61,7 +61,7 @@ egl_dri3_in_current_context(struct loader_dri3_drawable *draw)
struct dri3_egl_surface *dri3_surf = loader_drawable_to_egl_surface(draw);
_EGLContext *ctx = _eglGetCurrentContext();
 
-   return ctx->Resource.Display == dri3_surf->base.Resource.Display;
+   return ctx->Resource.Display == dri3_surf->surf.base.Resource.Display;
 }
 
 static __DRIcontext *
@@ -79,9 +79,9 @@ static void
 egl_dri3_flush_drawable(struct loader_dri3_drawable *draw, unsigned flags)
 {
struct dri3_egl_surface *dri3_surf = loader_drawable_to_egl_surface(draw);
-   _EGLDisplay *disp = dri3_surf->base.Resource.Display;
+   _EGLDisplay *disp = dri3_surf->surf.base.Resource.Display;
 
-   dri2_flush_drawable_for_swapbuffers(disp, _surf->base);
+   dri2_flush_drawable_for_swapbuffers(disp, _surf->surf.base);
 }
 
 static const struct loader_dri3_vtable egl_dri3_vtable = {
@@ -113,7 +113,7 @@ dri3_set_swap_interval(_EGLDriver *drv, _EGLDisplay *disp, 
_EGLSurface *surf,
 {
struct dri3_egl_surface *dri3_surf = dri3_egl_surface(surf);
 
-   dri3_surf->base.SwapInterval = interval;
+   dri3_surf->surf.base.SwapInterval = interval;
loader_dri3_set_swap_interval(_surf->loader_drawable, interval);
 
return EGL_TRUE;
@@ -145,14 +145,14 @@ dri3_create_surface(_EGLDriver *drv, _EGLDisplay *disp, 
EGLint type,
   drawable = xcb_generate_id(dri2_dpy->conn);
   xcb_create_pixmap(dri2_dpy->conn, conf->BufferSize,
 drawable, dri2_dpy->screen->root,
-dri3_surf->base.Width, dri3_surf->base.Height);
+dri3_surf->surf.base.Width, 
dri3_surf->surf.base.Height);
} else {
   STATIC_ASSERT(sizeof(uintptr_t) == sizeof(native_surface));
   drawable = (uintptr_t) native_surface;
}
 
dri_config = dri2_get_dri_config(dri2_conf, type,
-dri3_surf->base.GLColorspace);
+dri3_surf->surf.base.GLColorspace);
 
if (loader_dri3_drawable_init(dri2_dpy->conn, drawable,
  dri2_dpy->dri_screen,
@@ -164,7 +164,7 @@ dri3_create_surface(_EGLDriver *drv, _EGLDisplay *disp, 
EGLint type,
   goto cleanup_pixmap;
}
 
-   return _surf->base;
+   return _surf->surf.base;
 
  cleanup_pixmap:
if (type == EGL_PBUFFER_BIT)
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev