Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
On 20 November 2015 at 05:37, Vinson Lee wrote: > On Thu, Nov 19, 2015 at 9:36 PM, Vinson Lee wrote: >> On Thu, Nov 19, 2015 at 8:32 AM, Emil Velikov >> wrote: >>> On 19 November 2015 at 16:33, Emil Velikov wrote: From: Emil Velikov Seems that creating an empty one does not fair too well with MacOSX's ar. Considering that all the users of the helper include it only when needed, let's reshuffle the makefile. >>> Forgot to mention - the cause is guesswork, as I'm not that intimate >>> familiar with different AR implementations. Yet this seems the most >>> likely one. >>> >>> Vinson, can you test this ? >>> >>> -Emil >> >> This patch fixed my Mac OS X build error. >> >> Tested-by: Vinson Lee > > Fixed a typo in Tested-by line. > > Tested-by: Vinson Lee So my guesswork was right. Nice :-) Thanks to all for the reviews and testing ! Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
On Thu, Nov 19, 2015 at 9:36 PM, Vinson Lee wrote: > On Thu, Nov 19, 2015 at 8:32 AM, Emil Velikov > wrote: >> On 19 November 2015 at 16:33, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Seems that creating an empty one does not fair too well with MacOSX's >>> ar. Considering that all the users of the helper include it only when >>> needed, let's reshuffle the makefile. >>> >> Forgot to mention - the cause is guesswork, as I'm not that intimate >> familiar with different AR implementations. Yet this seems the most >> likely one. >> >> Vinson, can you test this ? >> >> -Emil > > This patch fixed my Mac OS X build error. > > Tested-by: Vinson Lee Fixed a typo in Tested-by line. Tested-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
On Thu, Nov 19, 2015 at 8:32 AM, Emil Velikov wrote: > On 19 November 2015 at 16:33, Emil Velikov wrote: >> From: Emil Velikov >> >> Seems that creating an empty one does not fair too well with MacOSX's >> ar. Considering that all the users of the helper include it only when >> needed, let's reshuffle the makefile. >> > Forgot to mention - the cause is guesswork, as I'm not that intimate > familiar with different AR implementations. Yet this seems the most > likely one. > > Vinson, can you test this ? > > -Emil This patch fixed my Mac OS X build error. Tested-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
Patches 1, 3, and 4 are Reviewed-by: Matt Turner (I gave an Ack on 2 since I didn't review the list of functions) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
On Thu, Nov 19, 2015 at 8:33 AM, Emil Velikov wrote: > From: Emil Velikov > > Seems that creating an empty one does not fair too well with MacOSX's > ar. Considering that all the users of the helper include it only when > needed, let's reshuffle the makefile. For the series, Reviewed-by: Kristian Høgsberg > Cc: Vinson Lee > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92985 > Signed-off-by: Emil Velikov > --- > src/loader/Makefile.am | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/loader/Makefile.am b/src/loader/Makefile.am > index 5daa42e..5021120 100644 > --- a/src/loader/Makefile.am > +++ b/src/loader/Makefile.am > @@ -23,7 +23,7 @@ include Makefile.sources > > EXTRA_DIST = SConscript > > -noinst_LTLIBRARIES = libloader.la libloader_dri3_helper.la > +noinst_LTLIBRARIES = libloader.la > > AM_CPPFLAGS = \ > $(DEFINES) \ > @@ -57,6 +57,8 @@ libloader_la_LIBADD += \ > endif > > if HAVE_DRI3 > +noinst_LTLIBRARIES += libloader_dri3_helper.la > + > libloader_dri3_helper_la_SOURCES = \ > loader_dri3_helper.c \ > loader_dri3_helper.h > -- > 2.6.2 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
On 19 November 2015 at 16:33, Emil Velikov wrote: > From: Emil Velikov > > Seems that creating an empty one does not fair too well with MacOSX's > ar. Considering that all the users of the helper include it only when > needed, let's reshuffle the makefile. > Forgot to mention - the cause is guesswork, as I'm not that intimate familiar with different AR implementations. Yet this seems the most likely one. Vinson, can you test this ? -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 4/4] automake: loader: don't create an empty dri3 helper
From: Emil Velikov Seems that creating an empty one does not fair too well with MacOSX's ar. Considering that all the users of the helper include it only when needed, let's reshuffle the makefile. Cc: Vinson Lee Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92985 Signed-off-by: Emil Velikov --- src/loader/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/loader/Makefile.am b/src/loader/Makefile.am index 5daa42e..5021120 100644 --- a/src/loader/Makefile.am +++ b/src/loader/Makefile.am @@ -23,7 +23,7 @@ include Makefile.sources EXTRA_DIST = SConscript -noinst_LTLIBRARIES = libloader.la libloader_dri3_helper.la +noinst_LTLIBRARIES = libloader.la AM_CPPFLAGS = \ $(DEFINES) \ @@ -57,6 +57,8 @@ libloader_la_LIBADD += \ endif if HAVE_DRI3 +noinst_LTLIBRARIES += libloader_dri3_helper.la + libloader_dri3_helper_la_SOURCES = \ loader_dri3_helper.c \ loader_dri3_helper.h -- 2.6.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
