[Mesa-dev] [PATCH 4/4] i965: Drop BRW_NEW_VERTEX_PROGRAM and _NEW_TRANSFORM from Gen4 VS state.

2014-12-02 Thread Kenneth Graunke
This simply looks wrong - I don't see any code that uses _NEW_TRANSFORM
or BRW_NEW_VERTEX_PROGRAM.  It looks like the intention was to duplicate
the brw_curbe_offsets atom's flags, which computes brw-curbe.vs_start.
This is unnecessary - we flag BRW_NEW_CURBE_OFFSETS whenever that field
changes; listening to that is sufficient.

Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
 src/mesa/drivers/dri/i965/brw_vs_state.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vs_state.c 
b/src/mesa/drivers/dri/i965/brw_vs_state.c
index 5371f71..17bdbb9 100644
--- a/src/mesa/drivers/dri/i965/brw_vs_state.c
+++ b/src/mesa/drivers/dri/i965/brw_vs_state.c
@@ -96,7 +96,7 @@ brw_upload_vs_unit(struct brw_context *brw)
   brw-vs.prog_data-base.base.dispatch_grf_start_reg;
vs-thread3.urb_entry_read_offset = 0;
 
-   /* BRW_NEW_CURBE_OFFSETS, _NEW_TRANSFORM, BRW_NEW_VERTEX_PROGRAM */
+   /* BRW_NEW_CURBE_OFFSETS */
vs-thread3.const_urb_entry_read_offset = brw-curbe.vs_start * 2;
 
/* BRW_NEW_URB_FENCE */
@@ -183,13 +183,12 @@ brw_upload_vs_unit(struct brw_context *brw)
 
 const struct brw_tracked_state brw_vs_unit = {
.dirty = {
-  .mesa  = _NEW_TRANSFORM,
+  .mesa  = 0,
   .brw   = BRW_NEW_BATCH |
BRW_NEW_CURBE_OFFSETS |
BRW_NEW_PROGRAM_CACHE |
BRW_NEW_SAMPLER_STATE_TABLE |
BRW_NEW_URB_FENCE |
-   BRW_NEW_VERTEX_PROGRAM |
BRW_NEW_VS_PROG_DATA,
},
.emit = brw_upload_vs_unit,
-- 
2.1.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 4/4] i965: Drop BRW_NEW_VERTEX_PROGRAM and _NEW_TRANSFORM from Gen4 VS state.

2014-12-02 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes:

 This simply looks wrong - I don't see any code that uses _NEW_TRANSFORM
 or BRW_NEW_VERTEX_PROGRAM.  It looks like the intention was to duplicate
 the brw_curbe_offsets atom's flags, which computes brw-curbe.vs_start.
 This is unnecessary - we flag BRW_NEW_CURBE_OFFSETS whenever that field
 changes; listening to that is sufficient.

The dependency disappeared in ab973403e445cd8211dba4e87e057a9dc1b1af9d


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev