[Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

2015-12-11 Thread Christian König 
From: Christian König 

Signed-off-by: Christian König 
---
 src/gallium/state_trackers/va/picture.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gallium/state_trackers/va/picture.c 
b/src/gallium/state_trackers/va/picture.c
index 8623139..7b30bf8 100644
--- a/src/gallium/state_trackers/va/picture.c
+++ b/src/gallium/state_trackers/va/picture.c
@@ -92,7 +92,6 @@ vlVaGetReferenceFrame(vlVaDriver *drv, VASurfaceID surface_id,
 static VAStatus
 handlePictureParameterBuffer(vlVaDriver *drv, vlVaContext *context, vlVaBuffer 
*buf)
 {
-   unsigned int i;
VAStatus vaStatus = VA_STATUS_SUCCESS;
 
switch (u_reduce_video_profile(context->templat.profile)) {
-- 
2.5.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

2015-12-14 Thread Julien Isorce 
This patch is:
Reviewed-by: Julien Isorce 

On 11 December 2015 at 12:33, Christian König 
wrote:

> From: Christian König 
>
> Signed-off-by: Christian König 
> ---
>  src/gallium/state_trackers/va/picture.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/va/picture.c
> b/src/gallium/state_trackers/va/picture.c
> index 8623139..7b30bf8 100644
> --- a/src/gallium/state_trackers/va/picture.c
> +++ b/src/gallium/state_trackers/va/picture.c
> @@ -92,7 +92,6 @@ vlVaGetReferenceFrame(vlVaDriver *drv, VASurfaceID
> surface_id,
>  static VAStatus
>  handlePictureParameterBuffer(vlVaDriver *drv, vlVaContext *context,
> vlVaBuffer *buf)
>  {
> -   unsigned int i;
> VAStatus vaStatus = VA_STATUS_SUCCESS;
>
> switch (u_reduce_video_profile(context->templat.profile)) {
> --
> 2.5.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

2015-12-15 Thread Emil Velikov 
On 11 December 2015 at 12:33, Christian König  wrote:
> From: Christian König 
>
> Signed-off-by: Christian König 
> ---
>  src/gallium/state_trackers/va/picture.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/va/picture.c 
> b/src/gallium/state_trackers/va/picture.c
> index 8623139..7b30bf8 100644
> --- a/src/gallium/state_trackers/va/picture.c
> +++ b/src/gallium/state_trackers/va/picture.c
> @@ -92,7 +92,6 @@ vlVaGetReferenceFrame(vlVaDriver *drv, VASurfaceID 
> surface_id,
>  static VAStatus
>  handlePictureParameterBuffer(vlVaDriver *drv, vlVaContext *context, 
> vlVaBuffer *buf)
>  {
> -   unsigned int i;
> VAStatus vaStatus = VA_STATUS_SUCCESS;
>
Can I bribe you to also remove the "set once, used once" variable vaStatus ?

Either way
Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/8] st/va: fix unused variable warning

2015-12-15 Thread Christian König 

On 15.12.2015 11:08, Emil Velikov wrote:

On 11 December 2015 at 12:33, Christian König  wrote:

From: Christian König 

Signed-off-by: Christian König 
---
  src/gallium/state_trackers/va/picture.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/src/gallium/state_trackers/va/picture.c 
b/src/gallium/state_trackers/va/picture.c
index 8623139..7b30bf8 100644
--- a/src/gallium/state_trackers/va/picture.c
+++ b/src/gallium/state_trackers/va/picture.c
@@ -92,7 +92,6 @@ vlVaGetReferenceFrame(vlVaDriver *drv, VASurfaceID surface_id,
  static VAStatus
  handlePictureParameterBuffer(vlVaDriver *drv, vlVaContext *context, 
vlVaBuffer *buf)
  {
-   unsigned int i;
 VAStatus vaStatus = VA_STATUS_SUCCESS;


Can I bribe you to also remove the "set once, used once" variable vaStatus ?


Unfortunately I already pushed this one yesterday after Julien gave me 
his rb. But going to keep that in mind when I touch the function the 
next time.


Regards,
Christian.



Either way
Reviewed-by: Emil Velikov 

-Emil


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev