[Mesa-dev] [PATCH 8/8] egl/drm: rename dri2_drm_create_surface()
From: Emil Velikov
The function can handle only window surfaces, so let's rename it
accordingly, killing the wrapper around it.
Suggested-by: Eric Engestrom
Signed-off-by: Emil Velikov
---
New patch
---
src/egl/drivers/dri2/platform_drm.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_drm.c
b/src/egl/drivers/dri2/platform_drm.c
index 8d56fcb7698..89ad9e0d10c 100644
--- a/src/egl/drivers/dri2/platform_drm.c
+++ b/src/egl/drivers/dri2/platform_drm.c
@@ -91,9 +91,9 @@ has_free_buffers(struct gbm_surface *_surf)
}
static _EGLSurface *
-dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay *disp, EGLint type,
-_EGLConfig *conf, void *native_surface,
-const EGLint *attrib_list)
+dri2_drm_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp,
+ _EGLConfig *conf, void *native_window,
+ const EGLint *attrib_list)
{
struct dri2_egl_display *dri2_dpy = dri2_egl_display(disp);
struct dri2_egl_config *dri2_conf = dri2_egl_config(conf);
@@ -110,7 +110,7 @@ dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay *disp,
EGLint type,
return NULL;
}
- if (!_eglInitSurface(&dri2_surf->base, disp, type, conf, attrib_list))
+ if (!_eglInitSurface(&dri2_surf->base, disp, EGL_WINDOW_BIT, conf,
attrib_list))
goto cleanup_surf;
surf = gbm_dri_surface(window);
@@ -149,15 +149,6 @@ dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay
*disp, EGLint type,
}
static _EGLSurface *
-dri2_drm_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp,
- _EGLConfig *conf, void *native_window,
- const EGLint *attrib_list)
-{
- return dri2_drm_create_surface(drv, disp, EGL_WINDOW_BIT, conf,
- native_window, attrib_list);
-}
-
-static _EGLSurface *
dri2_drm_create_pixmap_surface(_EGLDriver *drv, _EGLDisplay *disp,
_EGLConfig *conf, void *native_window,
const EGLint *attrib_list)
--
2.13.3
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 8/8] egl/drm: rename dri2_drm_create_surface()
On 5 August 2017 at 00:25, Emil Velikov wrote: > From: Emil Velikov > > The function can handle only window surfaces, so let's rename it > accordingly, killing the wrapper around it. > > Suggested-by: Eric Engestrom > Signed-off-by: Emil Velikov > --- > New patch > --- > src/egl/drivers/dri2/platform_drm.c | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/src/egl/drivers/dri2/platform_drm.c > b/src/egl/drivers/dri2/platform_drm.c > index 8d56fcb7698..89ad9e0d10c 100644 > --- a/src/egl/drivers/dri2/platform_drm.c > +++ b/src/egl/drivers/dri2/platform_drm.c > @@ -91,9 +91,9 @@ has_free_buffers(struct gbm_surface *_surf) > } > > static _EGLSurface * > -dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay *disp, EGLint type, > -_EGLConfig *conf, void *native_surface, > -const EGLint *attrib_list) > +dri2_drm_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp, > + _EGLConfig *conf, void *native_window, Fixed this locally to read native_surface, instead of native_window. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 8/8] egl/drm: rename dri2_drm_create_surface()
Patches 2 (few comments), 5,6,7,8: Reviewed-by: Tapani Pälli (for the others I need more coffee) On 08/05/2017 04:30 AM, Emil Velikov wrote: On 5 August 2017 at 00:25, Emil Velikov wrote: From: Emil Velikov The function can handle only window surfaces, so let's rename it accordingly, killing the wrapper around it. Suggested-by: Eric Engestrom Signed-off-by: Emil Velikov --- New patch --- src/egl/drivers/dri2/platform_drm.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index 8d56fcb7698..89ad9e0d10c 100644 --- a/src/egl/drivers/dri2/platform_drm.c +++ b/src/egl/drivers/dri2/platform_drm.c @@ -91,9 +91,9 @@ has_free_buffers(struct gbm_surface *_surf) } static _EGLSurface * -dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay *disp, EGLint type, -_EGLConfig *conf, void *native_surface, -const EGLint *attrib_list) +dri2_drm_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp, + _EGLConfig *conf, void *native_window, Fixed this locally to read native_surface, instead of native_window. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 8/8] egl/drm: rename dri2_drm_create_surface()
On Saturday, 2017-08-05 02:30:51 +0100, Emil Velikov wrote: > On 5 August 2017 at 00:25, Emil Velikov wrote: > > From: Emil Velikov > > > > The function can handle only window surfaces, so let's rename it > > accordingly, killing the wrapper around it. > > > > Suggested-by: Eric Engestrom > > Signed-off-by: Emil Velikov > > --- > > New patch > > --- > > src/egl/drivers/dri2/platform_drm.c | 17 - > > 1 file changed, 4 insertions(+), 13 deletions(-) > > > > diff --git a/src/egl/drivers/dri2/platform_drm.c > > b/src/egl/drivers/dri2/platform_drm.c > > index 8d56fcb7698..89ad9e0d10c 100644 > > --- a/src/egl/drivers/dri2/platform_drm.c > > +++ b/src/egl/drivers/dri2/platform_drm.c > > @@ -91,9 +91,9 @@ has_free_buffers(struct gbm_surface *_surf) > > } > > > > static _EGLSurface * > > -dri2_drm_create_surface(_EGLDriver *drv, _EGLDisplay *disp, EGLint type, > > -_EGLConfig *conf, void *native_surface, > > -const EGLint *attrib_list) > > +dri2_drm_create_window_surface(_EGLDriver *drv, _EGLDisplay *disp, > > + _EGLConfig *conf, void *native_window, > > Fixed this locally to read native_surface, instead of native_window. With that fixed: Reviewed-by: Eric Engestrom ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
