[Mesa-dev] [PATCH 8/9] nir/spirv: Use breaks instead of returns in constant handling

[Jason Ekstrand]

Signed-off-by: Jason Ekstrand 
Cc: "12.0" 
Cc: Ian Romanick 
---
 src/compiler/spirv/spirv_to_nir.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c 
b/src/compiler/spirv/spirv_to_nir.c
index 4061b8a..bb7aba4 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -1028,7 +1028,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
val->constant->value.u[i] = u[comp];
 }
  }
- return;
+ break;
   }
 
   case SpvOpCompositeExtract:
@@ -1105,7 +1105,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
   (*c)->value.u[elem + i] = insert->constant->value.u[i];
 }
  }
- return;
+ break;
   }
 
   default: {
@@ -1134,9 +1134,10 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
  for (unsigned k = 0; k < num_components; k++)
 val->constant->value.u[k] = res.u32[k];
 
- return;
+ break;
   } /* default */
   }
+  break;
}
 
case SpvOpConstantNull:
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 8/9] nir/spirv: Use breaks instead of returns in constant handling

[Jason Ekstrand]

Signed-off-by: Jason Ekstrand 
Cc: "12.0" 
Cc: Ian Romanick 
---
 src/compiler/spirv/spirv_to_nir.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c 
b/src/compiler/spirv/spirv_to_nir.c
index 4061b8a..bb7aba4 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -1028,7 +1028,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
val->constant->value.u[i] = u[comp];
 }
  }
- return;
+ break;
   }
 
   case SpvOpCompositeExtract:
@@ -1105,7 +1105,7 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
   (*c)->value.u[elem + i] = insert->constant->value.u[i];
 }
  }
- return;
+ break;
   }
 
   default: {
@@ -1134,9 +1134,10 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
  for (unsigned k = 0; k < num_components; k++)
 val->constant->value.u[k] = res.u32[k];
 
- return;
+ break;
   } /* default */
   }
+  break;
}
 
case SpvOpConstantNull:
-- 
2.5.0.400.gff86faf

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev