Re: [Mesa-dev] [PATCH V2 05/17] i915: Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.
5 and 6 look good. One nitpick, please prefix the i915g changes with i915g instead of i915 so it's obvious which driver is being changed from just looking at a git log. Stéphane On Thu, Nov 28, 2013 at 12:56 AM, Siavash Eliasi siavashser...@gmail.com wrote: --- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 --- a/src/gallium/drivers/i915/i915_resource_buffer.c +++ b/src/gallium/drivers/i915/i915_resource_buffer.c @@ -135,7 +135,7 @@ i915_buffer_create(struct pipe_screen *screen, buf-b.vtbl = i915_buffer_vtbl; pipe_reference_init(buf-b.b.reference, 1); buf-b.b.screen = screen; - buf-data = align_malloc(template-width0, 16); + buf-data = align_malloc(template-width0, 64); buf-free_on_destroy = TRUE; if (!buf-data) -- 1.8.4.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH V2 05/17] i915: Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.
Thank you for reviewing these patches, changes to commit messages are done: http://lists.freedesktop.org/archives/mesa-dev/2013-December/049581.html http://lists.freedesktop.org/archives/mesa-dev/2013-December/049582.html Best regards, Siavash Eliasi. On 12/03/2013 06:36 AM, Stéphane Marchesin wrote: 5 and 6 look good. One nitpick, please prefix the i915g changes with i915g instead of i915 so it's obvious which driver is being changed from just looking at a git log. Stéphane On Thu, Nov 28, 2013 at 12:56 AM, Siavash Eliasi siavashser...@gmail.com wrote: --- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 --- a/src/gallium/drivers/i915/i915_resource_buffer.c +++ b/src/gallium/drivers/i915/i915_resource_buffer.c @@ -135,7 +135,7 @@ i915_buffer_create(struct pipe_screen *screen, buf-b.vtbl = i915_buffer_vtbl; pipe_reference_init(buf-b.b.reference, 1); buf-b.b.screen = screen; - buf-data = align_malloc(template-width0, 16); + buf-data = align_malloc(template-width0, 64); buf-free_on_destroy = TRUE; if (!buf-data) -- 1.8.4.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH V2 05/17] i915: Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.
--- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 --- a/src/gallium/drivers/i915/i915_resource_buffer.c +++ b/src/gallium/drivers/i915/i915_resource_buffer.c @@ -135,7 +135,7 @@ i915_buffer_create(struct pipe_screen *screen, buf-b.vtbl = i915_buffer_vtbl; pipe_reference_init(buf-b.b.reference, 1); buf-b.b.screen = screen; - buf-data = align_malloc(template-width0, 16); + buf-data = align_malloc(template-width0, 64); buf-free_on_destroy = TRUE; if (!buf-data) -- 1.8.4.2 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
