Re: [Mesa-dev] [PATCH mesa] intel/compiler: remove unused get_image_base_type()

2018-09-03 Thread Jason Ekstrand
Acked-by: Jason Ekstrand 

On Mon, Sep 3, 2018 at 12:08 PM Eric Engestrom  wrote:

> Unused since 09f1de97a76a4990fd7c "anv,i965: Lower away image derefs in
> the driver".
>
> Cc: Jason Ekstrand 
> Signed-off-by: Eric Engestrom 
> ---
>  src/intel/compiler/brw_fs_nir.cpp | 19 ---
>  1 file changed, 19 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs_nir.cpp
> b/src/intel/compiler/brw_fs_nir.cpp
> index 2fef050f81a233491126..d5a5f60f942940e02904 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -1712,25 +1712,6 @@ fs_visitor::emit_percomp(const fs_builder ,
> const fs_inst ,
> }
>  }
>
> -/**
> - * Get the matching channel register datatype for an image intrinsic of
> the
> - * specified GLSL image type.
> - */
> -static brw_reg_type
> -get_image_base_type(const glsl_type *type)
> -{
> -   switch ((glsl_base_type)type->sampled_type) {
> -   case GLSL_TYPE_UINT:
> -  return BRW_REGISTER_TYPE_UD;
> -   case GLSL_TYPE_INT:
> -  return BRW_REGISTER_TYPE_D;
> -   case GLSL_TYPE_FLOAT:
> -  return BRW_REGISTER_TYPE_F;
> -   default:
> -  unreachable("Not reached.");
> -   }
> -}
> -
>  static fs_inst *
>  emit_pixel_interpolater_send(const fs_builder ,
>   enum opcode opcode,
> --
> Cheers,
>   Eric
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH mesa] intel/compiler: remove unused get_image_base_type()

2018-09-03 Thread Eric Engestrom
Unused since 09f1de97a76a4990fd7c "anv,i965: Lower away image derefs in
the driver".

Cc: Jason Ekstrand 
Signed-off-by: Eric Engestrom 
---
 src/intel/compiler/brw_fs_nir.cpp | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/src/intel/compiler/brw_fs_nir.cpp 
b/src/intel/compiler/brw_fs_nir.cpp
index 2fef050f81a233491126..d5a5f60f942940e02904 100644
--- a/src/intel/compiler/brw_fs_nir.cpp
+++ b/src/intel/compiler/brw_fs_nir.cpp
@@ -1712,25 +1712,6 @@ fs_visitor::emit_percomp(const fs_builder , const 
fs_inst ,
}
 }
 
-/**
- * Get the matching channel register datatype for an image intrinsic of the
- * specified GLSL image type.
- */
-static brw_reg_type
-get_image_base_type(const glsl_type *type)
-{
-   switch ((glsl_base_type)type->sampled_type) {
-   case GLSL_TYPE_UINT:
-  return BRW_REGISTER_TYPE_UD;
-   case GLSL_TYPE_INT:
-  return BRW_REGISTER_TYPE_D;
-   case GLSL_TYPE_FLOAT:
-  return BRW_REGISTER_TYPE_F;
-   default:
-  unreachable("Not reached.");
-   }
-}
-
 static fs_inst *
 emit_pixel_interpolater_send(const fs_builder ,
  enum opcode opcode,
-- 
Cheers,
  Eric

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev