[Mesa-dev] [PATCH mesa 5/6] meson: make it trivial to add other -Wno-foo CFLAGS

2018-09-21 Thread Eric Engestrom
Signed-off-by: Eric Engestrom 
---
 meson.build | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/meson.build b/meson.build
index 7b7bf4d8e609c92bbd06..863962186caa6afe8ae4 100644
--- a/meson.build
+++ b/meson.build
@@ -790,9 +790,12 @@ foreach a : ['-Wall', 
'-Werror=implicit-function-declaration',
 c_args += a
   endif
 endforeach
-if cc.has_argument('-Wmissing-field-initializers')
-  c_args += '-Wno-missing-field-initializers'
-endif
+
+foreach a : ['missing-field-initializers']
+  if cc.has_argument('-W' + a)
+c_args += '-Wno-' + a
+  endif
+endforeach
 
 c_vis_args = []
 if cc.has_argument('-fvisibility=hidden')
-- 
Cheers,
  Eric

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH mesa 5/6] meson: make it trivial to add other -Wno-foo CFLAGS

2018-09-24 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-21 06:50:40)
> Signed-off-by: Eric Engestrom 
> ---
>  meson.build | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 7b7bf4d8e609c92bbd06..863962186caa6afe8ae4 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -790,9 +790,12 @@ foreach a : ['-Wall', 
> '-Werror=implicit-function-declaration',
>  c_args += a
>endif
>  endforeach
> -if cc.has_argument('-Wmissing-field-initializers')
> -  c_args += '-Wno-missing-field-initializers'
> -endif
> +
> +foreach a : ['missing-field-initializers']
> +  if cc.has_argument('-W' + a)
> +c_args += '-Wno-' + a
> +  endif
> +endforeach
>  
>  c_vis_args = []
>  if cc.has_argument('-fvisibility=hidden')
> -- 
> Cheers,
>   Eric
> 

I thought I reviewed this patch already,

Reviewed-by: Dylan Baker 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev