Re: [Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

2017-06-16 Thread Daniel Stone 
Hi,

On 15 June 2017 at 21:47, Robert Foss  wrote:
> From: Rob Herring 
> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
> index 19be440d48..58b62ac361 100644
> --- a/src/gbm/backends/dri/gbm_dri.c
> +++ b/src/gbm/backends/dri/gbm_dri.c
> @@ -1067,7 +1067,7 @@ create_dumb(struct gbm_device *gbm,
> is_cursor = (usage & GBM_BO_USE_CURSOR) != 0 &&
>format == GBM_FORMAT_ARGB;
> is_scanout = (usage & GBM_BO_USE_SCANOUT) != 0 &&
> -  format == GBM_FORMAT_XRGB;
> +  (format == GBM_FORMAT_XRGB || format == GBM_FORMAT_XBGR);

Funny, I've just been exactly here myself, cursing at the weird and
asymmetric hardcoded list of formats. Good times.

Reviewed-by: Daniel Stone 

Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

2017-06-16 Thread Emil Velikov 
On 15 June 2017 at 21:47, Robert Foss  wrote:
> From: Rob Herring 
>
> Signed-off-by: Rob Herring 
> ---
>  src/gbm/backends/dri/gbm_dri.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
> index 19be440d48..58b62ac361 100644
> --- a/src/gbm/backends/dri/gbm_dri.c
> +++ b/src/gbm/backends/dri/gbm_dri.c
> @@ -1067,7 +1067,7 @@ create_dumb(struct gbm_device *gbm,
> is_cursor = (usage & GBM_BO_USE_CURSOR) != 0 &&
>format == GBM_FORMAT_ARGB;
> is_scanout = (usage & GBM_BO_USE_SCANOUT) != 0 &&
> -  format == GBM_FORMAT_XRGB;
> +  (format == GBM_FORMAT_XRGB || format == GBM_FORMAT_XBGR);
AFAICT there's no other parts that need updating.

Still, the commit message should mention, an actual use case for the
extra format.

With that
Reviewed-by: Emil Velikov 

Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v1 4/7] gbm: add XBGR8888 support for dumb buffers

2017-06-15 Thread Robert Foss 
From: Rob Herring 

Signed-off-by: Rob Herring 
---
 src/gbm/backends/dri/gbm_dri.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index 19be440d48..58b62ac361 100644
--- a/src/gbm/backends/dri/gbm_dri.c
+++ b/src/gbm/backends/dri/gbm_dri.c
@@ -1067,7 +1067,7 @@ create_dumb(struct gbm_device *gbm,
is_cursor = (usage & GBM_BO_USE_CURSOR) != 0 &&
   format == GBM_FORMAT_ARGB;
is_scanout = (usage & GBM_BO_USE_SCANOUT) != 0 &&
-  format == GBM_FORMAT_XRGB;
+  (format == GBM_FORMAT_XRGB || format == GBM_FORMAT_XBGR);
if (!is_cursor && !is_scanout) {
   errno = EINVAL;
   return NULL;
-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev