[Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test
Fixes the following compile error, present when the SHA1 library is libgcrypt: CCLD glsl/tests/cache-test glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function `call_once': /mesa/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once' Signed-off-by: Rhys Kidd --- v2: Add additional comment to the commit message (Timothy Arceri) src/compiler/Makefile.glsl.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/Makefile.glsl.am b/src/compiler/Makefile.glsl.am index 80dfb73..15bea6b 100644 --- a/src/compiler/Makefile.glsl.am +++ b/src/compiler/Makefile.glsl.am @@ -62,8 +62,11 @@ glsl_tests_blob_test_LDADD = \ glsl_tests_cache_test_SOURCES =\ glsl/tests/cache_test.c +glsl_tests_cache_test_CFLAGS = \ + $(PTHREAD_CFLAGS) glsl_tests_cache_test_LDADD = \ - glsl/libglsl.la + glsl/libglsl.la \ + $(PTHREAD_LIBS) glsl_tests_general_ir_test_SOURCES = \ glsl/tests/builtin_variable_test.cpp\ -- 2.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test
Reviewed-by: Timothy Arceri I guess you don't have commit access? On Wed, 2016-10-26 at 00:13 -0400, Rhys Kidd wrote: > Fixes the following compile error, present when the SHA1 library is > libgcrypt: > > CCLD glsl/tests/cache-test > glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function > `call_once': > /mesa/src/util/../../include/c11/threads_posix.h:96: undefined > reference to `pthread_once' > > Signed-off-by: Rhys Kidd > --- > v2: > Add additional comment to the commit message (Timothy Arceri) > > src/compiler/Makefile.glsl.am | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/Makefile.glsl.am > b/src/compiler/Makefile.glsl.am > index 80dfb73..15bea6b 100644 > --- a/src/compiler/Makefile.glsl.am > +++ b/src/compiler/Makefile.glsl.am > @@ -62,8 +62,11 @@ glsl_tests_blob_test_LDADD = > \ > > glsl_tests_cache_test_SOURCES = \ > glsl/tests/cache_test.c > +glsl_tests_cache_test_CFLAGS = \ > + $(PTHREAD_CFLAGS) > glsl_tests_cache_test_LDADD =\ > - glsl/libglsl.la > + glsl/libglsl.la \ > + $(PTHREAD_LIBS) > > glsl_tests_general_ir_test_SOURCES = \ > glsl/tests/builtin_variable_test.cpp\ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test
On 26 October 2016 at 00:47, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > I guess you don't have commit access? > I do not have commit access, so would appreciate if you could please push to master. > > On Wed, 2016-10-26 at 00:13 -0400, Rhys Kidd wrote: > > Fixes the following compile error, present when the SHA1 library is > > libgcrypt: > > > > CCLD glsl/tests/cache-test > > glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function > > `call_once': > > /mesa/src/util/../../include/c11/threads_posix.h:96: undefined > > reference to `pthread_once' > > > > Signed-off-by: Rhys Kidd > > --- > > v2: > > Add additional comment to the commit message (Timothy Arceri) > > > > src/compiler/Makefile.glsl.am | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/src/compiler/Makefile.glsl.am > > b/src/compiler/Makefile.glsl.am > > index 80dfb73..15bea6b 100644 > > --- a/src/compiler/Makefile.glsl.am > > +++ b/src/compiler/Makefile.glsl.am > > @@ -62,8 +62,11 @@ glsl_tests_blob_test_LDADD = > > \ > > > > glsl_tests_cache_test_SOURCES = \ > > glsl/tests/cache_test.c > > +glsl_tests_cache_test_CFLAGS = \ > > + $(PTHREAD_CFLAGS) > > glsl_tests_cache_test_LDADD =\ > > - glsl/libglsl.la > > + glsl/libglsl.la \ > > + $(PTHREAD_LIBS) > > > > glsl_tests_general_ir_test_SOURCES = \ > > glsl/tests/builtin_variable_test.cpp\ > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev