[Mesa-dev] [PATCH v2 00/19] i965/fs: Remove the width field from fs_reg

2015-06-25 Thread Jason Ekstrand
This is a re-send of the series I did a week or two ago to remove the width
field from the fs_reg class.  I really didn't want to do a re-send but
there have been enough fixes since then that I thought it was worth
re-sending.  Most of these patches have already been reviewed but not all.

02: New.  Needs to be reviewed by someone familiar with SKL

03: Needs re-review.  This one is affected by 02.

05: Needs re-review.  This one went through a lot of changes to actually
get it right.  It should be the way we want now.

08: New.  It's just moving code around so it should be trivial.

09: New.  This is a complete replacement of patch 07 from the previous
series.

Cc: Topi Pohjolainen 
Cc: Iago Toral Quiroga 
Cc: Francisco Jerez 
Cc: Neil Roberts 

Jason Ekstrand (19):
  i965/fs: Use a switch statement in fs_inst::regs_read()
  i965/fs: Actually set/use the mlen for gen7 uniform pull constant
loads
  i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads
  i965/fs: Report the right value in fs_inst::regs_read() for PIXEL_X/Y
  i965/fs: Explicitly set the exec_size on the add(32) in interpolation
setup
  i965/fs: Set the builder group for emitting FB-write stencil/AA alpha
  i965/blorp: Explicitly set execution sizes for new'd instructions
  i965/fs: Move offset(fs_reg, unsigned) to brw_fs.h
  i965/fs: Add a builder argument to offset()
  i965/fs: Make better use of the builder in shader_time
  i965/fs: Remove fs_inst constructors that don't take an explicit
exec_size
  i965/fs: Use exec_size for determining regs read/written and partial
writes
  i965/fs_builder: Use the dispatch width for setting exec sizes
  i965/fs: Remove exec_size guessing from fs_inst::init()
  i965/fs: Use the builder dispatch width instead of dst.width for pull
constants
  i965/fs: Use the builder dispatch_width for computing register offsets
  i965/fs: Use exec_size instead of dst.width for computing component
size
  i965/fs_generator: Use inst->exec_size for determining hardware reg
widths
  i965/fs: Remove the width field from fs_reg

 src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp|   9 +-
 src/mesa/drivers/dri/i965/brw_fs.cpp   | 266 -
 src/mesa/drivers/dri/i965/brw_fs.h |  21 ++
 src/mesa/drivers/dri/i965/brw_fs_builder.h |  37 ++-
 .../drivers/dri/i965/brw_fs_copy_propagation.cpp   |   4 -
 src/mesa/drivers/dri/i965/brw_fs_cse.cpp   |  10 +-
 src/mesa/drivers/dri/i965/brw_fs_generator.cpp |  23 +-
 src/mesa/drivers/dri/i965/brw_fs_nir.cpp   |  64 ++---
 src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp  |   4 +-
 .../drivers/dri/i965/brw_fs_register_coalesce.cpp  |   3 +-
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp   | 183 +++---
 src/mesa/drivers/dri/i965/brw_ir_fs.h  |  45 +---
 .../drivers/dri/i965/brw_schedule_instructions.cpp |   4 +-
 13 files changed, 287 insertions(+), 386 deletions(-)

-- 
2.4.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH v2 00/19] i965/fs: Remove the width field from fs_reg

2015-06-26 Thread Francisco Jerez
Jason Ekstrand  writes:

> This is a re-send of the series I did a week or two ago to remove the width
> field from the fs_reg class.  I really didn't want to do a re-send but
> there have been enough fixes since then that I thought it was worth
> re-sending.  Most of these patches have already been reviewed but not all.
>
> 02: New.  Needs to be reviewed by someone familiar with SKL
>
> 03: Needs re-review.  This one is affected by 02.
>
> 05: Needs re-review.  This one went through a lot of changes to actually
> get it right.  It should be the way we want now.
>
> 08: New.  It's just moving code around so it should be trivial.
>
> 09: New.  This is a complete replacement of patch 07 from the previous
> series.
>
> Cc: Topi Pohjolainen 
> Cc: Iago Toral Quiroga 
> Cc: Francisco Jerez 
> Cc: Neil Roberts 
>
Since you seem to have R-b tags from Iago or Topi on all patches already
and from a quick look it seemed generally reasonable, the series is:

Acked-by: Francisco Jerez 

Thanks.

> Jason Ekstrand (19):
>   i965/fs: Use a switch statement in fs_inst::regs_read()
>   i965/fs: Actually set/use the mlen for gen7 uniform pull constant
> loads
>   i965/fs: Fix fs_inst::regs_read() for uniform pull constant loads
>   i965/fs: Report the right value in fs_inst::regs_read() for PIXEL_X/Y
>   i965/fs: Explicitly set the exec_size on the add(32) in interpolation
> setup
>   i965/fs: Set the builder group for emitting FB-write stencil/AA alpha
>   i965/blorp: Explicitly set execution sizes for new'd instructions
>   i965/fs: Move offset(fs_reg, unsigned) to brw_fs.h
>   i965/fs: Add a builder argument to offset()
>   i965/fs: Make better use of the builder in shader_time
>   i965/fs: Remove fs_inst constructors that don't take an explicit
> exec_size
>   i965/fs: Use exec_size for determining regs read/written and partial
> writes
>   i965/fs_builder: Use the dispatch width for setting exec sizes
>   i965/fs: Remove exec_size guessing from fs_inst::init()
>   i965/fs: Use the builder dispatch width instead of dst.width for pull
> constants
>   i965/fs: Use the builder dispatch_width for computing register offsets
>   i965/fs: Use exec_size instead of dst.width for computing component
> size
>   i965/fs_generator: Use inst->exec_size for determining hardware reg
> widths
>   i965/fs: Remove the width field from fs_reg
>
>  src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp|   9 +-
>  src/mesa/drivers/dri/i965/brw_fs.cpp   | 266 
> -
>  src/mesa/drivers/dri/i965/brw_fs.h |  21 ++
>  src/mesa/drivers/dri/i965/brw_fs_builder.h |  37 ++-
>  .../drivers/dri/i965/brw_fs_copy_propagation.cpp   |   4 -
>  src/mesa/drivers/dri/i965/brw_fs_cse.cpp   |  10 +-
>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp |  23 +-
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp   |  64 ++---
>  src/mesa/drivers/dri/i965/brw_fs_reg_allocate.cpp  |   4 +-
>  .../drivers/dri/i965/brw_fs_register_coalesce.cpp  |   3 +-
>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp   | 183 +++---
>  src/mesa/drivers/dri/i965/brw_ir_fs.h  |  45 +---
>  .../drivers/dri/i965/brw_schedule_instructions.cpp |   4 +-
>  13 files changed, 287 insertions(+), 386 deletions(-)
>
> -- 
> 2.4.3


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev