Re: [Mesa-dev] [PATCH v2 02/32] intel/blorp: Use isl_surf_get_image_offset_B_tile_el in ccs_ambiguate

2019-01-25 Thread Nanley Chery
On Fri, Oct 12, 2018 at 01:46:32PM -0500, Jason Ekstrand wrote:
> Reviewed-by: Topi Pohjolainen 
> ---
>  src/intel/blorp/blorp_clear.c | 8 ++--
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 


Patches 1 and 2 are:
Reviewed-by: Nanley Chery 

> diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
> index 5b575dccc22..dd974df35d2 100644
> --- a/src/intel/blorp/blorp_clear.c
> +++ b/src/intel/blorp/blorp_clear.c
> @@ -1086,12 +1086,8 @@ blorp_ccs_ambiguate(struct blorp_batch *batch,
> }
>  
> uint32_t offset_B, x_offset_el, y_offset_el;
> -   isl_surf_get_image_offset_el(surf->aux_surf, level, layer, z,
> -&x_offset_el, &y_offset_el);
> -   isl_tiling_get_intratile_offset_el(surf->aux_surf->tiling, aux_fmtl->bpb,
> -  surf->aux_surf->row_pitch_B,
> -  x_offset_el, y_offset_el,
> -  &offset_B, &x_offset_el, &y_offset_el);
> +   isl_surf_get_image_offset_B_tile_el(surf->aux_surf, level, layer, z,
> +   &offset_B, &x_offset_el, 
> &y_offset_el);
> params.dst.addr.offset += offset_B;
>  
> const uint32_t width_px =
> -- 
> 2.19.1
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH v2 02/32] intel/blorp: Use isl_surf_get_image_offset_B_tile_el in ccs_ambiguate

2018-10-12 Thread Jason Ekstrand
Reviewed-by: Topi Pohjolainen 
---
 src/intel/blorp/blorp_clear.c | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index 5b575dccc22..dd974df35d2 100644
--- a/src/intel/blorp/blorp_clear.c
+++ b/src/intel/blorp/blorp_clear.c
@@ -1086,12 +1086,8 @@ blorp_ccs_ambiguate(struct blorp_batch *batch,
}
 
uint32_t offset_B, x_offset_el, y_offset_el;
-   isl_surf_get_image_offset_el(surf->aux_surf, level, layer, z,
-&x_offset_el, &y_offset_el);
-   isl_tiling_get_intratile_offset_el(surf->aux_surf->tiling, aux_fmtl->bpb,
-  surf->aux_surf->row_pitch_B,
-  x_offset_el, y_offset_el,
-  &offset_B, &x_offset_el, &y_offset_el);
+   isl_surf_get_image_offset_B_tile_el(surf->aux_surf, level, layer, z,
+   &offset_B, &x_offset_el, &y_offset_el);
params.dst.addr.offset += offset_B;
 
const uint32_t width_px =
-- 
2.19.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev