Re: [Mesa-dev] [PATCH v2 7/8] i965: Drop _NEW_TRANSFORM from 3DSTATE_VS atom on Gen7.

[Jason Ekstrand]

rb

On Mon, Oct 3, 2016 at 9:41 PM, Kenneth Graunke 
wrote:

> The atom that uploads push constants listens to _NEW_TRANSFORM for
> legacy clip plane handling.  On Sandybridge, the gen6_vs_state atom
> emits 3DSTATE_CONSTANT_VS as well as 3DSTATE_VS, so it needs to listen
> to the same set of conditions.
>
> However, it looks like Gen7 doesn't need this.  The push constant atom
> emits 3DSTATE_CONSTANT_VS directly, and the gen7_vs_state atom that
> emits 3DSTATE_VS doesn't have a dependency on ctx->Transform.
>
> Signed-off-by: Kenneth Graunke 
> ---
>  src/mesa/drivers/dri/i965/gen7_vs_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Whoops :( I meant to remove it from gen6_vs_state, not the push constant
> atom...and frankly, even that's not right.  Thanks for catching that.
>
> Here's a v2 that just changes Ivybridge.
>
> diff --git a/src/mesa/drivers/dri/i965/gen7_vs_state.c
> b/src/mesa/drivers/dri/i965/gen7_vs_state.c
> index 57e0419..cfd535e 100644
> --- a/src/mesa/drivers/dri/i965/gen7_vs_state.c
> +++ b/src/mesa/drivers/dri/i965/gen7_vs_state.c
> @@ -75,7 +75,7 @@ upload_vs_state(struct brw_context *brw)
>
>  const struct brw_tracked_state gen7_vs_state = {
> .dirty = {
> -  .mesa  = _NEW_TRANSFORM,
> +  .mesa  = 0,
>.brw   = BRW_NEW_BATCH |
> BRW_NEW_BLORP |
> BRW_NEW_CONTEXT |
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 7/8] i965: Drop _NEW_TRANSFORM from 3DSTATE_VS atom on Gen7.

[Kenneth Graunke]

The atom that uploads push constants listens to _NEW_TRANSFORM for
legacy clip plane handling.  On Sandybridge, the gen6_vs_state atom
emits 3DSTATE_CONSTANT_VS as well as 3DSTATE_VS, so it needs to listen
to the same set of conditions.

However, it looks like Gen7 doesn't need this.  The push constant atom
emits 3DSTATE_CONSTANT_VS directly, and the gen7_vs_state atom that
emits 3DSTATE_VS doesn't have a dependency on ctx->Transform.

Signed-off-by: Kenneth Graunke 
---
 src/mesa/drivers/dri/i965/gen7_vs_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Whoops :( I meant to remove it from gen6_vs_state, not the push constant
atom...and frankly, even that's not right.  Thanks for catching that.

Here's a v2 that just changes Ivybridge.

diff --git a/src/mesa/drivers/dri/i965/gen7_vs_state.c 
b/src/mesa/drivers/dri/i965/gen7_vs_state.c
index 57e0419..cfd535e 100644
--- a/src/mesa/drivers/dri/i965/gen7_vs_state.c
+++ b/src/mesa/drivers/dri/i965/gen7_vs_state.c
@@ -75,7 +75,7 @@ upload_vs_state(struct brw_context *brw)
 
 const struct brw_tracked_state gen7_vs_state = {
.dirty = {
-  .mesa  = _NEW_TRANSFORM,
+  .mesa  = 0,
   .brw   = BRW_NEW_BATCH |
BRW_NEW_BLORP |
BRW_NEW_CONTEXT |
-- 
2.10.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev