Re: [Mesa-dev] [PATCH v3 13/42] intel/compiler: lower 16-bit flrp
Sorry about that, I split them like this because one change is for NIR and the other one is for Intel so I thought it was preferred to keep changes like this in separate patches. Anyway, I understand that for small changes like this it is not helpful, I'll keep that in mind for future patches. On Thu, 2019-01-17 at 14:04 -0600, Jason Ekstrand wrote: > Again, please squash with the previous patch. Splitting stuff this > granular just makes review harder. > > On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga > wrote: > > Reviewed-by: Jason Ekstrand > > > > --- > > > > src/intel/compiler/brw_compiler.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/src/intel/compiler/brw_compiler.c > > b/src/intel/compiler/brw_compiler.c > > > > index f885e79c3e6..04a1a7cac4e 100644 > > > > --- a/src/intel/compiler/brw_compiler.c > > > > +++ b/src/intel/compiler/brw_compiler.c > > > > @@ -33,6 +33,7 @@ > > > > .lower_sub = true, > >\ > > > > .lower_fdiv = true, > > \ > > > > .lower_scmp = true, > > \ > > > > + .lower_flrp16 = true, > > \ > > > > .lower_fmod16 = true, > > \ > > > > .lower_fmod32 = true, > > \ > > > > .lower_fmod64 = false, > >\ > > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v3 13/42] intel/compiler: lower 16-bit flrp
Again, please squash with the previous patch. Splitting stuff this granular just makes review harder. On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga wrote: > Reviewed-by: Jason Ekstrand > --- > src/intel/compiler/brw_compiler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/intel/compiler/brw_compiler.c > b/src/intel/compiler/brw_compiler.c > index f885e79c3e6..04a1a7cac4e 100644 > --- a/src/intel/compiler/brw_compiler.c > +++ b/src/intel/compiler/brw_compiler.c > @@ -33,6 +33,7 @@ > .lower_sub = true, > \ > .lower_fdiv = true, > \ > .lower_scmp = true, > \ > + .lower_flrp16 = true, > \ > .lower_fmod16 = true, > \ > .lower_fmod32 = true, > \ > .lower_fmod64 = false, > \ > -- > 2.17.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH v3 13/42] intel/compiler: lower 16-bit flrp
Reviewed-by: Jason Ekstrand --- src/intel/compiler/brw_compiler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_compiler.c b/src/intel/compiler/brw_compiler.c index f885e79c3e6..04a1a7cac4e 100644 --- a/src/intel/compiler/brw_compiler.c +++ b/src/intel/compiler/brw_compiler.c @@ -33,6 +33,7 @@ .lower_sub = true, \ .lower_fdiv = true,\ .lower_scmp = true,\ + .lower_flrp16 = true, \ .lower_fmod16 = true, \ .lower_fmod32 = true, \ .lower_fmod64 = false, \ -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
