Re: [Mesa-dev] [PATCH v3 29/34] i965: Don't link when the program was found in the disk cache

2017-10-30 Thread Kenneth Graunke
On Sunday, October 22, 2017 1:01:37 PM PDT Jordan Justen wrote:
> Signed-off-by: Jordan Justen 
> Cc: Timothy Arceri 
> ---
>  src/mesa/drivers/dri/i965/brw_link.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp 
> b/src/mesa/drivers/dri/i965/brw_link.cpp
> index 988dd3a73d7..9019db56aa0 100644
> --- a/src/mesa/drivers/dri/i965/brw_link.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_link.cpp
> @@ -225,6 +225,9 @@ brw_link_shader(struct gl_context *ctx, struct 
> gl_shader_program *shProg)
> unsigned int stage;
> struct shader_info *infos[MESA_SHADER_STAGES] = { 0, };
>  
> +   if (shProg->data->LinkStatus == linking_skipped)
> +  return GL_TRUE;
> +
> for (stage = 0; stage < ARRAY_SIZE(shProg->_LinkedShaders); stage++) {
>struct gl_linked_shader *shader = shProg->_LinkedShaders[stage];
>if (!shader)
> 

I was concerned that we might be skipping some steps here, but I think
everything's OK...

Reviewed-by: Kenneth Graunke 


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH v3 29/34] i965: Don't link when the program was found in the disk cache

2017-10-22 Thread Jordan Justen
Signed-off-by: Jordan Justen 
Cc: Timothy Arceri 
---
 src/mesa/drivers/dri/i965/brw_link.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_link.cpp 
b/src/mesa/drivers/dri/i965/brw_link.cpp
index 988dd3a73d7..9019db56aa0 100644
--- a/src/mesa/drivers/dri/i965/brw_link.cpp
+++ b/src/mesa/drivers/dri/i965/brw_link.cpp
@@ -225,6 +225,9 @@ brw_link_shader(struct gl_context *ctx, struct 
gl_shader_program *shProg)
unsigned int stage;
struct shader_info *infos[MESA_SHADER_STAGES] = { 0, };
 
+   if (shProg->data->LinkStatus == linking_skipped)
+  return GL_TRUE;
+
for (stage = 0; stage < ARRAY_SIZE(shProg->_LinkedShaders); stage++) {
   struct gl_linked_shader *shader = shProg->_LinkedShaders[stage];
   if (!shader)
-- 
2.15.0.rc0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev