Re: [Mesa-dev] [PATCH v4 3/3] README: Add note about meson

[Dylan Baker]

Quoting Eric Engestrom (2018-01-05 05:49:25)
> On Thursday, 2018-01-04 10:28:42 -0800, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker 
> 
> Couple nitpicks, but:
> Reviewed-by: Eric Engestrom 
> 
> > ---
> >  README | 21 ++---
> >  1 file changed, 18 insertions(+), 3 deletions(-)
> > 
> > diff --git a/README b/README
> > index 26cab9d..58e55bc 100644
> > --- a/README
> > +++ b/README
> > @@ -15,9 +15,24 @@ with an older kernel.
> >  Compiling
> >  -
> >  
> > -libdrm  is  a  standard  autotools  package and  follows  the  normal
> > -configure, build  and install steps.   The first step is  to configure
> > -the package, which is done by running the configure shell script:
> > +libdrm has two build systems, a legacy autotools build system, and a newer
> > +meson build system. The meson build system is much faster, and offers a 
> > +slightly different interface, but otherwise provides much the same 
> 
> s/much/pretty much/ ?

It is a valid construct, but it's a bit archaic, so how about
`s/much the same/equivalent/`?

> 
> > +feature set.
> > +
> > +To use it:
> > +
> > +meson builddir
> 
> I'd suggest `builddir/` to make it more obvious it's a dir, not
> a command.

Makes sense.

> 
> > +
> > +By default this will install into /usr/local, you can change your prefix
> > +with --prefix=/usr (or -Dprefix=/usr to meson configure).
> 
> "(or `meson configure builddir/ -D prefix=/usr` to change it after the
> initial meson setup)."

Done.

> 
> > +
> > +Then use ninja to build and install:
> > +
> > +ninja -C builddir install
> > +
> > +
> > +Alternatively you can invoke autotools configure:
> >  
> >   ./configure
> >  
> > -- 
> > git-series 0.9.1


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 3/3] README: Add note about meson

[Eric Engestrom]

On Thursday, 2018-01-04 10:28:42 -0800, Dylan Baker wrote:
> Signed-off-by: Dylan Baker 

Couple nitpicks, but:
Reviewed-by: Eric Engestrom 

> ---
>  README | 21 ++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/README b/README
> index 26cab9d..58e55bc 100644
> --- a/README
> +++ b/README
> @@ -15,9 +15,24 @@ with an older kernel.
>  Compiling
>  -
>  
> -libdrm  is  a  standard  autotools  package and  follows  the  normal
> -configure, build  and install steps.   The first step is  to configure
> -the package, which is done by running the configure shell script:
> +libdrm has two build systems, a legacy autotools build system, and a newer
> +meson build system. The meson build system is much faster, and offers a 
> +slightly different interface, but otherwise provides much the same 

s/much/pretty much/ ?

> +feature set.
> +
> +To use it:
> +
> +meson builddir

I'd suggest `builddir/` to make it more obvious it's a dir, not
a command.

> +
> +By default this will install into /usr/local, you can change your prefix
> +with --prefix=/usr (or -Dprefix=/usr to meson configure).

"(or `meson configure builddir/ -D prefix=/usr` to change it after the
initial meson setup)."

> +
> +Then use ninja to build and install:
> +
> +ninja -C builddir install
> +
> +
> +Alternatively you can invoke autotools configure:
>  
>   ./configure
>  
> -- 
> git-series 0.9.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v4 3/3] README: Add note about meson

[Dylan Baker]

Signed-off-by: Dylan Baker 
---
 README | 21 ++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/README b/README
index 26cab9d..58e55bc 100644
--- a/README
+++ b/README
@@ -15,9 +15,24 @@ with an older kernel.
 Compiling
 -
 
-libdrm  is  a  standard  autotools  package and  follows  the  normal
-configure, build  and install steps.   The first step is  to configure
-the package, which is done by running the configure shell script:
+libdrm has two build systems, a legacy autotools build system, and a newer
+meson build system. The meson build system is much faster, and offers a 
+slightly different interface, but otherwise provides much the same 
+feature set.
+
+To use it:
+
+meson builddir
+
+By default this will install into /usr/local, you can change your prefix
+with --prefix=/usr (or -Dprefix=/usr to meson configure).
+
+Then use ninja to build and install:
+
+ninja -C builddir install
+
+
+Alternatively you can invoke autotools configure:
 
./configure
 
-- 
git-series 0.9.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev