Re: [Mesa-dev] [PATCH v4 32/40] intel/compiler: skip MAD algebraic optimization for half-float or mixed mode

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand 

On Tue, Feb 12, 2019 at 5:56 AM Iago Toral Quiroga 
wrote:

> It is very likely that this optimzation is never useful and we'll probably
> just end up removing it, so let's not bother adding more cases to it for
> now.
> ---
>  src/intel/compiler/brw_fs.cpp | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
> index 873a1dd8196..aeabaefd6df 100644
> --- a/src/intel/compiler/brw_fs.cpp
> +++ b/src/intel/compiler/brw_fs.cpp
> @@ -2655,6 +2655,10 @@ fs_visitor::opt_algebraic()
>   }
>   break;
>case BRW_OPCODE_MAD:
> + if (inst->src[0].type != BRW_REGISTER_TYPE_F ||
> + inst->src[1].type != BRW_REGISTER_TYPE_F ||
> + inst->src[2].type != BRW_REGISTER_TYPE_F)
> +break;
>   if (inst->src[1].is_one()) {
>  inst->opcode = BRW_OPCODE_ADD;
>  inst->src[1] = inst->src[2];
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v4 32/40] intel/compiler: skip MAD algebraic optimization for half-float or mixed mode

[Iago Toral Quiroga]

It is very likely that this optimzation is never useful and we'll probably
just end up removing it, so let's not bother adding more cases to it for
now.
---
 src/intel/compiler/brw_fs.cpp | 4 
 1 file changed, 4 insertions(+)

diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index 873a1dd8196..aeabaefd6df 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -2655,6 +2655,10 @@ fs_visitor::opt_algebraic()
  }
  break;
   case BRW_OPCODE_MAD:
+ if (inst->src[0].type != BRW_REGISTER_TYPE_F ||
+ inst->src[1].type != BRW_REGISTER_TYPE_F ||
+ inst->src[2].type != BRW_REGISTER_TYPE_F)
+break;
  if (inst->src[1].is_one()) {
 inst->opcode = BRW_OPCODE_ADD;
 inst->src[1] = inst->src[2];
-- 
2.17.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev