Re: [Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

[Emil Velikov]

On 30 May 2017 at 16:01, gregory hainaut  wrote:
> On Mon, 29 May 2017 17:12:05 +0100
> Emil Velikov  wrote:
>
>> On 29 May 2017 at 15:45, Dieter Nützel  wrote:
>> > Hi Gregory,
>> >
>> > there isn't currently a copy of this on Mesa-Patchwork.
>> > Can you please send one over there?
>> >
>> > And maybe an updated version of:
>> > [PATCH v5 0/3] asynchronous pbo transfer with glthread
>> >
>> > Would be awesome.
>> >
>
> Isn't Mesa-Patchwork a bot that parse the mail from the mailing list ? 
> Reading Mesa doc,
> there is only a note that "patches must be marked superseeded manually"
>
Reworking PW to automatically supersede patches is/was planned.
Unfortunately our resident PW expert and developer has moved to other
things :-\

>> The series is in master now, so it should be a bit easier ;-)
>>
>> Gregory, thanks again for the work. Please keep an eye open for
>> reports. it's highly unlikely but still.
>>
>> -Emil
>
> Thanks you for the review and the push :)
Yw.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

[gregory hainaut]

On Mon, 29 May 2017 17:12:05 +0100
Emil Velikov  wrote:

> On 29 May 2017 at 15:45, Dieter Nützel  wrote:
> > Hi Gregory,
> >
> > there isn't currently a copy of this on Mesa-Patchwork.
> > Can you please send one over there?
> >
> > And maybe an updated version of:
> > [PATCH v5 0/3] asynchronous pbo transfer with glthread
> >
> > Would be awesome.
> >

Isn't Mesa-Patchwork a bot that parse the mail from the mailing list ? Reading 
Mesa doc,
there is only a note that "patches must be marked superseeded manually"
  
> The series is in master now, so it should be a bit easier ;-)
> 
> Gregory, thanks again for the work. Please keep an eye open for
> reports. it's highly unlikely but still.
> 
> -Emil

Thanks you for the review and the push :)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

[Emil Velikov]

On 29 May 2017 at 15:45, Dieter Nützel  wrote:
> Hi Gregory,
>
> there isn't currently a copy of this on Mesa-Patchwork.
> Can you please send one over there?
>
> And maybe an updated version of:
> [PATCH v5 0/3] asynchronous pbo transfer with glthread
>
> Would be awesome.
>
The series is in master now, so it should be a bit easier ;-)

Gregory, thanks again for the work. Please keep an eye open for
reports. it's highly unlikely but still.

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

[Dieter Nützel]

Hi Gregory,

there isn't currently a copy of this on Mesa-Patchwork.
Can you please send one over there?

And maybe an updated version of:
[PATCH v5 0/3] asynchronous pbo transfer with glthread

Would be awesome.

Dieter

Am 29.05.2017 13:18, schrieb Gregory Hainaut:

Hello Mesa developers,

Following the discussion from
https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html

A check was added to ensure that X11 display can be locked. It should 
be enough

to ensure thread safety between X11 and glthread.

I also did the check on DRI3 as I'm not 100% sure that it is really 
thread safe.




v2: based on Nicolai/Matt reviews
Add a check on DRI extension version
Use C comments :)

v3: based on Emil reviews
Split the initial first patch into 3 sub patches dri extension / glx / 
egl

Improve error message
Improve code readability
Just include libX11 on EGL protected by ifdef

v4: based on Eric feedback, I marked DRI3 as always thread safe

v5: Fix the null pointer check on patch 4. I added Daniel comment on
patch 3 but I'm not sure I got it right.

Thanks you for all the review comments.

Best regards,


Gregory Hainaut (4):
  dri: Extend __DRIbackgroundCallableExtensionRec to include a callback
that checks for thread safety
  glx: implement __DRIbackgroundCallableExtension.isThreadSafe
  egl: implement __DRIbackgroundCallableExtension.isThreadSafe
  glthread/gallium: require safe_glthread to start glthread

 include/GL/internal/dri_interface.h  | 13 +++
 src/egl/drivers/dri2/egl_dri2.c  | 34 
+++-

 src/gallium/state_trackers/dri/dri_context.c | 21 +
 src/glx/dri2_glx.c   | 15 +++-
 src/glx/dri3_glx.c   | 12 +-
 5 files changed, 88 insertions(+), 7 deletions(-)

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

[Gregory Hainaut]

Hello Mesa developers,

Following the discussion from
https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html

A check was added to ensure that X11 display can be locked. It should be enough
to ensure thread safety between X11 and glthread.

I also did the check on DRI3 as I'm not 100% sure that it is really thread safe.



v2: based on Nicolai/Matt reviews
Add a check on DRI extension version
Use C comments :)

v3: based on Emil reviews
Split the initial first patch into 3 sub patches dri extension / glx / egl
Improve error message
Improve code readability
Just include libX11 on EGL protected by ifdef

v4: based on Eric feedback, I marked DRI3 as always thread safe

v5: Fix the null pointer check on patch 4. I added Daniel comment on
patch 3 but I'm not sure I got it right.

Thanks you for all the review comments.

Best regards,


Gregory Hainaut (4):
  dri: Extend __DRIbackgroundCallableExtensionRec to include a callback
that checks for thread safety
  glx: implement __DRIbackgroundCallableExtension.isThreadSafe
  egl: implement __DRIbackgroundCallableExtension.isThreadSafe
  glthread/gallium: require safe_glthread to start glthread

 include/GL/internal/dri_interface.h  | 13 +++
 src/egl/drivers/dri2/egl_dri2.c  | 34 +++-
 src/gallium/state_trackers/dri/dri_context.c | 21 +
 src/glx/dri2_glx.c   | 15 +++-
 src/glx/dri3_glx.c   | 12 +-
 5 files changed, 88 insertions(+), 7 deletions(-)

-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev