Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Marek Olšák]

Patches 1, 2, 6:

Reviewed-by: Marek Olšák 

I agree with Grazvydas that the queue jobs should not be exposed to
users of disk_cache.

Marek


On Sun, Mar 12, 2017 at 2:58 AM, Timothy Arceri  wrote:
>
>
> On 12/03/17 11:34, Marek Olšák wrote:
>>
>> On Sun, Mar 12, 2017 at 1:31 AM, Marek Olšák  wrote:
>>>
>>> On Sun, Mar 12, 2017 at 12:30 AM, Timothy Arceri 
>>> wrote:

 On 10/03/17 23:01, Marek Olšák wrote:
>
>
> I'm seeing patches I've already reviewed in the previous extended
> series (e.g. 1/8) and later ones show up multiple times (e.g. there
> are two patches for 5/8), so I don't know what to review. Can you send
> the whole thing again. Thanks.



 I accidentally sent the series while I had checkout a patch in the
 middle of
 the series. This thread (subject ending in real) is the correct one. The
 two
 threads are clearly separate in my email client (thunderbird) maybe
 yours is
 sorting incorrectly? I'm not sure how re-sending will help as they are
 already separate threads.

 Sorry for the inconvenience.
>>>
>>>
>>> No problem. Gmail doesn't show threads, so I'm sometimes lost in it.
>>
>>
>> Is this the correct series?
>> https://patchwork.freedesktop.org/series/21036/
>
>
> Yes, that is the correct series.
>
>>
>> Marek
>>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Timothy Arceri]

On 10/03/17 21:44, Mike Lothian wrote:

This isn't applying cleanly for me, I think I'm missing some patches

I've applied Series 20989, 20872, 20873 (rev1 with patches 6,7 applied
manually - patchwork was being weird) on top of master

Do you have a branch somewhere?


Almost everything but this series is now in master but you can get it 
from the shader-cache-radeonsi5 branch here: 
https://github.com/tarceri/Mesa.git




On Fri, 10 Mar 2017 at 02:29 Timothy Arceri mailto:tarc...@itsqueeze.com>> wrote:

This series was created to attempt to address regressions in compile
times
cause by the shader cache when the cache is cold. However my testing has
shown no noticable change either way in start-up times of Deus Ex on my
Intel i5-6400 CPU.

The reports were for slow compression times on an older AMD cpu so maybe
it will help more there.

It's also possible this will help in-game but I have no stats for that
currently.

While working on this I found the major cause of the regression in
compile
times and fixed it here [1].

For this to apply there are still some patches on the list that need to
be reviewed and land in master [2] [3].

[1]
https://lists.freedesktop.org/archives/mesa-dev/2017-March/147324.html
[2] https://patchwork.freedesktop.org/series/20872/
[3] https://patchwork.freedesktop.org/series/20873/

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org 
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Timothy Arceri]

On 12/03/17 11:34, Marek Olšák wrote:

On Sun, Mar 12, 2017 at 1:31 AM, Marek Olšák  wrote:

On Sun, Mar 12, 2017 at 12:30 AM, Timothy Arceri  wrote:

On 10/03/17 23:01, Marek Olšák wrote:


I'm seeing patches I've already reviewed in the previous extended
series (e.g. 1/8) and later ones show up multiple times (e.g. there
are two patches for 5/8), so I don't know what to review. Can you send
the whole thing again. Thanks.



I accidentally sent the series while I had checkout a patch in the middle of
the series. This thread (subject ending in real) is the correct one. The two
threads are clearly separate in my email client (thunderbird) maybe yours is
sorting incorrectly? I'm not sure how re-sending will help as they are
already separate threads.

Sorry for the inconvenience.


No problem. Gmail doesn't show threads, so I'm sometimes lost in it.


Is this the correct series?
https://patchwork.freedesktop.org/series/21036/


Yes, that is the correct series.



Marek


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Marek Olšák]

On Sun, Mar 12, 2017 at 1:31 AM, Marek Olšák  wrote:
> On Sun, Mar 12, 2017 at 12:30 AM, Timothy Arceri  
> wrote:
>> On 10/03/17 23:01, Marek Olšák wrote:
>>>
>>> I'm seeing patches I've already reviewed in the previous extended
>>> series (e.g. 1/8) and later ones show up multiple times (e.g. there
>>> are two patches for 5/8), so I don't know what to review. Can you send
>>> the whole thing again. Thanks.
>>
>>
>> I accidentally sent the series while I had checkout a patch in the middle of
>> the series. This thread (subject ending in real) is the correct one. The two
>> threads are clearly separate in my email client (thunderbird) maybe yours is
>> sorting incorrectly? I'm not sure how re-sending will help as they are
>> already separate threads.
>>
>> Sorry for the inconvenience.
>
> No problem. Gmail doesn't show threads, so I'm sometimes lost in it.

Is this the correct series?
https://patchwork.freedesktop.org/series/21036/

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Marek Olšák]

On Sun, Mar 12, 2017 at 12:30 AM, Timothy Arceri  wrote:
> On 10/03/17 23:01, Marek Olšák wrote:
>>
>> I'm seeing patches I've already reviewed in the previous extended
>> series (e.g. 1/8) and later ones show up multiple times (e.g. there
>> are two patches for 5/8), so I don't know what to review. Can you send
>> the whole thing again. Thanks.
>
>
> I accidentally sent the series while I had checkout a patch in the middle of
> the series. This thread (subject ending in real) is the correct one. The two
> threads are clearly separate in my email client (thunderbird) maybe yours is
> sorting incorrectly? I'm not sure how re-sending will help as they are
> already separate threads.
>
> Sorry for the inconvenience.

No problem. Gmail doesn't show threads, so I'm sometimes lost in it.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Timothy Arceri]

On 10/03/17 23:01, Marek Olšák wrote:

I'm seeing patches I've already reviewed in the previous extended
series (e.g. 1/8) and later ones show up multiple times (e.g. there
are two patches for 5/8), so I don't know what to review. Can you send
the whole thing again. Thanks.


I accidentally sent the series while I had checkout a patch in the 
middle of the series. This thread (subject ending in real) is the 
correct one. The two threads are clearly separate in my email client 
(thunderbird) maybe yours is sorting incorrectly? I'm not sure how 
re-sending will help as they are already separate threads.


Sorry for the inconvenience.



Marek

On Fri, Mar 10, 2017 at 3:28 AM, Timothy Arceri  wrote:

This series was created to attempt to address regressions in compile times
cause by the shader cache when the cache is cold. However my testing has
shown no noticable change either way in start-up times of Deus Ex on my
Intel i5-6400 CPU.

The reports were for slow compression times on an older AMD cpu so maybe
it will help more there.

It's also possible this will help in-game but I have no stats for that
currently.

While working on this I found the major cause of the regression in compile
times and fixed it here [1].

For this to apply there are still some patches on the list that need to
be reviewed and land in master [2] [3].

[1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/147324.html
[2] https://patchwork.freedesktop.org/series/20872/
[3] https://patchwork.freedesktop.org/series/20873/

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Marek Olšák]

I'm seeing patches I've already reviewed in the previous extended
series (e.g. 1/8) and later ones show up multiple times (e.g. there
are two patches for 5/8), so I don't know what to review. Can you send
the whole thing again. Thanks.

Marek

On Fri, Mar 10, 2017 at 3:28 AM, Timothy Arceri  wrote:
> This series was created to attempt to address regressions in compile times
> cause by the shader cache when the cache is cold. However my testing has
> shown no noticable change either way in start-up times of Deus Ex on my
> Intel i5-6400 CPU.
>
> The reports were for slow compression times on an older AMD cpu so maybe
> it will help more there.
>
> It's also possible this will help in-game but I have no stats for that
> currently.
>
> While working on this I found the major cause of the regression in compile
> times and fixed it here [1].
>
> For this to apply there are still some patches on the list that need to
> be reviewed and land in master [2] [3].
>
> [1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/147324.html
> [2] https://patchwork.freedesktop.org/series/20872/
> [3] https://patchwork.freedesktop.org/series/20873/
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Mike Lothian]

This isn't applying cleanly for me, I think I'm missing some patches

I've applied Series 20989, 20872, 20873 (rev1 with patches 6,7 applied
manually - patchwork was being weird) on top of master

Do you have a branch somewhere?

On Fri, 10 Mar 2017 at 02:29 Timothy Arceri  wrote:

> This series was created to attempt to address regressions in compile times
> cause by the shader cache when the cache is cold. However my testing has
> shown no noticable change either way in start-up times of Deus Ex on my
> Intel i5-6400 CPU.
>
> The reports were for slow compression times on an older AMD cpu so maybe
> it will help more there.
>
> It's also possible this will help in-game but I have no stats for that
> currently.
>
> While working on this I found the major cause of the regression in compile
> times and fixed it here [1].
>
> For this to apply there are still some patches on the list that need to
> be reviewed and land in master [2] [3].
>
> [1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/147324.html
> [2] https://patchwork.freedesktop.org/series/20872/
> [3] https://patchwork.freedesktop.org/series/20873/
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] RFC Thread queue for shader cache compression/writes (real)

[Timothy Arceri]

This series was created to attempt to address regressions in compile times
cause by the shader cache when the cache is cold. However my testing has
shown no noticable change either way in start-up times of Deus Ex on my
Intel i5-6400 CPU.

The reports were for slow compression times on an older AMD cpu so maybe
it will help more there.

It's also possible this will help in-game but I have no stats for that
currently.

While working on this I found the major cause of the regression in compile
times and fixed it here [1].

For this to apply there are still some patches on the list that need to
be reviewed and land in master [2] [3].

[1] https://lists.freedesktop.org/archives/mesa-dev/2017-March/147324.html
[2] https://patchwork.freedesktop.org/series/20872/
[3] https://patchwork.freedesktop.org/series/20873/

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev