Re: [Mesa-dev] i915/swrast vertex array regression
Ville, On Monday, 20 August 2018 15:57:07 CEST Ville Syrjälä wrote: > Seems to. Thanks for tracking it down. > > Tested-by: Ville Syrjälä Thanks for finding out how to reproduce and testing. best Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] i915/swrast vertex array regression
On Fri, Aug 10, 2018 at 01:13:31PM +0200, Mathias Fröhlich wrote:
> Hi Ville,
>
> > Looks like
> > "vid_gl20" "0"
> > is needed to reproduce the issue.
>
> Thanks! Now I can observe the problem!
> And the attached patch seems to fix what I can observe here.
> Does the attached patch also fix the problem with the
> older intel chip you originally reported?
Seems to. Thanks for tracking it down.
Tested-by: Ville Syrjälä
>
> Thanks!
>
> Mathias
> From 68e921478c8c38a13b7258e0d3f1f235709dcfe9 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Mathias=20Fr=C3=B6hlich?=
> Date: Fri, 10 Aug 2018 11:37:43 +0200
> Subject: [PATCH] tnl: Fix green gun regression in xonotic.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Signed-off-by: Mathias Fröhlich
> ---
> src/mesa/tnl/t_split_copy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/tnl/t_split_copy.c b/src/mesa/tnl/t_split_copy.c
> index cbb7eb409f..085ae9a28c 100644
> --- a/src/mesa/tnl/t_split_copy.c
> +++ b/src/mesa/tnl/t_split_copy.c
> @@ -531,7 +531,7 @@ replay_init(struct copy_context *copy)
> for (offset = 0, i = 0; i < copy->nr_varying; i++) {
>const struct tnl_vertex_array *src = copy->varying[i].array;
>const struct gl_array_attributes *srcattr = src->VertexAttrib;
> - struct tnl_vertex_array *dst = >dstarray[i];
> + struct tnl_vertex_array *dst = >dstarray[copy->varying[i].attr];
>struct gl_vertex_buffer_binding *dstbind =
> >varying[i].dstbinding;
>struct gl_array_attributes *dstattr = >varying[i].dstattribs;
>
> --
> 2.17.1
>
--
Ville Syrjälä
Intel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] i915/swrast vertex array regression
Hi Ville,
> Looks like
> "vid_gl20" "0"
> is needed to reproduce the issue.
Thanks! Now I can observe the problem!
And the attached patch seems to fix what I can observe here.
Does the attached patch also fix the problem with the
older intel chip you originally reported?
Thanks!
MathiasFrom 68e921478c8c38a13b7258e0d3f1f235709dcfe9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mathias=20Fr=C3=B6hlich?=
Date: Fri, 10 Aug 2018 11:37:43 +0200
Subject: [PATCH] tnl: Fix green gun regression in xonotic.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Mathias Fröhlich
---
src/mesa/tnl/t_split_copy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/tnl/t_split_copy.c b/src/mesa/tnl/t_split_copy.c
index cbb7eb409f..085ae9a28c 100644
--- a/src/mesa/tnl/t_split_copy.c
+++ b/src/mesa/tnl/t_split_copy.c
@@ -531,7 +531,7 @@ replay_init(struct copy_context *copy)
for (offset = 0, i = 0; i < copy->nr_varying; i++) {
const struct tnl_vertex_array *src = copy->varying[i].array;
const struct gl_array_attributes *srcattr = src->VertexAttrib;
- struct tnl_vertex_array *dst = >dstarray[i];
+ struct tnl_vertex_array *dst = >dstarray[copy->varying[i].attr];
struct gl_vertex_buffer_binding *dstbind = >varying[i].dstbinding;
struct gl_array_attributes *dstattr = >varying[i].dstattribs;
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] i915/swrast vertex array regression
On Tue, Jul 31, 2018 at 08:29:18AM +0200, Mathias Fröhlich wrote:
> Hi Ville,
>
> > I noticed a while back that xonotic had started to misrender the gun
> > models on i915. Yesterday I bisected it down to commit 64d2a2048054
> > ("mesa: Make gl_vertex_array contain pointers to first order VAO
> > members."). Actually that commit broke things even worse (and the
> > game would even crash after a while), but a later commit (presumably
> > 98f35ad63c23 ("vbo: Correctly handle source arrays in vbo_split_copy.")
> > fixed things a little bit. But even with current master the guns are
> > still being misrendered. I also verified that the same breakage was
> > visible with swrast, whereas llvmpipe and i965 seemed ok.
> >
> > To reproduce you can run 'xonotic-glx -benchmark
> > demos/the-big-keybench.dem'
> > and wait until the guy picks up the mortar (I think that's what its
> > called) which is maybe the third gun he picks up in that demo. The gun
> > is supposed to have some red color on it but now it has green.
>
> I tried to reproduce that problem using classic swrast.
> Some variants of last weeks git master show the exact same
> pictures than swrast using the last good commit from your bisect.
> So, basically I can't reproduce the problem here.
Looks like
"vid_gl20" "0"
is needed to reproduce the issue.
--
Ville Syrjälä
syrj...@sci.fi
http://www.sci.fi/~syrjala/
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] i915/swrast vertex array regression
Hi Ville,
> I noticed a while back that xonotic had started to misrender the gun
> models on i915. Yesterday I bisected it down to commit 64d2a2048054
> ("mesa: Make gl_vertex_array contain pointers to first order VAO
> members."). Actually that commit broke things even worse (and the
> game would even crash after a while), but a later commit (presumably
> 98f35ad63c23 ("vbo: Correctly handle source arrays in vbo_split_copy.")
> fixed things a little bit. But even with current master the guns are
> still being misrendered. I also verified that the same breakage was
> visible with swrast, whereas llvmpipe and i965 seemed ok.
>
> To reproduce you can run 'xonotic-glx -benchmark demos/the-big-keybench.dem'
> and wait until the guy picks up the mortar (I think that's what its
> called) which is maybe the third gun he picks up in that demo. The gun
> is supposed to have some red color on it but now it has green.
I tried to reproduce that problem using classic swrast.
Some variants of last weeks git master show the exact same
pictures than swrast using the last good commit from your bisect.
So, basically I can't reproduce the problem here.
The xonotic version I used is 0.8,2 which is the one delivered
with fedora 28.
Can you provide some more detail?
Lets start with your version of xonotic you use.
best and thanks
Mathias
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] i915/swrast vertex array regression
Hi Ville,
> I noticed a while back that xonotic had started to misrender the gun
> models on i915. Yesterday I bisected it down to commit 64d2a2048054
> ("mesa: Make gl_vertex_array contain pointers to first order VAO
> members."). Actually that commit broke things even worse (and the
> game would even crash after a while), but a later commit (presumably
> 98f35ad63c23 ("vbo: Correctly handle source arrays in vbo_split_copy.")
> fixed things a little bit. But even with current master the guns are
> still being misrendered. I also verified that the same breakage was
> visible with swrast, whereas llvmpipe and i965 seemed ok.
>
> To reproduce you can run 'xonotic-glx -benchmark demos/the-big-keybench.dem'
> and wait until the guy picks up the mortar (I think that's what its
> called) which is maybe the third gun he picks up in that demo. The gun
> is supposed to have some red color on it but now it has green.
>
> It looked like there's already a bunch of stuff piled on top of the
> regression so reverting didn't seem entirely trivial, and thus I didn't
> bother trying.
I'll take a look!
And no - reverting depends on too much.
Mathias
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] i915/swrast vertex array regression
Hi Mathias,
I noticed a while back that xonotic had started to misrender the gun
models on i915. Yesterday I bisected it down to commit 64d2a2048054
("mesa: Make gl_vertex_array contain pointers to first order VAO
members."). Actually that commit broke things even worse (and the
game would even crash after a while), but a later commit (presumably
98f35ad63c23 ("vbo: Correctly handle source arrays in vbo_split_copy.")
fixed things a little bit. But even with current master the guns are
still being misrendered. I also verified that the same breakage was
visible with swrast, whereas llvmpipe and i965 seemed ok.
To reproduce you can run 'xonotic-glx -benchmark demos/the-big-keybench.dem'
and wait until the guy picks up the mortar (I think that's what its
called) which is maybe the third gun he picks up in that demo. The gun
is supposed to have some red color on it but now it has green.
It looked like there's already a bunch of stuff piled on top of the
regression so reverting didn't seem entirely trivial, and thus I didn't
bother trying.
--
Ville Syrjälä
Intel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
