Re: [Mesa-dev] meta/blit: Write gl_FragDepth only when really needed
On Thursday, January 29, 2015 04:20:59 PM Topi Pohjolainen wrote: > Currently meta blit programs unconditionally write both color and > depth values. This series introduces two flavours - with and without > gl_FragDepth - allowing simpler programs for color only blits. Ken > had observed that i965 behaves badly emitting five unnecessary moves > when the depth is included in the shader. > While this didn't improve any performance benches I tried, it doesn't > seem to introduce any regressions either in the benches or with > piglit. > > Topi Pohjolainen (5): > meta/blit: Add plumbing for shaders without depth > meta/blit: Write depth only when asked for > meta/blit: Compile programs with and without depth > meta: Don't write depth when generating miptrees > meta: Don't write depth when decompressing tex-images Series is: Reviewed-by: Kenneth Graunke This should also help with future Cherryview optimizations. Thanks! signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] meta/blit: Write gl_FragDepth only when really needed
I haven't worked in meta a lot, but I didn't see anything that didn't look correct. The series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] meta/blit: Write gl_FragDepth only when really needed
Currently meta blit programs unconditionally write both color and depth values. This series introduces two flavours - with and without gl_FragDepth - allowing simpler programs for color only blits. Ken had observed that i965 behaves badly emitting five unnecessary moves when the depth is included in the shader. While this didn't improve any performance benches I tried, it doesn't seem to introduce any regressions either in the benches or with piglit. Topi Pohjolainen (5): meta/blit: Add plumbing for shaders without depth meta/blit: Write depth only when asked for meta/blit: Compile programs with and without depth meta: Don't write depth when generating miptrees meta: Don't write depth when decompressing tex-images src/mesa/drivers/common/meta.c | 10 ++ src/mesa/drivers/common/meta.h | 4 +++- src/mesa/drivers/common/meta_blit.c| 13 + src/mesa/drivers/common/meta_generate_mipmap.c | 2 +- 4 files changed, 19 insertions(+), 10 deletions(-) -- 1.9.3 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev