Re: [Mesa-dev] remove mfeatures.h, take two
Ready to commit? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On 04/08/2013 11:26 AM, Matt Turner wrote: Ready to commit? Thanks for the reminder. I think it's ready but IIRC only one person besides myself really tested it. I think I could cherry-pick the commits a few at a time to master... -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On 03/11/2013 10:02 PM, Jordan Justen wrote: On Mon, Mar 11, 2013 at 5:28 PM, Brian Paulbri...@vmware.com wrote: On Sat, Mar 2, 2013 at 7:29 AM, Brian Paulbri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. I tested this with i965. It built and did not have regressions with piglit quick-driver.tests. How much changed from v1? I gave a reviewed-by for the v1 series, so I wonder if you would be willing to add my r-b to commit message for the patches that are unchanged from v1? If a lot changed, do you think v2 should be posted to the list for further code review? The branch is pretty much the same, except: 1. A few commits were merged together to avoid build breaks. 2. A few commits at the end of the original series which touched the -DFEATURE_x stuff in configure.ac were dropped. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On Mon, Mar 11, 2013 at 5:28 PM, Brian Paul bri...@vmware.com wrote: On Sat, Mar 2, 2013 at 7:29 AM, Brian Paul bri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. I think I see an issue. In src/mesa/drivers/dri/intel/intel_screen.c, we use: #ifndef FEATURE_ES1 and #ifndef FEATURE_ES2 I think these chunks of code should be removed in your series, right? -Jordan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On 03/12/2013 02:52 PM, Jordan Justen wrote: On Mon, Mar 11, 2013 at 5:28 PM, Brian Paulbri...@vmware.com wrote: On Sat, Mar 2, 2013 at 7:29 AM, Brian Paulbri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. I think I see an issue. In src/mesa/drivers/dri/intel/intel_screen.c, we use: #ifndef FEATURE_ES1 and #ifndef FEATURE_ES2 I think these chunks of code should be removed in your series, right? I wasn't 100% sure about that. For the time being, leaving it as-is shouldn't do any harm. The autoconf/makefiles will still set -DFEATURE_ES1/ES2/GL as before so there shouldn't be any change in behaviour if we leave it as-is for now. If you think those lines should be removed, it could be done later, right? -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On Tue, Mar 12, 2013 at 2:12 PM, Brian Paul bri...@vmware.com wrote: On 03/12/2013 02:52 PM, Jordan Justen wrote: On Mon, Mar 11, 2013 at 5:28 PM, Brian Paulbri...@vmware.com wrote: On Sat, Mar 2, 2013 at 7:29 AM, Brian Paulbri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. I think I see an issue. In src/mesa/drivers/dri/intel/intel_screen.c, we use: #ifndef FEATURE_ES1 and #ifndef FEATURE_ES2 I think these chunks of code should be removed in your series, right? I wasn't 100% sure about that. For the time being, leaving it as-is shouldn't do any harm. The autoconf/makefiles will still set -DFEATURE_ES1/ES2/GL as before so there shouldn't be any change in behaviour if we leave it as-is for now. If you think those lines should be removed, it could be done later, right? Ok. I'll extend my r-b for v2 then. I thought I saw some piglit regressions related to this, but they probably were fixed by rebasing your -2 branch to master rather than those chunks of code. -Jordan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On 03/12/2013 04:12 PM, Jordan Justen wrote: On Tue, Mar 12, 2013 at 2:12 PM, Brian Paulbri...@vmware.com wrote: On 03/12/2013 02:52 PM, Jordan Justen wrote: On Mon, Mar 11, 2013 at 5:28 PM, Brian Paulbri...@vmware.com wrote: On Sat, Mar 2, 2013 at 7:29 AM, Brian Paulbri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. I think I see an issue. In src/mesa/drivers/dri/intel/intel_screen.c, we use: #ifndef FEATURE_ES1 and #ifndef FEATURE_ES2 I think these chunks of code should be removed in your series, right? I wasn't 100% sure about that. For the time being, leaving it as-is shouldn't do any harm. The autoconf/makefiles will still set -DFEATURE_ES1/ES2/GL as before so there shouldn't be any change in behaviour if we leave it as-is for now. If you think those lines should be removed, it could be done later, right? Ok. I'll extend my r-b for v2 then. I thought I saw some piglit regressions related to this, but they probably were fixed by rebasing your -2 branch to master rather than those chunks of code. OK, thanks for testing! -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On Sat, Mar 2, 2013 at 7:29 AM, Brian Paul bri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] remove mfeatures.h, take two
On Mon, Mar 11, 2013 at 5:28 PM, Brian Paul bri...@vmware.com wrote: On Sat, Mar 2, 2013 at 7:29 AM, Brian Paul bri...@vmware.com wrote: I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. Ping. Can anyone test the updated remove-mfeatures-2 branch? Thanks. I tested this with i965. It built and did not have regressions with piglit quick-driver.tests. How much changed from v1? I gave a reviewed-by for the v1 series, so I wonder if you would be willing to add my r-b to commit message for the patches that are unchanged from v1? If a lot changed, do you think v2 should be posted to the list for further code review? Thanks, -Jordan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] remove mfeatures.h, take two
I've respun my remove-mfeatures branch as remove-mfeatures-2. It's in my repo on freedesktop.org This removes the mfeatures.h file and the last of the #ifdef FEATURE_x code from core Mesa. Note, however, that the scons/makefiles still define FEATURE_GL, FEATURE_ES1, FEATURE_ES2, etc. because that controls whether some source files are built and in some places (like egl-static/egl_st.c) we need to test those symbols to avoid calling non-existant functions. If a few people can test, that'd be great. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
