Re: [Mesa-dev] [PATCH] Mark debug_print with __attribute__ ((format(__printf__, 1, 0)))

2014-01-13 Thread Thierry Reding 
On Sun, Jan 12, 2014 at 10:34:19AM -0800, Keith Packard wrote:
 the drmServerInfo member, debug_print, takes a printf format string
 and varargs list. Tell the compiler about it.
 
 Signed-off-by: Keith Packard kei...@keithp.com
 ---
  xf86drm.h | 8 +++-
  1 file changed, 7 insertions(+), 1 deletion(-)
 
 diff --git a/xf86drm.h b/xf86drm.h
 index 1e763a3..5e170f8 100644
 --- a/xf86drm.h
 +++ b/xf86drm.h
 @@ -92,8 +92,14 @@ extern C {
  typedef unsigned int  drmSize, *drmSizePtr;  /** For mapped 
 regions */
  typedef void  *drmAddress, **drmAddressPtr; /** For mapped regions 
 */
  
 +#if (__GNUC__ = 3)
 +#define DRM_PRINTFLIKE(f, a) __attribute__ ((format(__printf__, f, a)))
 +#else
 +#define DRM_PRINTFLIKE(f, a)
 +#endif
 +
  typedef struct _drmServerInfo {
 -  int (*debug_print)(const char *format, va_list ap);
 +  int (*debug_print)(const char *format, va_list ap) DRM_PRINTFLIKE(1,0);
int (*load_module)(const char *name);
void (*get_perms)(gid_t *, mode_t *);
  } drmServerInfo, *drmServerInfoPtr;

While at it, perhaps the drmMsg() and drmDebugPrint() functions should
be similarily annotated as well?

Thierry


pgpizPDWnAMD5.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Mark debug_print with __attribute__ ((format(__printf__, 1, 0)))

2014-01-13 Thread Keith Packard 
Thierry Reding thierry.red...@gmail.com writes:

 While at it, perhaps the drmMsg() and drmDebugPrint() functions should
 be similarily annotated as well?

I don't know; I'm just fixing X server warnings this week and this was
the source of one of them. Additional warning fixes for drm would be
a great idea!

-- 
keith.pack...@intel.com


pgp2Mp9hDDHGU.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Mark debug_print with __attribute__ ((format(__printf__, 1, 0)))

2014-01-13 Thread Ian Romanick 
Reviewed-by: Ian Romanick ian.d.roman...@intel.com

On 01/12/2014 10:34 AM, Keith Packard wrote:
 the drmServerInfo member, debug_print, takes a printf format string
 and varargs list. Tell the compiler about it.
 
 Signed-off-by: Keith Packard kei...@keithp.com
 ---
  xf86drm.h | 8 +++-
  1 file changed, 7 insertions(+), 1 deletion(-)
 
 diff --git a/xf86drm.h b/xf86drm.h
 index 1e763a3..5e170f8 100644
 --- a/xf86drm.h
 +++ b/xf86drm.h
 @@ -92,8 +92,14 @@ extern C {
  typedef unsigned int  drmSize, *drmSizePtr;  /** For mapped 
 regions */
  typedef void  *drmAddress, **drmAddressPtr; /** For mapped regions 
 */
  
 +#if (__GNUC__ = 3)
 +#define DRM_PRINTFLIKE(f, a) __attribute__ ((format(__printf__, f, a)))
 +#else
 +#define DRM_PRINTFLIKE(f, a)
 +#endif
 +
  typedef struct _drmServerInfo {
 -  int (*debug_print)(const char *format, va_list ap);
 +  int (*debug_print)(const char *format, va_list ap) DRM_PRINTFLIKE(1,0);
int (*load_module)(const char *name);
void (*get_perms)(gid_t *, mode_t *);
  } drmServerInfo, *drmServerInfoPtr;
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Mark debug_print with __attribute__ ((format(__printf__, 1, 0)))

2014-01-13 Thread Keith Packard 
Ian Romanick i...@freedesktop.org writes:

 Reviewed-by: Ian Romanick ian.d.roman...@intel.com

Thanks. Pushed.
   8279c8f..cb4bc8e  master - master

-- 
keith.pack...@intel.com


pgpkKf6zSEV5v.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev