Re: [Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-05 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand 

On Sat, May 5, 2018 at 11:39 AM, Chris Wilson 
wrote:

> A couple of typos found by inspecting field.end - field.start, revealed
> a few wide integers declared as bool and some that ended before they
> started.
>
> Cc: Lionel Landwerlin  ---
>  src/intel/genxml/gen4.xml  | 12 ++--
>  src/intel/genxml/gen45.xml | 12 ++--
>  src/intel/genxml/gen5.xml  | 12 ++--
>  src/intel/genxml/gen6.xml  |  6 +++---
>  src/intel/genxml/gen7.xml  |  6 +++---
>  src/intel/genxml/gen75.xml |  8 
>  6 files changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/src/intel/genxml/gen4.xml b/src/intel/genxml/gen4.xml
> index 6f513c5833b..cd50a1012bc 100644
> --- a/src/intel/genxml/gen4.xml
> +++ b/src/intel/genxml/gen4.xml
> @@ -961,12 +961,12 @@
>   type="bool"/>
>   type="bool"/>
>   type="bool"/>
> -
> -
> -
> -
> -
> -
> +
> +
> +
> +
> +
> +
>
>
>
> diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml
> index fbd57a00c50..4d2c1534d3f 100644
> --- a/src/intel/genxml/gen45.xml
> +++ b/src/intel/genxml/gen45.xml
> @@ -994,12 +994,12 @@
>   type="bool"/>
>   type="bool"/>
>   type="bool"/>
> -
> -
> -
> -
> -
> -
> +
> +
> +
> +
> +
> +
>
>
>
> diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
> index 5c93ecdda30..5bb5a2c3312 100644
> --- a/src/intel/genxml/gen5.xml
> +++ b/src/intel/genxml/gen5.xml
> @@ -1086,12 +1086,12 @@ i
>   type="bool"/>
>   type="bool"/>
>   type="bool"/>
> -
> -
> -
> -
> -
> -
> +
> +
> +
> +
> +
> +
>
>
>
> diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
> index 0493221bd72..f258065ebae 100644
> --- a/src/intel/genxml/gen6.xml
> +++ b/src/intel/genxml/gen6.xml
> @@ -1888,7 +1888,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -1904,7 +1904,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -1920,7 +1920,7 @@
>
>  
>  
> -
> +
>
>
>  
> diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
> index baf42a7d32d..895f5d232b5 100644
> --- a/src/intel/genxml/gen7.xml
> +++ b/src/intel/genxml/gen7.xml
> @@ -2537,7 +2537,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -2553,7 +2553,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -2569,7 +2569,7 @@
>
>  
>  
> -
> +
>
>
>  
> diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
> index 7b635b22dac..fe59446d83f 100644
> --- a/src/intel/genxml/gen75.xml
> +++ b/src/intel/genxml/gen75.xml
> @@ -3021,7 +3021,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -3037,7 +3037,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -3053,7 +3053,7 @@
>
>  
>  
> -
> +
>
>
>  
> @@ -3069,7 +3069,7 @@
>
>  
>  
> -
> +
>
>
>  
> --
> 2.17.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-06 Thread Lionel Landwerlin

Reviewed-by: Lionel Landwerlin 

On 05/05/18 19:39, Chris Wilson wrote:

A couple of typos found by inspecting field.end - field.start, revealed
a few wide integers declared as bool and some that ended before they
started.

Cc: Lionel Landwerlin 
  
  
-
-
-
-
-
-
+
+
+
+
+
+

  


diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml
index fbd57a00c50..4d2c1534d3f 100644
--- a/src/intel/genxml/gen45.xml
+++ b/src/intel/genxml/gen45.xml
@@ -994,12 +994,12 @@
  
  
  
-
-
-
-
-
-
+
+
+
+
+
+

  


diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
index 5c93ecdda30..5bb5a2c3312 100644
--- a/src/intel/genxml/gen5.xml
+++ b/src/intel/genxml/gen5.xml
@@ -1086,12 +1086,12 @@ i
  
  
  
-
-
-
-
-
-
+
+
+
+
+
+

  


diff --git a/src/intel/genxml/gen6.xml b/src/intel/genxml/gen6.xml
index 0493221bd72..f258065ebae 100644
--- a/src/intel/genxml/gen6.xml
+++ b/src/intel/genxml/gen6.xml
@@ -1888,7 +1888,7 @@

  
  
-
+


  
@@ -1904,7 +1904,7 @@

  
  
-
+


  
@@ -1920,7 +1920,7 @@

  
  
-
+


  
diff --git a/src/intel/genxml/gen7.xml b/src/intel/genxml/gen7.xml
index baf42a7d32d..895f5d232b5 100644
--- a/src/intel/genxml/gen7.xml
+++ b/src/intel/genxml/gen7.xml
@@ -2537,7 +2537,7 @@

  
  
-
+


  
@@ -2553,7 +2553,7 @@

  
  
-
+


  
@@ -2569,7 +2569,7 @@

  
  
-
+


  
diff --git a/src/intel/genxml/gen75.xml b/src/intel/genxml/gen75.xml
index 7b635b22dac..fe59446d83f 100644
--- a/src/intel/genxml/gen75.xml
+++ b/src/intel/genxml/gen75.xml
@@ -3021,7 +3021,7 @@

  
  
-
+


  
@@ -3037,7 +3037,7 @@

  
  
-
+


  
@@ -3053,7 +3053,7 @@

  
  
-
+


  
@@ -3069,7 +3069,7 @@

  
  
-
+


  



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] intel/genxml: Fix a few invalid field widths

2018-05-07 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-05-06 15:12:12)
> Reviewed-by: Lionel Landwerlin 

Thank you for the reviews, pushed.
-Chris
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev