Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On 06/01/2012 08:23 AM, Adam Jackson wrote: > On 6/1/12 3:33 AM, Oliver McFadden wrote: > >> Furthermore it actually doesn't render correctly with my encodings >> (en_GB and en_US: UTF-8 and ISO-8859-1, and various Finnish and Swedish >> ones left out for brevity. >> >> Okay, problem on my end, but I'm probably not the only one (or maybe I >> am just an idiot who can't setup encodings correctly.) >> >> Wouldn't "Intel(R) Open Source ..." be sufficient? > > Wouldn't "Intel Open Source ..." be sufficient? > > - ajax That sounds reasonable to me. Pushed (as "Intel Open Source Technology Center"). Bike-shedding concluded. :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On 6/1/12 2:06 PM, Oliver McFadden wrote: On Fri, Jun 01, 2012 at 11:23:17AM -0400, Adam Jackson wrote: On 6/1/12 3:33 AM, Oliver McFadden wrote: Wouldn't "Intel(R) Open Source ..." be sufficient? Wouldn't "Intel Open Source ..." be sufficient? I am not a lawyer, period. Certainly not an Intel lawyer, therefore "no comment." That being said, from a technical standpoint, using (R) as standard ASCII instead of the UTF-8 character might be a good compromise considering we cannot guarantee correct display of the UTF-8 character everywhere. If it's a thing that needs compromise, sure, I suppose. But I'd be fascinated to know why your lawyers think they need a marca registrada in a place that (afaik) no other vendor thinks they do. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On Fri, Jun 01, 2012 at 11:23:17AM -0400, Adam Jackson wrote: > On 6/1/12 3:33 AM, Oliver McFadden wrote: > > > Furthermore it actually doesn't render correctly with my encodings > > (en_GB and en_US: UTF-8 and ISO-8859-1, and various Finnish and Swedish > > ones left out for brevity. > > > > Okay, problem on my end, but I'm probably not the only one (or maybe I > > am just an idiot who can't setup encodings correctly.) > > > > Wouldn't "Intel(R) Open Source ..." be sufficient? > > Wouldn't "Intel Open Source ..." be sufficient? I am not a lawyer, period. Certainly not an Intel lawyer, therefore "no comment." That being said, from a technical standpoint, using (R) as standard ASCII instead of the UTF-8 character might be a good compromise considering we cannot guarantee correct display of the UTF-8 character everywhere. -- Oliver McFadden. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On 6/1/12 3:33 AM, Oliver McFadden wrote: Furthermore it actually doesn't render correctly with my encodings (en_GB and en_US: UTF-8 and ISO-8859-1, and various Finnish and Swedish ones left out for brevity. Okay, problem on my end, but I'm probably not the only one (or maybe I am just an idiot who can't setup encodings correctly.) Wouldn't "Intel(R) Open Source ..." be sufficient? Wouldn't "Intel Open Source ..." be sufficient? - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On 06/01/2012 09:34 AM, Pekka Paalanen wrote:
> On Fri, 1 Jun 2012 09:18:44 +0300
> Pekka Paalanen wrote:
>
>> On Thu, 31 May 2012 16:19:17 -0700
>> Kenneth Graunke wrote:
>>
>>> Tungsten Graphics has not existed for several years, and the majority of
>>> ongoing development and support is done by Intel. I chose to include
>>> "Open Source Technology Center" to distinguish it from, say, the closed
>>> source Windows OpenGL driver.
>>>
>>> The one downside to this patch is that applications that pattern match
>>> against "Intel" may start applying workarounds meant for the Windows
>>> driver. However, it does seem like the right thing to do.
>>>
>>> This does change oglconform behavior.
>>>
>>> Acked-by: Eric Anholt
>>> Acked-by: Ian Romanick
>>> Cc: Eugeni Dodonov
>>> Signed-off-by: Kenneth Graunke
>>> ---
>>> src/mesa/drivers/dri/intel/intel_context.c |2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/mesa/drivers/dri/intel/intel_context.c
>>> b/src/mesa/drivers/dri/intel/intel_context.c
>>> index 9deb4ca..712acb8 100644
>>> --- a/src/mesa/drivers/dri/intel/intel_context.c
>>> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>>> @@ -72,7 +72,7 @@ intelGetString(struct gl_context * ctx, GLenum name)
>>>
>>> switch (name) {
>>> case GL_VENDOR:
>>> - return (GLubyte *) "Tungsten Graphics, Inc";
>>> + return (GLubyte *) "Intel® Open Source Technology Center";
>>
>> Hi,
>>
>> that is an utf-8 character there, right?
>> Is that really appropriate, given the API and all?
>>
>> I don't know about character encoding stuff, but that looks surprising.
>> Just wondering...
>
> Oops, sorry, I missed the other replies. Let me rephrase:
> is it ok by the GL spec to return non-ASCII strings here?
OpenGL 3.0 spec says:
"String queries return pointers to UTF-8 encoded, NULL-terminated static
strings describing properties of the current GL context."
Current GL ES specs do not define anything about the encoding.
>
> Thanks,
> pq
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
--
// Tapani
signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On Fri, Jun 01, 2012 at 09:18:44AM +0300, Pekka Paalanen wrote:
> On Thu, 31 May 2012 16:19:17 -0700
> Kenneth Graunke wrote:
>
> > Tungsten Graphics has not existed for several years, and the majority of
> > ongoing development and support is done by Intel. I chose to include
> > "Open Source Technology Center" to distinguish it from, say, the closed
> > source Windows OpenGL driver.
> >
> > The one downside to this patch is that applications that pattern match
> > against "Intel" may start applying workarounds meant for the Windows
> > driver. However, it does seem like the right thing to do.
> >
> > This does change oglconform behavior.
> >
> > Acked-by: Eric Anholt
> > Acked-by: Ian Romanick
> > Cc: Eugeni Dodonov
> > Signed-off-by: Kenneth Graunke
> > ---
> > src/mesa/drivers/dri/intel/intel_context.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/drivers/dri/intel/intel_context.c
> > b/src/mesa/drivers/dri/intel/intel_context.c
> > index 9deb4ca..712acb8 100644
> > --- a/src/mesa/drivers/dri/intel/intel_context.c
> > +++ b/src/mesa/drivers/dri/intel/intel_context.c
> > @@ -72,7 +72,7 @@ intelGetString(struct gl_context * ctx, GLenum name)
> >
> > switch (name) {
> > case GL_VENDOR:
> > - return (GLubyte *) "Tungsten Graphics, Inc";
> > + return (GLubyte *) "Intel® Open Source Technology Center";
>
> Hi,
>
> that is an utf-8 character there, right?
> Is that really appropriate, given the API and all?
>
> I don't know about character encoding stuff, but that looks surprising.
> Just wondering...
Furthermore it actually doesn't render correctly with my encodings
(en_GB and en_US: UTF-8 and ISO-8859-1, and various Finnish and Swedish
ones left out for brevity.
Okay, problem on my end, but I'm probably not the only one (or maybe I
am just an idiot who can't setup encodings correctly.)
Wouldn't "Intel(R) Open Source ..." be sufficient?
>
>
> Thanks,
> pq
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
--
Oliver McFadden.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On Fri, 1 Jun 2012 09:18:44 +0300
Pekka Paalanen wrote:
> On Thu, 31 May 2012 16:19:17 -0700
> Kenneth Graunke wrote:
>
> > Tungsten Graphics has not existed for several years, and the majority of
> > ongoing development and support is done by Intel. I chose to include
> > "Open Source Technology Center" to distinguish it from, say, the closed
> > source Windows OpenGL driver.
> >
> > The one downside to this patch is that applications that pattern match
> > against "Intel" may start applying workarounds meant for the Windows
> > driver. However, it does seem like the right thing to do.
> >
> > This does change oglconform behavior.
> >
> > Acked-by: Eric Anholt
> > Acked-by: Ian Romanick
> > Cc: Eugeni Dodonov
> > Signed-off-by: Kenneth Graunke
> > ---
> > src/mesa/drivers/dri/intel/intel_context.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/drivers/dri/intel/intel_context.c
> > b/src/mesa/drivers/dri/intel/intel_context.c
> > index 9deb4ca..712acb8 100644
> > --- a/src/mesa/drivers/dri/intel/intel_context.c
> > +++ b/src/mesa/drivers/dri/intel/intel_context.c
> > @@ -72,7 +72,7 @@ intelGetString(struct gl_context * ctx, GLenum name)
> >
> > switch (name) {
> > case GL_VENDOR:
> > - return (GLubyte *) "Tungsten Graphics, Inc";
> > + return (GLubyte *) "Intel® Open Source Technology Center";
>
> Hi,
>
> that is an utf-8 character there, right?
> Is that really appropriate, given the API and all?
>
> I don't know about character encoding stuff, but that looks surprising.
> Just wondering...
Oops, sorry, I missed the other replies. Let me rephrase:
is it ok by the GL spec to return non-ASCII strings here?
Thanks,
pq
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".
On Thu, 31 May 2012 16:19:17 -0700
Kenneth Graunke wrote:
> Tungsten Graphics has not existed for several years, and the majority of
> ongoing development and support is done by Intel. I chose to include
> "Open Source Technology Center" to distinguish it from, say, the closed
> source Windows OpenGL driver.
>
> The one downside to this patch is that applications that pattern match
> against "Intel" may start applying workarounds meant for the Windows
> driver. However, it does seem like the right thing to do.
>
> This does change oglconform behavior.
>
> Acked-by: Eric Anholt
> Acked-by: Ian Romanick
> Cc: Eugeni Dodonov
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/dri/intel/intel_context.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/intel/intel_context.c
> b/src/mesa/drivers/dri/intel/intel_context.c
> index 9deb4ca..712acb8 100644
> --- a/src/mesa/drivers/dri/intel/intel_context.c
> +++ b/src/mesa/drivers/dri/intel/intel_context.c
> @@ -72,7 +72,7 @@ intelGetString(struct gl_context * ctx, GLenum name)
>
> switch (name) {
> case GL_VENDOR:
> - return (GLubyte *) "Tungsten Graphics, Inc";
> + return (GLubyte *) "Intel® Open Source Technology Center";
Hi,
that is an utf-8 character there, right?
Is that really appropriate, given the API and all?
I don't know about character encoding stuff, but that looks surprising.
Just wondering...
Thanks,
pq
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
