Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium
On Tue, Oct 31, 2017 at 11:33 AM, Erik Faye-Lund wrote: > On Tue, Oct 31, 2017 at 10:31 AM, Eric Engestrom > wrote: >> On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: >>> The u_format_other.c users sqrtf, which on some systems require >>> a math-library. So let's make sure we link with it. >>> >>> Signed-off-by: Erik Faye-Lund >> >> Reviewed-by: Eric Engestrom >> >> Do you have push rights? > > Yes, I do :) Btw, I already pushed this. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium
On Tue, Oct 31, 2017 at 10:31 AM, Eric Engestrom wrote: > On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: >> The u_format_other.c users sqrtf, which on some systems require >> a math-library. So let's make sure we link with it. >> >> Signed-off-by: Erik Faye-Lund > > Reviewed-by: Eric Engestrom > > Do you have push rights? Yes, I do :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium
On Monday, 2017-10-30 21:06:25 +0100, Erik Faye-Lund wrote: > The u_format_other.c users sqrtf, which on some systems require > a math-library. So let's make sure we link with it. > > Signed-off-by: Erik Faye-Lund Reviewed-by: Eric Engestrom Do you have push rights? > --- > > I noticed this while debugging something else, thought I'd just send it > upstream directly. > > src/gallium/auxiliary/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/meson.build > b/src/gallium/auxiliary/meson.build > index bb7c0506d8..eed7064792 100644 > --- a/src/gallium/auxiliary/meson.build > +++ b/src/gallium/auxiliary/meson.build > @@ -496,7 +496,7 @@ libgallium = static_library( >], >c_args : [c_vis_args, c_msvc_compat_args], >cpp_args : [cpp_vis_args, cpp_msvc_compat_args], > - dependencies : [dep_libdrm, dep_llvm, dep_unwind, dep_dl], > + dependencies : [dep_libdrm, dep_llvm, dep_unwind, dep_dl, dep_m], >build_by_default : false, > ) > > -- > 2.11.0 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: use dep_m in libgallium
Erik Faye-Lund writes: > The u_format_other.c users sqrtf, which on some systems require > a math-library. So let's make sure we link with it. > > Signed-off-by: Erik Faye-Lund Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
