Re: [Mesa-dev] [PATCH] meta: Fix saving the results of the current occlusion query

2015-02-12 Thread Ian Romanick 
On 02/12/2015 01:39 PM, Carl Worth wrote:
> On Tue, Nov 25 2014, Neil Roberts wrote:
>> This patch fixes it by making it actually wait for the query object to be
>> ready before grabbing the previous result. The downside of doing this is that
>> it could introduce a stall but I think this situation is unlikely so it might
>> not matter too much.
> 
> Thanks for the fix, Neil. The analysis and patch look sound to me, and
> thanks for contributing a piglit test as well. Additionally, we ran the
> patch through some benchmarks and didn't notice any negative performance
> impact.
> 
> Reviewed-by: Carl Worth 

And please add

Cc: "10.5" 

> -Carl
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev




signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] meta: Fix saving the results of the current occlusion query

2015-02-12 Thread Carl Worth 
On Tue, Nov 25 2014, Neil Roberts wrote:
> This patch fixes it by making it actually wait for the query object to be
> ready before grabbing the previous result. The downside of doing this is that
> it could introduce a stall but I think this situation is unlikely so it might
> not matter too much.

Thanks for the fix, Neil. The analysis and patch look sound to me, and
thanks for contributing a piglit test as well. Additionally, we ran the
patch through some benchmarks and didn't notice any negative performance
impact.

Reviewed-by: Carl Worth 

-Carl


pgpUYUpkJL7HF.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev