Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit
Am Mi., 27. Feb. 2019 um 17:12 Uhr schrieb Alyssa Rosenzweig : > > > super nitpicking: What is the purpose of this change? Should this > > define be added when it really gets used? > > I mean, we don't have explicit documentation on the cmdstream; if I > don't add the define / enum / struct / whatever in, it will be forgotten > to time. Ok, thanks. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit
> super nitpicking: What is the purpose of this change? Should this > define be added when it really gets used? I mean, we don't have explicit documentation on the cmdstream; if I don't add the define / enum / struct / whatever in, it will be forgotten to time. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] panfrost: List primitive restart enable bit
Am Mi., 27. Feb. 2019 um 05:48 Uhr schrieb Alyssa Rosenzweig : > > Signed-off-by: Alyssa Rosenzweig > --- > src/gallium/drivers/panfrost/include/panfrost-job.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h > b/src/gallium/drivers/panfrost/include/panfrost-job.h > index 1d738486617..d719325d07b 100644 > --- a/src/gallium/drivers/panfrost/include/panfrost-job.h > +++ b/src/gallium/drivers/panfrost/include/panfrost-job.h > @@ -820,10 +820,12 @@ struct mali_uniform_buffer_meta { > */ > > /* Applies to unknown_draw */ > + > #define MALI_DRAW_INDEXED_UINT8 (0x10) > #define MALI_DRAW_INDEXED_UINT16 (0x20) > #define MALI_DRAW_INDEXED_UINT32 (0x30) > #define MALI_DRAW_VARYING_SIZE (0x100) > +#define MALI_DRAW_PRIMITIVE_RESTART_FIXED_INDEX (0x1) > > struct mali_vertex_tiler_prefix { > /* This is a dynamic bitfield containing the following things in > this order: super nitpicking: What is the purpose of this change? Should this define be added when it really gets used? -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev