Re: [Mesa-dev] [PATCH] radv: add Doom workaround

[Timothy Arceri]

On 15/08/18 22:06, Bas Nieuwenhuizen wrote:

On Wed, Aug 15, 2018 at 1:16 PM, Mike Lothian  wrote:

Do you need the game name here, isn't that set in driconf?


There is no driconf for vulkan/radv yet.

Reviewed-by: Bas Nieuwenhuizen 

I assume you tested that it works with the workaround?


Yes. I get a black screen without it and I can get to the menu with it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: add Doom workaround

[Samuel Pitoiset]

I don't like this... but patch is:

Reviewed-by: Samuel Pitoiset 

On 8/15/18 1:12 PM, Timothy Arceri wrote:

Cc: 
---
  src/amd/vulkan/radv_device.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 33f24b9d302..cc88abb57a8 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -480,6 +480,9 @@ radv_handle_per_app_options(struct radv_instance *instance,
 */
instance->perftest_flags |= RADV_PERFTEST_SISCHED;
}
+   } else if (!strcmp(name, "DOOM_VFR")) {
+   /* Work around a Doom VFR game bug */
+   instance->debug_flags |= RADV_DEBUG_NO_DYNAMIC_BOUNDS;
}
  }
  


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: add Doom workaround

[Bas Nieuwenhuizen]

On Wed, Aug 15, 2018 at 1:16 PM, Mike Lothian  wrote:
> Do you need the game name here, isn't that set in driconf?

There is no driconf for vulkan/radv yet.

Reviewed-by: Bas Nieuwenhuizen 

I assume you tested that it works with the workaround?

>
> On Wed, 15 Aug 2018 at 12:12 Timothy Arceri  wrote:
>>
>> Cc: 
>> ---
>>  src/amd/vulkan/radv_device.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>> index 33f24b9d302..cc88abb57a8 100644
>> --- a/src/amd/vulkan/radv_device.c
>> +++ b/src/amd/vulkan/radv_device.c
>> @@ -480,6 +480,9 @@ radv_handle_per_app_options(struct radv_instance
>> *instance,
>>  */
>> instance->perftest_flags |= RADV_PERFTEST_SISCHED;
>> }
>> +   } else if (!strcmp(name, "DOOM_VFR")) {
>> +   /* Work around a Doom VFR game bug */
>> +   instance->debug_flags |= RADV_DEBUG_NO_DYNAMIC_BOUNDS;
>> }
>>  }
>>
>> --
>> 2.17.1
>>
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv: add Doom workaround

[Mike Lothian]

Do you need the game name here, isn't that set in driconf?

On Wed, 15 Aug 2018 at 12:12 Timothy Arceri  wrote:

> Cc: 
> ---
>  src/amd/vulkan/radv_device.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 33f24b9d302..cc88abb57a8 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -480,6 +480,9 @@ radv_handle_per_app_options(struct radv_instance
> *instance,
>  */
> instance->perftest_flags |= RADV_PERFTEST_SISCHED;
> }
> +   } else if (!strcmp(name, "DOOM_VFR")) {
> +   /* Work around a Doom VFR game bug */
> +   instance->debug_flags |= RADV_DEBUG_NO_DYNAMIC_BOUNDS;
> }
>  }
>
> --
> 2.17.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev