Re: [Mesa-dev] [PATCH 0/2] Two stable fixes for call instructions
Series is Reviewed-by: Ian Romanick On 06/25/2018 09:13 AM, Jason Ekstrand wrote: > These two patches are fixes for call instructions that get the basemark > shaders to pass NIR validation. Since the deref instruction stuff has > landed, these will have to go straight to stable without ever hitting > master. > > Dylan, please merge to whatever place you merge stable things once they've > had review. > > Cc: Dylan Baker > > Jason Ekstrand (2): > nir: Handle call instructions in foreach_src > nir/validate: Use the type from the tail of call parameter derefs > > src/compiler/nir/nir.c | 17 - > src/compiler/nir/nir_validate.c | 6 -- > 2 files changed, 20 insertions(+), 3 deletions(-) > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] Two stable fixes for call instructions
Quoting Jason Ekstrand (2018-06-25 12:36:39)
> On June 25, 2018 12:09:50 Dylan Baker wrote:
>
> > Quoting Jason Ekstrand (2018-06-25 09:13:03)
> >> These two patches are fixes for call instructions that get the basemark
> >> shaders to pass NIR validation. Since the deref instruction stuff has
> >> landed, these will have to go straight to stable without ever hitting
> >> master.
> >>
> >> Dylan, please merge to whatever place you merge stable things once they've
> >> had review.
> >
> > FYI, the best ways to ensure something get to stable are to (in order):
> >
> > Add a Fixes: abcdef123456789 ("nir: do things")
> >
> > Or, if your fixes don't fix a specific commit:
> >
> > CC: "18.1"
> >
> > There are scripts that look over the master branch, and generate a list of
> > commits to pull into the stable branch based on that.
>
> Above, I clearly stated that these patches will never hurt the master
> branch. They will need to go directly to stable.
Ah, sorry, I misread that.
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] Two stable fixes for call instructions
On June 25, 2018 12:09:50 Dylan Baker wrote:
Quoting Jason Ekstrand (2018-06-25 09:13:03)
These two patches are fixes for call instructions that get the basemark
shaders to pass NIR validation. Since the deref instruction stuff has
landed, these will have to go straight to stable without ever hitting
master.
Dylan, please merge to whatever place you merge stable things once they've
had review.
FYI, the best ways to ensure something get to stable are to (in order):
Add a Fixes: abcdef123456789 ("nir: do things")
Or, if your fixes don't fix a specific commit:
CC: "18.1"
There are scripts that look over the master branch, and generate a list of
commits to pull into the stable branch based on that.
Above, I clearly stated that these patches will never hurt the master
branch. They will need to go directly to stable.
--Jason
Dylan
Cc: Dylan Baker
Jason Ekstrand (2):
nir: Handle call instructions in foreach_src
nir/validate: Use the type from the tail of call parameter derefs
src/compiler/nir/nir.c | 17 -
src/compiler/nir/nir_validate.c | 6 --
2 files changed, 20 insertions(+), 3 deletions(-)
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 0/2] Two stable fixes for call instructions
Quoting Jason Ekstrand (2018-06-25 09:13:03)
> These two patches are fixes for call instructions that get the basemark
> shaders to pass NIR validation. Since the deref instruction stuff has
> landed, these will have to go straight to stable without ever hitting
> master.
>
> Dylan, please merge to whatever place you merge stable things once they've
> had review.
FYI, the best ways to ensure something get to stable are to (in order):
Add a Fixes: abcdef123456789 ("nir: do things")
Or, if your fixes don't fix a specific commit:
CC: "18.1"
There are scripts that look over the master branch, and generate a list of
commits to pull into the stable branch based on that.
Dylan
>
> Cc: Dylan Baker
>
> Jason Ekstrand (2):
> nir: Handle call instructions in foreach_src
> nir/validate: Use the type from the tail of call parameter derefs
>
> src/compiler/nir/nir.c | 17 -
> src/compiler/nir/nir_validate.c | 6 --
> 2 files changed, 20 insertions(+), 3 deletions(-)
>
> --
> 2.17.1
>
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
