Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Emil Velikov]

On 20 November 2015 at 04:08, Ian Romanick  wrote:
> On 11/19/2015 06:47 AM, Emil Velikov wrote:
>> Hi Ian,
>>
>> Attempting to high-jack the thread :-P
>>
>> On 18 November 2015 at 23:46, Ian Romanick  wrote:
>>
>>> I really wanted to get this in the next Mesa release.  For some reason,
>>> I thought the branch point was after Thanksgiving (which is next
>>> Thursday).  Ken reminded me yesterday that the branch point is actually
>>> this Friday. :( As a result, I'm sending it out today to get review as
>>> soon as possible.
>>>
>> Any suggestions on how we make dates more prominent/obvious ? I was
>> going to say "we even have it in #irc-devel channel topic" but you
>> don't seem to be around these days.
>
> VPN problems have made it basically impossible for me to be on IRC.
> It's a long, annoying story.  It's one of those "too busy to fix it"
> things too.  Ugh.
>
Ack. Let's hope you have a spare moment one of these days to fix it.

>> Alternatively you can set a filter in your email client - the subject
>> is always "Mesa #VERSION release plan"
>
> All my mesa-dev email goes in one folder, and it's really easy for
> single messages to get lost between the 40 patch series.  I like Ilia's
> suggestion of using mesa-announce.  That just dumps in my main inbox,
> and I'm less likely to miss it there.
>
Sure thing, we can mesa-announce for announcements (/me feels like cpt Obvious).

> One other thing... what time are you planning to make the branch
> tomorrow? :)
>
As usual - late night (after you guys have finished) or early Sat morning.

Cheers,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Chris Forbes]

Series (with the v2 changes) is:

Reviewed-by: Chris Forbes 

On Thu, Nov 19, 2015 at 12:46 PM, Ian Romanick  wrote:

> This patch series implements a new GL extension,
> EXT_shader_samples_identical.  This extension allows shaders to
> determine when all of the samples in a particular texel are the same.
> This takes advantage of the way compressed multisample surfaces are
> stored on modern Intel and AMD hardware.  This enables optimizations in
> application multisample resolve filters, etc.
>
> I really wanted to get this in the next Mesa release.  For some reason,
> I thought the branch point was after Thanksgiving (which is next
> Thursday).  Ken reminded me yesterday that the branch point is actually
> this Friday. :( As a result, I'm sending it out today to get review as
> soon as possible.
>
> I also wanted to get as much time as possible for other drivers to get
> implementations.  I worked with Graham Sellers on this extension, and he
> assures me that the implementation on modern Radeons is trivial.  My
> expectation is that it should be about the same as the Intel
> implementation.
>
> There will be some extra TGSI bits needed, but that should also be
> trivial.  For the NIR and i965 backend bits, I mostly copied and blended
> the implementations of txf_ms and query_samples.
>
> There are currently only trivial piglit tests, but I am working on more.
> I basically hacked up tests/spec/arb_texture_multisample/texelfetch.c to
> use the extension to render different colors based on whether
> textureSamplesIdenticalEXT returned true or false.  The resulting image
> and the generated assembly look good.  My plan is to get a set of real
> tests out by midday tomorrow.
>
> As soon as we're confident that the spec is good, I'll submit it to
> Khronos for publication in the registry.  I'm still waiting on feedback
> from another closed-source driver writer.
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Emil Velikov]

On 19 November 2015 at 14:53, Ilia Mirkin  wrote:
> On Thu, Nov 19, 2015 at 9:47 AM, Emil Velikov  
> wrote:
>> Hi Ian,
>>
>> Attempting to high-jack the thread :-P
>>
>> On 18 November 2015 at 23:46, Ian Romanick  wrote:
>>
>>> I really wanted to get this in the next Mesa release.  For some reason,
>>> I thought the branch point was after Thanksgiving (which is next
>>> Thursday).  Ken reminded me yesterday that the branch point is actually
>>> this Friday. :( As a result, I'm sending it out today to get review as
>>> soon as possible.
>>>
>> Any suggestions on how we make dates more prominent/obvious ? I was
>> going to say "we even have it in #irc-devel channel topic" but you
>> don't seem to be around these days.
>>
>> Alternatively you can set a filter in your email client - the subject
>> is always "Mesa #VERSION release plan"
>
> A common thing is to have a $project-announce mailing list which would
> receive such emails along with actual release notifications.
>
Good idea - we have mesa-announce so might as well use it :P
It is kind of strange that we do not use it (be that myself or
Ian/Carl priorly) for these things.

Will do from now on. Thanks !
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Ian Romanick]

On 11/19/2015 06:47 AM, Emil Velikov wrote:
> Hi Ian,
> 
> Attempting to high-jack the thread :-P
> 
> On 18 November 2015 at 23:46, Ian Romanick  wrote:
> 
>> I really wanted to get this in the next Mesa release.  For some reason,
>> I thought the branch point was after Thanksgiving (which is next
>> Thursday).  Ken reminded me yesterday that the branch point is actually
>> this Friday. :( As a result, I'm sending it out today to get review as
>> soon as possible.
>>
> Any suggestions on how we make dates more prominent/obvious ? I was
> going to say "we even have it in #irc-devel channel topic" but you
> don't seem to be around these days.

VPN problems have made it basically impossible for me to be on IRC.
It's a long, annoying story.  It's one of those "too busy to fix it"
things too.  Ugh.

> Alternatively you can set a filter in your email client - the subject
> is always "Mesa #VERSION release plan"

All my mesa-dev email goes in one folder, and it's really easy for
single messages to get lost between the 40 patch series.  I like Ilia's
suggestion of using mesa-announce.  That just dumps in my main inbox,
and I'm less likely to miss it there.

One other thing... what time are you planning to make the branch
tomorrow? :)

> Thanks
> Emil

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Emil Velikov]

Hi Ian,

Attempting to high-jack the thread :-P

On 18 November 2015 at 23:46, Ian Romanick  wrote:

> I really wanted to get this in the next Mesa release.  For some reason,
> I thought the branch point was after Thanksgiving (which is next
> Thursday).  Ken reminded me yesterday that the branch point is actually
> this Friday. :( As a result, I'm sending it out today to get review as
> soon as possible.
>
Any suggestions on how we make dates more prominent/obvious ? I was
going to say "we even have it in #irc-devel channel topic" but you
don't seem to be around these days.

Alternatively you can set a filter in your email client - the subject
is always "Mesa #VERSION release plan"

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Ilia Mirkin]

On Thu, Nov 19, 2015 at 9:47 AM, Emil Velikov  wrote:
> Hi Ian,
>
> Attempting to high-jack the thread :-P
>
> On 18 November 2015 at 23:46, Ian Romanick  wrote:
>
>> I really wanted to get this in the next Mesa release.  For some reason,
>> I thought the branch point was after Thanksgiving (which is next
>> Thursday).  Ken reminded me yesterday that the branch point is actually
>> this Friday. :( As a result, I'm sending it out today to get review as
>> soon as possible.
>>
> Any suggestions on how we make dates more prominent/obvious ? I was
> going to say "we even have it in #irc-devel channel topic" but you
> don't seem to be around these days.
>
> Alternatively you can set a filter in your email client - the subject
> is always "Mesa #VERSION release plan"

A common thing is to have a $project-announce mailing list which would
receive such emails along with actual release notifications.

  -ilia
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Jason Ekstrand]

On Wed, Nov 18, 2015 at 4:23 PM, Kenneth Graunke  wrote:
> On Wednesday, November 18, 2015 03:46:46 PM Ian Romanick wrote:
>> This patch series implements a new GL extension,
>> EXT_shader_samples_identical.  This extension allows shaders to
>> determine when all of the samples in a particular texel are the same.
>> This takes advantage of the way compressed multisample surfaces are
>> stored on modern Intel and AMD hardware.  This enables optimizations in
>> application multisample resolve filters, etc.
>>
>> I really wanted to get this in the next Mesa release.  For some reason,
>> I thought the branch point was after Thanksgiving (which is next
>> Thursday).  Ken reminded me yesterday that the branch point is actually
>> this Friday. :( As a result, I'm sending it out today to get review as
>> soon as possible.
>>
>> I also wanted to get as much time as possible for other drivers to get
>> implementations.  I worked with Graham Sellers on this extension, and he
>> assures me that the implementation on modern Radeons is trivial.  My
>> expectation is that it should be about the same as the Intel
>> implementation.
>>
>> There will be some extra TGSI bits needed, but that should also be
>> trivial.  For the NIR and i965 backend bits, I mostly copied and blended
>> the implementations of txf_ms and query_samples.
>>
>> There are currently only trivial piglit tests, but I am working on more.
>> I basically hacked up tests/spec/arb_texture_multisample/texelfetch.c to
>> use the extension to render different colors based on whether
>> textureSamplesIdenticalEXT returned true or false.  The resulting image
>> and the generated assembly look good.  My plan is to get a set of real
>> tests out by midday tomorrow.
>>
>> As soon as we're confident that the spec is good, I'll submit it to
>> Khronos for publication in the registry.  I'm still waiting on feedback
>> from another closed-source driver writer.
>
> Other than the few comments I had, this looks good to me.
>
> Series is:
> Reviewed-by: Kenneth Graunke 
>
> I look forward to seeing it in action in meta_blit.c.
>
> It sounds like Chris plans to review it as well, which is great.

I made a few comments on the last three patches, only one of which (on
the last patch) is really critical.  The rest we can clean up later if
you don't want to deal with it now.
--Jason
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Kenneth Graunke]

On Wednesday, November 18, 2015 03:46:46 PM Ian Romanick wrote:
> This patch series implements a new GL extension,
> EXT_shader_samples_identical.  This extension allows shaders to
> determine when all of the samples in a particular texel are the same.
> This takes advantage of the way compressed multisample surfaces are
> stored on modern Intel and AMD hardware.  This enables optimizations in
> application multisample resolve filters, etc.
> 
> I really wanted to get this in the next Mesa release.  For some reason,
> I thought the branch point was after Thanksgiving (which is next
> Thursday).  Ken reminded me yesterday that the branch point is actually
> this Friday. :( As a result, I'm sending it out today to get review as
> soon as possible.
> 
> I also wanted to get as much time as possible for other drivers to get
> implementations.  I worked with Graham Sellers on this extension, and he
> assures me that the implementation on modern Radeons is trivial.  My
> expectation is that it should be about the same as the Intel
> implementation.
> 
> There will be some extra TGSI bits needed, but that should also be
> trivial.  For the NIR and i965 backend bits, I mostly copied and blended
> the implementations of txf_ms and query_samples.
> 
> There are currently only trivial piglit tests, but I am working on more.
> I basically hacked up tests/spec/arb_texture_multisample/texelfetch.c to
> use the extension to render different colors based on whether
> textureSamplesIdenticalEXT returned true or false.  The resulting image
> and the generated assembly look good.  My plan is to get a set of real
> tests out by midday tomorrow.
> 
> As soon as we're confident that the spec is good, I'll submit it to
> Khronos for publication in the registry.  I'm still waiting on feedback
> from another closed-source driver writer.

Other than the few comments I had, this looks good to me.

Series is:
Reviewed-by: Kenneth Graunke 

I look forward to seeing it in action in meta_blit.c.

It sounds like Chris plans to review it as well, which is great.


signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/8] Implement EXT_shader_samples_identical

[Chris Forbes]

It lives! Thanks for picking this up, Ian.

Had a very brief look at the series as it arrived, looks good; will try to
do a real review later today.

- Chris
On Nov 19, 2015 12:47 PM, "Ian Romanick"  wrote:

> This patch series implements a new GL extension,
> EXT_shader_samples_identical.  This extension allows shaders to
> determine when all of the samples in a particular texel are the same.
> This takes advantage of the way compressed multisample surfaces are
> stored on modern Intel and AMD hardware.  This enables optimizations in
> application multisample resolve filters, etc.
>
> I really wanted to get this in the next Mesa release.  For some reason,
> I thought the branch point was after Thanksgiving (which is next
> Thursday).  Ken reminded me yesterday that the branch point is actually
> this Friday. :( As a result, I'm sending it out today to get review as
> soon as possible.
>
> I also wanted to get as much time as possible for other drivers to get
> implementations.  I worked with Graham Sellers on this extension, and he
> assures me that the implementation on modern Radeons is trivial.  My
> expectation is that it should be about the same as the Intel
> implementation.
>
> There will be some extra TGSI bits needed, but that should also be
> trivial.  For the NIR and i965 backend bits, I mostly copied and blended
> the implementations of txf_ms and query_samples.
>
> There are currently only trivial piglit tests, but I am working on more.
> I basically hacked up tests/spec/arb_texture_multisample/texelfetch.c to
> use the extension to render different colors based on whether
> textureSamplesIdenticalEXT returned true or false.  The resulting image
> and the generated assembly look good.  My plan is to get a set of real
> tests out by midday tomorrow.
>
> As soon as we're confident that the spec is good, I'll submit it to
> Khronos for publication in the registry.  I'm still waiting on feedback
> from another closed-source driver writer.
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev