Re: [Mesa-dev] [PATCH 04/20] automake: make install-lib-links less chatty
On Tue, Mar 4, 2014 at 10:12 PM, Emil Velikov emil.l.veli...@gmail.com wrote: There is little point in echoing everything that the script does to stdout. Wrap it in AM_V_GEN so that a reasonable message is printed as a indication of it's invocation. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- install-lib-links.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install-lib-links.mk b/install-lib-links.mk index 73d9e14..9dd4c30 100644 --- a/install-lib-links.mk +++ b/install-lib-links.mk @@ -4,7 +4,7 @@ all-local : .libs/install-mesa-links .libs/install-mesa-links : $(lib_LTLIBRARIES) - $(MKDIR_P) $(top_builddir)/$(LIB_DIR) + $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/$(LIB_DIR); \ GEN for a directory, really? Why not $(AM_V_at)? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 04/20] automake: make install-lib-links less chatty
On 05/03/14 10:13, Erik Faye-Lund wrote: On Tue, Mar 4, 2014 at 10:12 PM, Emil Velikov emil.l.veli...@gmail.com wrote: There is little point in echoing everything that the script does to stdout. Wrap it in AM_V_GEN so that a reasonable message is printed as a indication of it's invocation. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- install-lib-links.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install-lib-links.mk b/install-lib-links.mk index 73d9e14..9dd4c30 100644 --- a/install-lib-links.mk +++ b/install-lib-links.mk @@ -4,7 +4,7 @@ all-local : .libs/install-mesa-links .libs/install-mesa-links : $(lib_LTLIBRARIES) - $(MKDIR_P) $(top_builddir)/$(LIB_DIR) + $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/$(LIB_DIR); \ GEN for a directory, really? Why not $(AM_V_at)? Notice the trailing backspace, which will wrap the whole script in GEN. One could use AM_V_at for the folder and AM_V_GEN (or other) for the link/copy. IMHO the latter may be an overkill but meh... -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 04/20] automake: make install-lib-links less chatty
On Wed, Mar 5, 2014 at 12:42 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 05/03/14 10:13, Erik Faye-Lund wrote: On Tue, Mar 4, 2014 at 10:12 PM, Emil Velikov emil.l.veli...@gmail.com wrote: There is little point in echoing everything that the script does to stdout. Wrap it in AM_V_GEN so that a reasonable message is printed as a indication of it's invocation. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- install-lib-links.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install-lib-links.mk b/install-lib-links.mk index 73d9e14..9dd4c30 100644 --- a/install-lib-links.mk +++ b/install-lib-links.mk @@ -4,7 +4,7 @@ all-local : .libs/install-mesa-links .libs/install-mesa-links : $(lib_LTLIBRARIES) - $(MKDIR_P) $(top_builddir)/$(LIB_DIR) + $(AM_V_GEN)$(MKDIR_P) $(top_builddir)/$(LIB_DIR); \ GEN for a directory, really? Why not $(AM_V_at)? Notice the trailing backspace, which will wrap the whole script in GEN. One could use AM_V_at for the folder and AM_V_GEN (or other) for the link/copy. IMHO the latter may be an overkill but meh... Right, I missed that, thanks. Makes sense to me, and I agree that it's overkill. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
