On Fri, 2018-05-04 at 10:56 -0700, Francisco Jerez wrote:
> Jan Vesely writes:
>
> > These are needed to destroy the v vector.
> > Fixes memory leaks on kernel launch.
> > Signed-off-by: Jan Vesely
> > ---
> > src/gallium/state_trackers/clover/core/kernel.hpp | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/src/gallium/state_trackers/clover/core/kernel.hpp
> > b/src/gallium/state_trackers/clover/core/kernel.hpp
> > index 4ba6ff467b..218f92cb1d 100644
> > --- a/src/gallium/state_trackers/clover/core/kernel.hpp
> > +++ b/src/gallium/state_trackers/clover/core/kernel.hpp
> > @@ -93,6 +93,7 @@ namespace clover {
> > /// Free any resources that were allocated in bind().
> > virtual void unbind(exec_context &ctx) = 0;
> >
> > + virtual ~argument() {};
> >protected:
> > argument();
> >
> > @@ -143,6 +144,7 @@ namespace clover {
> >class scalar_argument : public argument {
> >public:
> > scalar_argument(size_t size);
> > + virtual ~scalar_argument() {};
>
> This line shouldn't be necessary. With that fixed:
>
> Reviewed-by: Francisco Jerez
thanks, fixed locally (also adapted the commit message) and pushed.
just fyi: this allows math_bruteforce conformance test to finish on
carrizo (1 error) instead of running out of memory half way through.
JAn
>
> Thanks!
>
> >
> > virtual void set(size_t size, const void *value);
> > virtual void bind(exec_context &ctx,
> > --
> > 2.17.0
--
Jan Vesely
signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
