Re: [Mesa-dev] [PATCH 1/2] st/clover: Clear the complete queue

2013-09-26 Thread Niels Ole Salscheider
Ping
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 1/2] st/clover: Clear the complete queue

2013-09-26 Thread Francisco Jerez
Niels Ole Salscheider niels_...@salscheider-online.de writes:

 Events that are already signalled can be removed from the queue, too.

 Signed-off-by: Niels Ole Salscheider niels_...@salscheider-online.de

I don't think this is right, with this patch we remove *all* events from
the command queue, signalled or not, every time the command queue is
flushed.

 ---
  src/gallium/state_trackers/clover/core/queue.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/src/gallium/state_trackers/clover/core/queue.cpp 
 b/src/gallium/state_trackers/clover/core/queue.cpp
 index 0b1c494..500a636 100644
 --- a/src/gallium/state_trackers/clover/core/queue.cpp
 +++ b/src/gallium/state_trackers/clover/core/queue.cpp
 @@ -56,7 +56,7 @@ _cl_command_queue::flush() {
pipe-flush(pipe, fence, 0);
std::for_each(first, last, [](event_ptr ev) { ev-fence(fence); });
screen-fence_reference(screen, fence, NULL);
 -  queued_events.erase(first, last);
 +  queued_events.clear();
 }
  }
  
 -- 
 1.8.4

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev


pgpZimOgjOI86.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev