Re: [Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly
On 10 June 2016 at 00:25, Leo Liu wrote: > Jose was suggesting two approaches to fix scons build, he did a very quick > fix back then with the second approach. > The patch here is his first approach, and I think this is more proper. > Personally I'm fine with either approach. If you prefer this one - please update drop the old commit message and use your reply above. With that: Acked-by: Emil Velikov Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly
On 06/09/2016 07:13 PM, Emil Velikov wrote: Hi Leo, On 9 June 2016 at 20:11, Leo Liu wrote: in order to accommodate scons build IIRC Jose fixed the SCons build (Makefile.sources actually) a while back. One do does not build any of VL with scons so I'm not sure what you with with "accommodate" here. Can you please elaborate ? Jose was suggesting two approaches to fix scons build, he did a very quick fix back then with the second approach. The patch here is his first approach, and I think this is more proper. Cheers, Leo Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly
Hi Leo, On 9 June 2016 at 20:11, Leo Liu wrote: > in order to accommodate scons build > IIRC Jose fixed the SCons build (Makefile.sources actually) a while back. One do does not build any of VL with scons so I'm not sure what you with with "accommodate" here. Can you please elaborate ? Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
