Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

[Tom Stellard]

On Fri, Mar 29, 2013 at 12:32:19PM +, Mike Lothian wrote:
> Sorry that patch doesn't fix the build
> 
> diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29
> 12:14:25.514504748 +
> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29
> 12:13:03.978506530 +
> @@ -37,7 +37,8 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
> +#include 
>  #endif
>  #include 
>  #include 
> 
> 
> This one does however
>

Committed, thanks!

> 
> 
> On 29 March 2013 11:40, Mike Lothian  wrote:
> 
> > Hi
> >
> > This include is also in
> > src/gallium/state_trackers/clover/llvm/invocation.cpp
> >
> > diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> >  2013-03-29 11:15:52.851581526 +
> > +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp2013-03-29
> > 11:32:41.580559478 +
> > @@ -37,7 +37,6 @@
> >  #include 
> >  #include 
> >  #include 
> > -#include 
> >  #endif
> >  #include 
> >  #include 
> >
> > Cheers
> >
> > Mike
> >
> >
> >
> > On 26 March 2013 12:11, Christian König  wrote:
> >
> >> Am 26.03.2013 12:53, schrieb Michel Dänzer:
> >>
> >>  On Die, 2013-03-26 at 11:56 +0100, Christian König wrote:
> >>>
>  From: Christian König 
> 
>  The include isn't needed and the file has moved with LLVM master.
> 
>  Signed-off-by: Christian König 
> 
> >>> Reviewed-by: Michel Dänzer 
> >>>
> >>> The rest of the series seems unchanged, so my review of it stands.
> >>>
> >>
> >> How about the LLVM changes? I know we could improve WQM now that it is in
> >> the backend, but I would rather like to let it stay like this for another
> >> round (as good or as bad as it is) and try to get this patchset committed
> >> first.
> >>
> >> Christian.
> >>
> >> __**_
> >> mesa-dev mailing list
> >> mesa-dev@lists.freedesktop.org
> >> http://lists.freedesktop.org/**mailman/listinfo/mesa-dev
> >>
> >
> >

> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

[Mike Lothian]

Sorry that patch doesn't fix the build

diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29
12:14:25.514504748 +
+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp 2013-03-29
12:13:03.978506530 +
@@ -37,7 +37,8 @@
 #include 
 #include 
 #include 
-#include 
+#include 
+#include 
 #endif
 #include 
 #include 


This one does however



On 29 March 2013 11:40, Mike Lothian  wrote:

> Hi
>
> This include is also in
> src/gallium/state_trackers/clover/llvm/invocation.cpp
>
> diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
>  2013-03-29 11:15:52.851581526 +
> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp2013-03-29
> 11:32:41.580559478 +
> @@ -37,7 +37,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #endif
>  #include 
>  #include 
>
> Cheers
>
> Mike
>
>
>
> On 26 March 2013 12:11, Christian König  wrote:
>
>> Am 26.03.2013 12:53, schrieb Michel Dänzer:
>>
>>  On Die, 2013-03-26 at 11:56 +0100, Christian König wrote:
>>>
 From: Christian König 

 The include isn't needed and the file has moved with LLVM master.

 Signed-off-by: Christian König 

>>> Reviewed-by: Michel Dänzer 
>>>
>>> The rest of the series seems unchanged, so my review of it stands.
>>>
>>
>> How about the LLVM changes? I know we could improve WQM now that it is in
>> the backend, but I would rather like to let it stay like this for another
>> round (as good or as bad as it is) and try to get this patchset committed
>> first.
>>
>> Christian.
>>
>> __**_
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> http://lists.freedesktop.org/**mailman/listinfo/mesa-dev
>>
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

[Mike Lothian]

Hi

This include is also in
src/gallium/state_trackers/clover/llvm/invocation.cpp

diff -Naur a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src/gallium/state_trackers/clover/llvm/invocation.cpp
--- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
 2013-03-29 11:15:52.851581526 +
+++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp2013-03-29
11:32:41.580559478 +
@@ -37,7 +37,6 @@
 #include 
 #include 
 #include 
-#include 
 #endif
 #include 
 #include 

Cheers

Mike



On 26 March 2013 12:11, Christian König  wrote:

> Am 26.03.2013 12:53, schrieb Michel Dänzer:
>
>  On Die, 2013-03-26 at 11:56 +0100, Christian König wrote:
>>
>>> From: Christian König 
>>>
>>> The include isn't needed and the file has moved with LLVM master.
>>>
>>> Signed-off-by: Christian König 
>>>
>> Reviewed-by: Michel Dänzer 
>>
>> The rest of the series seems unchanged, so my review of it stands.
>>
>
> How about the LLVM changes? I know we could improve WQM now that it is in
> the backend, but I would rather like to let it stay like this for another
> round (as good or as bad as it is) and try to get this patchset committed
> first.
>
> Christian.
>
> __**_
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/**mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

[Christian König]

Am 26.03.2013 12:53, schrieb Michel Dänzer:

On Die, 2013-03-26 at 11:56 +0100, Christian König wrote:

From: Christian König 

The include isn't needed and the file has moved with LLVM master.

Signed-off-by: Christian König 

Reviewed-by: Michel Dänzer 

The rest of the series seems unchanged, so my review of it stands.


How about the LLVM changes? I know we could improve WQM now that it is 
in the backend, but I would rather like to let it stay like this for 
another round (as good or as bad as it is) and try to get this patchset 
committed first.


Christian.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] radeon/llvm: remove uneeded inclusion

[Michel Dänzer]

On Die, 2013-03-26 at 11:56 +0100, Christian König wrote: 
> From: Christian König 
> 
> The include isn't needed and the file has moved with LLVM master.
> 
> Signed-off-by: Christian König 

Reviewed-by: Michel Dänzer 

The rest of the series seems unchanged, so my review of it stands.


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast |  Debian, X and DRI developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev