Re: [Mesa-dev] [PATCH 1/9] glapi: Add uniform buffer object API
On 06/18/2012 06:35 PM, Eric Anholt wrote: From: Vincent Lejeune v...@ovi.com v2: Fix a typo spotted by Eric Anholt. v3: Fix missing GL on types, fix style, fix Studly_Caps extension name, drop commented code duplicated with GL3x.xml [anholt] Aside from the pithy comments and one tiny fix, this series looks good to me! It's a start at least :) Reviewed-by: Kenneth Graunke kenn...@whitecape.org ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/9] glapi: Add uniform buffer object API
On 06/18/2012 07:35 PM, Eric Anholt wrote: From: Vincent Lejeunev...@ovi.com v2: Fix a typo spotted by Eric Anholt. v3: Fix missing GL on types, fix style, fix Studly_Caps extension name, drop commented code duplicated with GL3x.xml [anholt] --- src/mapi/glapi/gen/ARB_uniform_buffer_object.xml | 97 ++ src/mapi/glapi/gen/Makefile |1 + src/mapi/glapi/gen/gl_API.xml|4 +- 3 files changed, 101 insertions(+), 1 deletion(-) create mode 100644 src/mapi/glapi/gen/ARB_uniform_buffer_object.xml For the series: Reviewed-by: Brian Paul bri...@vmware.com Just minor comments on patches 4, 7, 9. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/9] glapi: Add Uniform Buffer Object API
On Thu, 1 Dec 2011 16:35:31 +0100, Vincent Lejeune v...@ovi.com wrote: v2: Fix a typo spotted by Eric Anholt. --- src/mapi/glapi/gen/ARB_Uniform_Buffer_Object.xml | 115 ++ This should be capitalized like the extension, not Studly_Underscore_Caps (eww). pgp5qk7PfiOxU.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/9] glapi: Add Uniform Buffer Object API
On Mon, 17 Oct 2011 00:37:14 +0200, vlj v...@ovi.com wrote: --- src/mapi/glapi/gen/ARB_Uniform_Buffer_Object.xml | 115 ++ src/mapi/glapi/gen/Makefile |1 + src/mapi/glapi/gen/gl_API.xml|2 +- 3 files changed, 117 insertions(+), 1 deletions(-) create mode 100644 src/mapi/glapi/gen/ARB_Uniform_Buffer_Object.xml diff --git a/src/mapi/glapi/gen/ARB_Uniform_Buffer_Object.xml b/src/mapi/glapi/gen/ARB_Uniform_Buffer_Object.xml new file mode 100644 index 000..ea9d6b7 +function name=GetActiveUniformsiv offset=assign +param name=program type=GLuint / +param name=uniformCount type=GLsizei / +param name=uniformIndices type=const GLuint* / +param name=pname type=GLenum / +param name=paras type=GLint* / Didn't actually review this patch, but saw this typo while scrolling down. +/function pgprkNcENuKaE.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
