Re: [Mesa-dev] [PATCH 2/4] vulkan/util: Add support to not generate the trampolines.

2018-08-08 Thread Bas Nieuwenhuizen
On Wed, Aug 8, 2018 at 12:19 PM, Emil Velikov  wrote:
> On 8 August 2018 at 00:14, Bas Nieuwenhuizen  wrote:
>
>> @@ -146,7 +148,7 @@ static const uint16_t string_map[${strmap.hash_size}] = {
>>  };
>>
>>  int
>> -${name_prefix}_string_map_lookup(const char *str)
>> +${name_prefix}_get_entrypoint_index(const char *str)
>
> Unrelated - did you mean to have this as part of 1/4?

Yeah, you're right about the unintended hunks in patch 2 and 3, moved
them to patch 1. Will wait with sending out v2 until we have some
consensus about the python import paths.

>
> -Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 2/4] vulkan/util: Add support to not generate the trampolines.

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 00:14, Bas Nieuwenhuizen  wrote:

> @@ -146,7 +148,7 @@ static const uint16_t string_map[${strmap.hash_size}] = {
>  };
>
>  int
> -${name_prefix}_string_map_lookup(const char *str)
> +${name_prefix}_get_entrypoint_index(const char *str)

Unrelated - did you mean to have this as part of 1/4?

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev