Re: [Mesa-dev] [PATCH 2/9] i965/fs: print writemask_all when it's enabled
On Fri, Nov 20, 2015 at 2:46 AM, Iago Toral wrote: > On Thu, 2015-11-19 at 10:14 -0500, Connor Abbott wrote: >> I think Ken already pushed a similar patch so we can drop this. > > I don't see that in master, but sure, we can hold this back if he is > planning to push the same thing. > > Iago No, he already pushed it, the SHA is e42a29531ae3d5dedb72011da2947357dfa8715b. > >> On Thu, Nov 19, 2015 at 5:05 AM, Iago Toral Quiroga >> wrote: >> > From: Connor Abbott >> > >> > Reviewed-by: Iago Toral Quiroga >> > --- >> > src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp >> > b/src/mesa/drivers/dri/i965/brw_fs.cpp >> > index 2d4ed6a..63dcba7 100644 >> > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp >> > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp >> > @@ -4787,6 +4787,9 @@ fs_visitor::dump_instruction(backend_instruction >> > *be_inst, FILE *file) >> > fprintf(file, "1sthalf "); >> > } >> > >> > + if (inst->force_writemask_all) >> > + fprintf(file, "WE_all "); >> > + >> > fprintf(file, "\n"); >> > } >> > >> > -- >> > 1.9.1 >> > >> > > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 2/9] i965/fs: print writemask_all when it's enabled
On Thu, 2015-11-19 at 10:14 -0500, Connor Abbott wrote: > I think Ken already pushed a similar patch so we can drop this. I don't see that in master, but sure, we can hold this back if he is planning to push the same thing. Iago > On Thu, Nov 19, 2015 at 5:05 AM, Iago Toral Quiroga wrote: > > From: Connor Abbott > > > > Reviewed-by: Iago Toral Quiroga > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > > b/src/mesa/drivers/dri/i965/brw_fs.cpp > > index 2d4ed6a..63dcba7 100644 > > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > > @@ -4787,6 +4787,9 @@ fs_visitor::dump_instruction(backend_instruction > > *be_inst, FILE *file) > > fprintf(file, "1sthalf "); > > } > > > > + if (inst->force_writemask_all) > > + fprintf(file, "WE_all "); > > + > > fprintf(file, "\n"); > > } > > > > -- > > 1.9.1 > > > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 2/9] i965/fs: print writemask_all when it's enabled
I think Ken already pushed a similar patch so we can drop this. On Thu, Nov 19, 2015 at 5:05 AM, Iago Toral Quiroga wrote: > From: Connor Abbott > > Reviewed-by: Iago Toral Quiroga > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp > index 2d4ed6a..63dcba7 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp > @@ -4787,6 +4787,9 @@ fs_visitor::dump_instruction(backend_instruction > *be_inst, FILE *file) > fprintf(file, "1sthalf "); > } > > + if (inst->force_writemask_all) > + fprintf(file, "WE_all "); > + > fprintf(file, "\n"); > } > > -- > 1.9.1 > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 2/9] i965/fs: print writemask_all when it's enabled
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
