Re: [Mesa-dev] [PATCH 5/8] swr/rast: Switch intrinsic usage to SIMDLib

2017-06-26 Thread Rowley, Timothy O

> On Jun 26, 2017, at 8:11 AM, Emil Velikov  wrote:
> 
> Hi Tim,
> 
> On 22 June 2017 at 22:13, Tim Rowley  wrote:
>> Switch from a macro-based simd intrinsics layer to a more C++
>> implementation, which also adds AVX512 optimizations to 128-bit
>> and 256-bit SIMD.
> 
>> +   rasterizer/common/simdlib_128_avx.inl \
>> +   rasterizer/common/simdlib_128_avx2.inl \
>> +   rasterizer/common/simdlib_128_avx512.inl \
>> +   rasterizer/common/simdlib_256_avx.inl \
>> +   rasterizer/common/simdlib_256_avx2.inl \
>> +   rasterizer/common/simdlib_256_avx512.inl \
>> +   rasterizer/common/simdlib_512_avx512.inl \
>> +   rasterizer/common/simdlib_512_avx512_masks.inl \
>> +   rasterizer/common/simdlib_512_emu.inl \
>> +   rasterizer/common/simdlib_512_emu_masks.inl \
> Your commit message said "make dist/check" but I'd imagine you used
> SCons for the whole series as well, correct?
> 
> Merely double-checking as some versions of SCons had issues with non
> {c,h}{,pp} files listed as sources, IIRC. Sadly I don't recall the
> specifics.

I thought this had been tested internally on scons; turns out I was mistaken - 
we will get it working for the next version of the commit.

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH 5/8] swr/rast: Switch intrinsic usage to SIMDLib

2017-06-26 Thread Emil Velikov
Hi Tim,

On 22 June 2017 at 22:13, Tim Rowley  wrote:
> Switch from a macro-based simd intrinsics layer to a more C++
> implementation, which also adds AVX512 optimizations to 128-bit
> and 256-bit SIMD.

> +   rasterizer/common/simdlib_128_avx.inl \
> +   rasterizer/common/simdlib_128_avx2.inl \
> +   rasterizer/common/simdlib_128_avx512.inl \
> +   rasterizer/common/simdlib_256_avx.inl \
> +   rasterizer/common/simdlib_256_avx2.inl \
> +   rasterizer/common/simdlib_256_avx512.inl \
> +   rasterizer/common/simdlib_512_avx512.inl \
> +   rasterizer/common/simdlib_512_avx512_masks.inl \
> +   rasterizer/common/simdlib_512_emu.inl \
> +   rasterizer/common/simdlib_512_emu_masks.inl \
Your commit message said "make dist/check" but I'd imagine you used
SCons for the whole series as well, correct?

Merely double-checking as some versions of SCons had issues with non
{c,h}{,pp} files listed as sources, IIRC. Sadly I don't recall the
specifics.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev