Re: [Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

2016-04-20 Thread Michel Dänzer
On 19.04.2016 00:55, Nicolas Dufresne wrote:
> Le lundi 18 avril 2016 à 11:40 +0900, Michel Dänzer a écrit :
>> On 17.04.2016 09:49, nico...@ndufresne.ca wrote:
>>>
>>> From: Nicolas Dufresne 
>>>
>>> Sorry for the long delay breaking down this patch. I have now
>>> rebased
>>> on top recent mesa tree. First patch creates a new function to
>>> convert
>>> DRI2 format into PIPE format (to avoid more copy paste). The second
>>> fixes 
>>> the wrong pitch to stride calculation fixing RGB565 support. Note
>>> that, in
>>> that part of the code, pitch is considered to be in pixels while
>>> stride is
>>> in bytes.
>>>
>>> Nicolas Dufresne (2):
>>>   gallium/dri2: Factor out DRI2 to PIPE_FORMAT conversion
>>>   gallium/dri2: Fix RGB565 EGLImage creation
>>>
>>>  src/gallium/state_trackers/dri/dri2.c | 105 +-
>>> 
>>>  1 file changed, 51 insertions(+), 54 deletions(-)
>> The series is
>>
>> Reviewed-by: Michel Dänzer 
>>
>> Do you need somebody to push the patches for you?
> 
> Yes please, thanks for the review.

Pushed (with the shortlog prefix changed to the more conventional
"st/dri:", sorry I missed that before), thanks!


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

2016-04-18 Thread Nicolas Dufresne
Le lundi 18 avril 2016 à 11:40 +0900, Michel Dänzer a écrit :
> On 17.04.2016 09:49, nico...@ndufresne.ca wrote:
> > 
> > From: Nicolas Dufresne 
> > 
> > Sorry for the long delay breaking down this patch. I have now
> > rebased
> > on top recent mesa tree. First patch creates a new function to
> > convert
> > DRI2 format into PIPE format (to avoid more copy paste). The second
> > fixes 
> > the wrong pitch to stride calculation fixing RGB565 support. Note
> > that, in
> > that part of the code, pitch is considered to be in pixels while
> > stride is
> > in bytes.
> > 
> > Nicolas Dufresne (2):
> >   gallium/dri2: Factor out DRI2 to PIPE_FORMAT conversion
> >   gallium/dri2: Fix RGB565 EGLImage creation
> > 
> >  src/gallium/state_trackers/dri/dri2.c | 105 +-
> > 
> >  1 file changed, 51 insertions(+), 54 deletions(-)
> The series is
> 
> Reviewed-by: Michel Dänzer 
> 
> Do you need somebody to push the patches for you?

Yes please, thanks for the review.

signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

2016-04-17 Thread Michel Dänzer
On 17.04.2016 09:49, nico...@ndufresne.ca wrote:
> From: Nicolas Dufresne 
> 
> Sorry for the long delay breaking down this patch. I have now rebased
> on top recent mesa tree. First patch creates a new function to convert
> DRI2 format into PIPE format (to avoid more copy paste). The second fixes 
> the wrong pitch to stride calculation fixing RGB565 support. Note that, in
> that part of the code, pitch is considered to be in pixels while stride is
> in bytes.
> 
> Nicolas Dufresne (2):
>   gallium/dri2: Factor out DRI2 to PIPE_FORMAT conversion
>   gallium/dri2: Fix RGB565 EGLImage creation
> 
>  src/gallium/state_trackers/dri/dri2.c | 105 
> +-
>  1 file changed, 51 insertions(+), 54 deletions(-)

The series is

Reviewed-by: Michel Dänzer 

Do you need somebody to push the patches for you?


-- 
Earthling Michel Dänzer   |   http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev