Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On 22 October 2015 at 23:22, Nanley Chery wrote: > On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov > wrote: >> >> That aside, I'm in favour of keeping the comments as is. The editing >> comment does not apply imho. >> > > Since, there isn't a unanimous opinion on this, I'll leave the FIXME > to save some rebasing time. Are you referring to my git comment? > Or to my previous reply about why I moved the FIXME? > "I moved it aside to make editing the table easier. " is the one I had in mind. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On Fri, Oct 23, 2015 at 12:22 AM, Nanley Chery wrote: > > > On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov > wrote: >> >> On 20 October 2015 at 16:43, Nanley Chery wrote: >> > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: >> >> >> >> Also, the FIXME comment should be on its own line. >> >> >> > >> > I moved it aside to make editing the table easier. However, since the >> > formatting of the >> > table is unlikely to change much after this series, I agree that I >> > should >> > move it back to >> > its original position. >> > >> Actually the designated initalisers should be fine in core mesa. If in >> doubt wrt MSVC compat, just grep MSVC.*COMPAT through whole of mesa. >> The 2013 version adds support for this feature. >> Alternatively feel free to ask Brian/Jose, as they have a fair bit of >> experience in the area. >> > > That's good news. Thanks for the information. > >> >> That aside, I'm in favour of keeping the comments as is. The editing >> comment does not apply imho. >> > > Since, there isn't a unanimous opinion on this, I'll leave the FIXME > to save some rebasing time. Are you referring to my git comment? > Or to my previous reply about why I moved the FIXME? Yeah, feel free to fix the FIXME later in the series. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov wrote: > On 20 October 2015 at 16:43, Nanley Chery wrote: > > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: > >> > >> Also, the FIXME comment should be on its own line. > >> > > > > I moved it aside to make editing the table easier. However, since the > > formatting of the > > table is unlikely to change much after this series, I agree that I should > > move it back to > > its original position. > > > Actually the designated initalisers should be fine in core mesa. If in > doubt wrt MSVC compat, just grep MSVC.*COMPAT through whole of mesa. > The 2013 version adds support for this feature. > Alternatively feel free to ask Brian/Jose, as they have a fair bit of > experience in the area. > > That's good news. Thanks for the information. > That aside, I'm in favour of keeping the comments as is. The editing > comment does not apply imho. > > Since, there isn't a unanimous opinion on this, I'll leave the FIXME to save some rebasing time. Are you referring to my git comment? Or to my previous reply about why I moved the FIXME? -Emil > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On 20 October 2015 at 16:43, Nanley Chery wrote: > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: >> >> Also, the FIXME comment should be on its own line. >> > > I moved it aside to make editing the table easier. However, since the > formatting of the > table is unlikely to change much after this series, I agree that I should > move it back to > its original position. > Actually the designated initalisers should be fine in core mesa. If in doubt wrt MSVC compat, just grep MSVC.*COMPAT through whole of mesa. The 2013 version adds support for this feature. Alternatively feel free to ask Brian/Jose, as they have a fair bit of experience in the area. That aside, I'm in favour of keeping the comments as is. The editing comment does not apply imho. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote:
> Also, the FIXME comment should be on its own line.
>
>
I moved it aside to make editing the table easier. However, since the
formatting of the
table is unlikely to change much after this series, I agree that I should
move it back to
its original position.
Thanks,
Nanley
Marek
>
> On Tue, Oct 20, 2015 at 5:14 PM, Marek Olšák wrote:
> > On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund
> wrote:
> >> On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery
> wrote:
> >>> From: Nanley Chery
> >>>
> >>> - { "GL_SUN_multi_draw_arrays", o(dummy_true),
> GLL,1999 },
> >>> +#define EXT(name_str, driver_cap, api_flags, ) \
> >>> +{ .name = "GL_" #name_str, .offset = o(driver_cap), .api_set
> = api_flags, .year = },
> >>
> >> I suspect that using designated initializers will make the MSVC build
> unhappy.
> >
> > Yes, this syntax isn't allowed in core Mesa. Only drivers can use it.
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On Tue, Oct 20, 2015 at 8:14 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund
> wrote:
> > On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery
> wrote:
> >> From: Nanley Chery
> >>
> >> - { "GL_SUN_multi_draw_arrays", o(dummy_true),
> GLL,1999 },
> >> +#define EXT(name_str, driver_cap, api_flags, ) \
> >> +{ .name = "GL_" #name_str, .offset = o(driver_cap), .api_set =
> api_flags, .year = },
> >
> > I suspect that using designated initializers will make the MSVC build
> unhappy.
>
> Yes, this syntax isn't allowed in core Mesa. Only drivers can use it.
>
I meant to look into this, but forgot. Thanks for catching this.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
Also, the FIXME comment should be on its own line.
Marek
On Tue, Oct 20, 2015 at 5:14 PM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund wrote:
>> On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote:
>>> From: Nanley Chery
>>>
>>> - { "GL_SUN_multi_draw_arrays", o(dummy_true),
>>> GLL,1999 },
>>> +#define EXT(name_str, driver_cap, api_flags, ) \
>>> +{ .name = "GL_" #name_str, .offset = o(driver_cap), .api_set =
>>> api_flags, .year = },
>>
>> I suspect that using designated initializers will make the MSVC build
>> unhappy.
>
> Yes, this syntax isn't allowed in core Mesa. Only drivers can use it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund wrote:
> On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote:
>> From: Nanley Chery
>>
>> - { "GL_SUN_multi_draw_arrays", o(dummy_true),
>>GLL,1999 },
>> +#define EXT(name_str, driver_cap, api_flags, ) \
>> +{ .name = "GL_" #name_str, .offset = o(driver_cap), .api_set =
>> api_flags, .year = },
>
> I suspect that using designated initializers will make the MSVC build unhappy.
Yes, this syntax isn't allowed in core Mesa. Only drivers can use it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros
On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote:
> From: Nanley Chery
>
> - { "GL_SUN_multi_draw_arrays", o(dummy_true),
> GLL,1999 },
> +#define EXT(name_str, driver_cap, api_flags, ) \
> +{ .name = "GL_" #name_str, .offset = o(driver_cap), .api_set =
> api_flags, .year = },
I suspect that using designated initializers will make the MSVC build unhappy.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
