Re: [Mesa-dev] git fsck errors on mesa repo

2015-06-30 Thread Liam R. Howlett
* Emil Velikov  [150630 10:04]:
> Hi Liam,
> 
> On 29/06/15 18:23, Liam R. Howlett wrote:
> > Hello,
> > 
> > Since git 2.3, there have been a number of new fsck options added which
> > produce issues when I clone the repository
> > git://anongit.freedesktop.org/git/mesa/mesa
> > 
> Can you be more specific about the fsck options and the messages that
> you're seeing ?

Sorry, I forgot to include the errors.  What you mentioned below are the
same errors that I see (error in tag: .. unterminated header).

> 
> > These new tests are enabled by default when using git fsck.  I have been
> > testing with git version 2.4.4.409.g5b1d901 and thought you might want
> > to know so the error/warning messages can be avoided.
> > 
> From a quick look (running git 2.4.4) there are 68 "error in tag $sha:
> unterminated header" messages.
> 
> By the looks of it most/all of those are old tags (which we don't care
> too much nowdays) and they are lacking the trailing \n. Afaict other
> projects have the same "problem", and the git devs are working on a fix [1].

Yes, it appears the errors are being reported due to the legacy tags
that were created.  You can wait for git to change its behaviour or fix
the tags by recreating them.  I came across an issue and wanted to be
sure that it was known since I didn't find anything about them on the
mailing list.

Thank you for your time and apologies about the lack of details in my
first email,
Liam


> 
> Cheers,
> Emil
> 
> [1] http://www.spinics.net/lists/git/msg254657.html
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] git fsck errors on mesa repo

2015-06-30 Thread Emil Velikov
On 30/06/15 15:39, Liam R. Howlett wrote:
> * Emil Velikov  [150630 10:04]:
>> Hi Liam,
>>
>> On 29/06/15 18:23, Liam R. Howlett wrote:
>>> Hello,
>>>
>>> Since git 2.3, there have been a number of new fsck options added which
>>> produce issues when I clone the repository
>>> git://anongit.freedesktop.org/git/mesa/mesa
>>>
>> Can you be more specific about the fsck options and the messages that
>> you're seeing ?
> 
> Sorry, I forgot to include the errors.  What you mentioned below are the
> same errors that I see (error in tag: .. unterminated header).
> 
>>
>>> These new tests are enabled by default when using git fsck.  I have been
>>> testing with git version 2.4.4.409.g5b1d901 and thought you might want
>>> to know so the error/warning messages can be avoided.
>>>
>> From a quick look (running git 2.4.4) there are 68 "error in tag $sha:
>> unterminated header" messages.
>>
>> By the looks of it most/all of those are old tags (which we don't care
>> too much nowdays) and they are lacking the trailing \n. Afaict other
>> projects have the same "problem", and the git devs are working on a fix [1].
> 
> Yes, it appears the errors are being reported due to the legacy tags
> that were created.  You can wait for git to change its behaviour or fix
> the tags by recreating them.  I came across an issue and wanted to be
> sure that it was known since I didn't find anything about them on the
> mailing list.
> 
I'm pretty sure that some of us haven't noticed these errors and/or did
not look into them yet. I know I haven't. So thank you for the heads-up!

> Thank you for your time and apologies about the lack of details in my
> first email,
Don't worry about it. None of us like seeing error messages so we tend
to forget quoting them :P

Cheers
Emil

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] git fsck errors on mesa repo

2015-06-30 Thread Emil Velikov
Hi Liam,

On 29/06/15 18:23, Liam R. Howlett wrote:
> Hello,
> 
> Since git 2.3, there have been a number of new fsck options added which
> produce issues when I clone the repository
> git://anongit.freedesktop.org/git/mesa/mesa
> 
Can you be more specific about the fsck options and the messages that
you're seeing ?

> These new tests are enabled by default when using git fsck.  I have been
> testing with git version 2.4.4.409.g5b1d901 and thought you might want
> to know so the error/warning messages can be avoided.
> 
From a quick look (running git 2.4.4) there are 68 "error in tag $sha:
unterminated header" messages.

By the looks of it most/all of those are old tags (which we don't care
too much nowdays) and they are lacking the trailing \n. Afaict other
projects have the same "problem", and the git devs are working on a fix [1].

Cheers,
Emil

[1] http://www.spinics.net/lists/git/msg254657.html
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev