Wolfram Gloger wrote:
> 
> Hi,
> 
> I sent the following patch two months ago, and just discovered it
> hasn't been applied yet to current CVS sources.  If you think it is
> wrong, please tell me why.  It plugs a memory leak for me and in fact
> worse: if comparePointers is false, then `vishandle' points nowhere
> definite, so crashes could also result.
> 
> Regards,
> Wolfram.
> 
> --- fakeglx.c.orig      Thu Nov 11 02:29:28 1999
> +++ fakeglx.c   Thu Nov 18 16:20:09 1999
> @@ -258,7 +258,7 @@
>            && (v->gl_visual->StencilBits >= stencil_size || stencil_size == 0)
>            && (v->gl_visual->AccumBits >= accum_size || accum_size == 0)) {
>           /* now either compare XVisualInfo pointers or visual IDs */
> -         if ((!comparePointers && v->vishandle->visualid == vinfo->visualid)
> +         if ((!comparePointers && v->visinfo->visualid == vinfo->visualid)
>               || (comparePointers && v->vishandle == vinfo)) {
>              return v;
>           }

I've commited the change to both branches.  Thanks, Wolfram.

-Brian


_______________________________________________
Mesa-dev maillist  -  [EMAIL PROTECTED]
http://lists.mesa3d.org/mailman/listinfo/mesa-dev

Reply via email to