[Mesa3d-dev] Clipping distance change broke VTK tests
Hi Folks, I test Mesa nightly by running VTK's regression suite against a build of Mesa. Changes merged to master recently broke some tests: http://www.cdash.org/CDash/testDetails.php?test=33502466build=449016 http://www.cdash.org/CDash/viewTest.php?onlyfailedbuildid=449016 Git bisect led me to the commit below. Please let me know if you need more information or help debugging this. Thanks, -Brad f058b25881e08c9d89a33345e5c84e1357396932 is first bad commit commit f058b25881e08c9d89a33345e5c84e1357396932 Author: Ian Romanick ian.d.roman...@intel.com Date: Thu Oct 8 17:28:02 2009 -0700 Store clipping distance for user clip planes as part of vertex processing Once the clipping distance is calculated and stored per vertex, the distances can be re-used when clipping is actually performed. This doesn't have any immediate benefit, but it paves the way for implementing gl_ClipDistance in vertex shaders and result.clip[] in vertex programs. This has not produces any oglconform regressions on my G31 system which uses software TNL. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Brian Paul bri...@vmware.com :04 04 3a1c02fb116f136c56ae48a405d18c1424bfbcdb c4f3a57f1cae77d6b076c6e8adfc6d06fce40a90 M src -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
Re: [Mesa3d-dev] Initial version of GL_MESA_gpu_program3
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Version 2 of the extension spec has been posted: http://people.freedesktop.org/~idr/MESA_gpu_program3.txt Unless anyone has major comments or objections, I think it's time to circulate this to down-stream users (e.g., Wine). Who are the right contacts? -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkrc8LwACgkQX1gOwKyEAw8yawCbBxaySDhe8rhRIq43GGqbHXT9 E9sAnRaPBIfid5Zl0gk8J1xniPuIAlL8 =VLxn -END PGP SIGNATURE- -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
Re: [Mesa3d-dev] [PATCH-RFC] move dri remap table to mesa core
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chia-I Wu wrote: I've managed to clean up the code and created a patch series. As it touches glapi, the file size exceeds the limit the list easily. I have to upload it to somewhere else I looked over the patches, and they look good to me. It's hard to give a thorough review due to the volume of changes. I only noticed a couple minor issues. - remap.c has no license. - remap.h has an incorrect license. At least the Mesa version should be changed. http://0xlab.org/~olv/mesa-remap-table/ or http://0xlab.org/~olv/mesa-remap-table.tar.gz There are five patches. The first patch adds remap.c and helper scripts/headers to mesa core. This is the in core remap table. The second patch switches the use of dri remap table and extension_helper.h to the in core remap table and remap_helper.h. As the helper headers provide the same source level API, the switch here is simple. driInitExtensions is also updated to call the in core functions. It also solves the chicken-egg problem that can be seen in all hw dri drivers. The remap table is now automatically initialized in one_time_init(). I think this is an important change, and it is good. I agree. This was the one thing that always bothered me about the remap stuff. I wanted to do it differently, but I didn't see a good way. The third patch removes extensions_helper.h. The seemingly huge fourth patch does one simple thing. It moves the SET/GET/CALL macros from dispatch.h to glapidispatch.h, in preparation for the last patch. The last patch makes libglapi.a always be built. While libglapi.a has nothing to do with IN_DRI_DRIVER, one might notice that libglapi.a cannot be built with IN_DRI_DRIVER defined. This should be solved by the last two patches. The difference with these patches applied is... no difference, when IN_DRI_DRIVER is not defined. The remap table is simply gone. But when IN_DRI_DRIVER is defined, it will give a remappable libmesa.a. DRI drivers are linked to it, and they should function the same way except for slightly reduced startup time and file size (remap_helper.h is more compact than extension_helper.h). Non-DRI drivers can also link to it. They will function, but will be, just like DRI drivers, slightly slower when any of the SET/GET/CALL macros are used. As for libglapi.a, there will be some missing symbols, like glGenTexturesEXT, when GLX_INDIRECT_RENDERING is defined. It is possible to modify gl_apitemp.py to generate the stubs. But it is skipped in this patch series. The issue here was that we want some functions to alias (such as glGenTexturesEXT and glGenTextures), but they have different GLX protocol. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkrdASIACgkQX1gOwKyEAw8eUwCeOojpE8uCEPShDocyO5jD1nir GAcAn3/3s1LGPt8lRLw5Xe4u/QrwUGY9 =WBcr -END PGP SIGNATURE- -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
Re: [Mesa3d-dev] Clipping distance change broke VTK tests
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brad King wrote: Hi Folks, I test Mesa nightly by running VTK's regression suite against a build of Mesa. Changes merged to master recently broke some tests: http://www.cdash.org/CDash/testDetails.php?test=33502466build=449016 http://www.cdash.org/CDash/viewTest.php?onlyfailedbuildid=449016 Git bisect led me to the commit below. Please let me know if you need more information or help debugging this. Thanks for the report. I created a piglit test (tests/general/user-clip.c) that shows the bad behavior. I also submitted a bug: #24630. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkrdClUACgkQX1gOwKyEAw/WBQCfbiAF2zChqU5SQm8aIPTZo+4D 59oAn1XMYaND542jwQePUkJ+5oPlQOcr =QgRq -END PGP SIGNATURE- -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
[Mesa3d-dev] [Bug 2209] t_vtx_x86.c cleanup
http://bugs.freedesktop.org/show_bug.cgi?id=2209 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #4 from Ian Romanick i...@freedesktop.org 2009-10-19 19:21:26 PST --- This file hasn't existed for years. Closing. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
[Mesa3d-dev] [Bug 3064] Mesa implementation error: Error in execute_list: opcode=136423416
http://bugs.freedesktop.org/show_bug.cgi?id=3064 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #2 from Ian Romanick i...@freedesktop.org 2009-10-19 19:23:32 PST --- No response in 4 years. Closing. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
Re: [Mesa3d-dev] [PATCH-RFC] move dri remap table to mesa core
On Mon, Oct 19, 2009 at 05:15:31PM -0700, Ian Romanick wrote: I've managed to clean up the code and created a patch series. As it touches glapi, the file size exceeds the limit the list easily. I have to upload it to somewhere else I looked over the patches, and they look good to me. It's hard to give a thorough review due to the volume of changes. I only noticed a couple minor issues. - remap.c has no license. - remap.h has an incorrect license. At least the Mesa version should be changed. Thanks. I have added/corrected the license and uploaded a new version to http://0xlab.org/~olv/mesa-remap-table-v2.tar.gz There is no code change. The second patch switches the use of dri remap table and extension_helper.h to the in core remap table and remap_helper.h. As the helper headers provide the same source level API, the switch here is simple. driInitExtensions is also updated to call the in core functions. It also solves the chicken-egg problem that can be seen in all hw dri drivers. The remap table is now automatically initialized in one_time_init(). I think this is an important change, and it is good. I agree. This was the one thing that always bothered me about the remap stuff. I wanted to do it differently, but I didn't see a good way. My way of doing it is to think of libmesa.a as a library of its own. It should not rely on symbols from applications (that is, drivers), and SET/GET/CALL macros should work without special care because they are part of libmesa.a API. As for libglapi.a, there will be some missing symbols, like glGenTexturesEXT, when GLX_INDIRECT_RENDERING is defined. It is possible to modify gl_apitemp.py to generate the stubs. But it is skipped in this patch series. The issue here was that we want some functions to alias (such as glGenTexturesEXT and glGenTextures), but they have different GLX protocol. Yeah. To minimize the changes needed, I am thinking re-organizing glapitemp.h in a way that it can provide _only_ those symbols affected by GLX_INDIRECT_RENDERING. drivers/x11/ or gallium/winsys/xlib/ can then include it to provide the missing symbols. But it is still weird that libglapi.a has missing symbols, if one views it as a library. I would also like to change this while at it. -- Regards, olv -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
