[PATCH] ds: reap_pids: remove redundant signal blocking

[Eric Wong]

Blocking signals when reaping was done when the lei pager was
spawned by the daemon in b90e8d6e02.  Shortly afterwards in
7b79c918a5, the client script took over spawning of the pager
and made b90e8d6e02 redundant.

cf. b90e8d6e02 (ds: block signals when reaping, 2021-01-10)
7b79c918a5 (lei: run pager in client script, 2021-01-10)
---
 lib/PublicInbox/DS.pm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index a08e01f5..b6eaf2d7 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -214,7 +214,6 @@ sub await_cb ($;@) {
 # that to remain the case.
 sub reap_pids {
$reap_armed = undef;
-   my $oldset = block_signals();
while (1) {
my $pid = waitpid(-1, WNOHANG) // last;
last if $pid <= 0;
@@ -224,7 +223,6 @@ sub reap_pids {
warn "W: reaped unknown PID=$pid: \$?=$?\n";
}
}
-   sig_setmask($oldset);
 }
 
 # reentrant SIGCHLD handler (since reap_pids is not reentrant)

Re: IMAP users: how useful is server-side search to you?

[Konstantin Ryabitsev]

On Tue, Mar 14, 2023 at 09:55:02PM +, Eric Wong wrote:
> I've always used local search (lei nowadays, mairix in the past).
> 
> I'm considering an option to disable it, or make it available to
> AUTH=ANONYMOUS users only, since there seems to be a lot of
> scrapers trying to look for private emails and such...

I think at this point there are few enough users of IMAP that you can just
make unilateral decisions and everyone will be fine with that. :)

-K