Re: [meta-arago] [EXTERNAL] Re: [rocko/master] [PATCH] matrix-gui: replace SysVinit with systemd service

2018-11-20 Thread Denys Dmytriyenko
On Tue, Nov 20, 2018 at 05:55:32PM -0500, Gou, Hongmei wrote:
> > -Original Message-
> > From: meta-arago-boun...@arago-project.org [mailto:meta-arago-
> > boun...@arago-project.org] On Behalf Of Gou, Hongmei
> > Sent: Tuesday, November 20, 2018 5:43 PM
> > To: Dmytriyenko, Denys
> > Cc: meta-arago@arago-project.org
> > Subject: [EXTERNAL] Re: [meta-arago] [rocko/master] [PATCH] matrix-gui:
> > replace SysVinit with systemd service
> > 
> > > -Original Message-
> > > From: Dmytriyenko, Denys
> > > Sent: Tuesday, November 20, 2018 5:37 PM
> > > To: Gou, Hongmei
> > > Cc: meta-arago@arago-project.org
> > > Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui: replace
> > > SysVinit with systemd service
> > >
> > > On Tue, Nov 20, 2018 at 05:12:52PM -0500, Gou, Hongmei wrote:
> > > > > -Original Message-
> > > > > From: Dmytriyenko, Denys
> > > > > Sent: Tuesday, November 20, 2018 4:54 PM
> > > > > To: Gou, Hongmei
> > > > > Cc: meta-arago@arago-project.org
> > > > > Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui: replace
> > > > > SysVinit with systemd service
> > > > >
> > > > > On Tue, Nov 20, 2018 at 04:51:51PM -0500, Gou, Hongmei wrote:
> > > > > > > -Original Message-
> > > > > > > From: Dmytriyenko, Denys
> > > > > > > Sent: Tuesday, November 20, 2018 4:43 PM
> > > > > > > To: Gou, Hongmei
> > > > > > > Cc: meta-arago@arago-project.org
> > > > > > > Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui:
> > replace
> > > > > > > SysVinit with systemd service
> > > > > > >
> > > > > > > On Tue, Nov 20, 2018 at 04:33:55PM -0500, Hongmei Gou wrote:
> > > > > > > > Signed-off-by: Hongmei Gou 
> > > > > > > > ---
> > > > > > > >  .../recipes-core/matrix/matrix-gui/matrix-gui-2.0.service | 10
> > > > > ++
> > > > > > > >  meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb   | 15
> > > > > > > +--
> > > > > > > >  2 files changed, 19 insertions(+), 6 deletions(-)
> > > > > > > >  create mode 100644 meta-arago-extras/recipes-
> > > core/matrix/matrix-
> > > > > > > gui/matrix-gui-2.0.service
> > > > > > > >
> > > > > > > > diff --git a/meta-arago-extras/recipes-core/matrix/matrix-
> > > gui/matrix-
> > > > > gui-
> > > > > > > 2.0.service b/meta-arago-extras/recipes-core/matrix/matrix-
> > > gui/matrix-
> > > > > gui-
> > > > > > > 2.0.service
> > > > > > > > new file mode 100644
> > > > > > > > index 000..3ce1024
> > > > > > > > --- /dev/null
> > > > > > > > +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-
> > > gui-
> > > > > > > 2.0.service
> > > > > > > > @@ -0,0 +1,10 @@
> > > > > > > > +[Unit]
> > > > > > > > +Description=Matrix GUI
> > > > > > > > +After=weston.service
> > > > > > > > +
> > > > > > > > +[Service]
> > > > > > > > +Type=forking
> > > > > > > > +ExecStart=/etc/init.d/matrix-gui-2.0 start
> > > > > > >
> > > > > > > Looks like it's still calling a legacy initscript - any 
> > > > > > > particular reason?
> > > > > >
> > > > > > Yes, we would like to keep the original scripts, as they are also 
> > > > > > used
> > for
> > > > > stopping/starting matrix GUI when running GUI based demos
> > > > > (/usr/share/matrix-gui-2.0/execute_command.sh):
> > > > > >
> > > > > > if [ $program_type == gui ]
> > > > > > then
> > > > > >   /etc/init.d/matrix-gui-2.0 stop
> > > > > > ..
> > > > > >
> > > > > > if [ $program_type == gui ]
> > > > > > then
> > > > > > ...
> > > > > >   /etc/init.d/matrix-gui-2.0 start
> > > > > > fi
> > &

Re: [meta-arago] [EXTERNAL] Re: [rocko/master] [PATCH] matrix-gui: replace SysVinit with systemd service

2018-11-20 Thread Gou, Hongmei
> -Original Message-
> From: meta-arago-boun...@arago-project.org [mailto:meta-arago-
> boun...@arago-project.org] On Behalf Of Gou, Hongmei
> Sent: Tuesday, November 20, 2018 5:43 PM
> To: Dmytriyenko, Denys
> Cc: meta-arago@arago-project.org
> Subject: [EXTERNAL] Re: [meta-arago] [rocko/master] [PATCH] matrix-gui:
> replace SysVinit with systemd service
> 
> > -Original Message-
> > From: Dmytriyenko, Denys
> > Sent: Tuesday, November 20, 2018 5:37 PM
> > To: Gou, Hongmei
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui: replace
> > SysVinit with systemd service
> >
> > On Tue, Nov 20, 2018 at 05:12:52PM -0500, Gou, Hongmei wrote:
> > > > -Original Message-
> > > > From: Dmytriyenko, Denys
> > > > Sent: Tuesday, November 20, 2018 4:54 PM
> > > > To: Gou, Hongmei
> > > > Cc: meta-arago@arago-project.org
> > > > Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui: replace
> > > > SysVinit with systemd service
> > > >
> > > > On Tue, Nov 20, 2018 at 04:51:51PM -0500, Gou, Hongmei wrote:
> > > > > > -Original Message-
> > > > > > From: Dmytriyenko, Denys
> > > > > > Sent: Tuesday, November 20, 2018 4:43 PM
> > > > > > To: Gou, Hongmei
> > > > > > Cc: meta-arago@arago-project.org
> > > > > > Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui:
> replace
> > > > > > SysVinit with systemd service
> > > > > >
> > > > > > On Tue, Nov 20, 2018 at 04:33:55PM -0500, Hongmei Gou wrote:
> > > > > > > Signed-off-by: Hongmei Gou 
> > > > > > > ---
> > > > > > >  .../recipes-core/matrix/matrix-gui/matrix-gui-2.0.service | 10
> > > > ++
> > > > > > >  meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb   | 15
> > > > > > +--
> > > > > > >  2 files changed, 19 insertions(+), 6 deletions(-)
> > > > > > >  create mode 100644 meta-arago-extras/recipes-
> > core/matrix/matrix-
> > > > > > gui/matrix-gui-2.0.service
> > > > > > >
> > > > > > > diff --git a/meta-arago-extras/recipes-core/matrix/matrix-
> > gui/matrix-
> > > > gui-
> > > > > > 2.0.service b/meta-arago-extras/recipes-core/matrix/matrix-
> > gui/matrix-
> > > > gui-
> > > > > > 2.0.service
> > > > > > > new file mode 100644
> > > > > > > index 000..3ce1024
> > > > > > > --- /dev/null
> > > > > > > +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-
> > gui-
> > > > > > 2.0.service
> > > > > > > @@ -0,0 +1,10 @@
> > > > > > > +[Unit]
> > > > > > > +Description=Matrix GUI
> > > > > > > +After=weston.service
> > > > > > > +
> > > > > > > +[Service]
> > > > > > > +Type=forking
> > > > > > > +ExecStart=/etc/init.d/matrix-gui-2.0 start
> > > > > >
> > > > > > Looks like it's still calling a legacy initscript - any particular 
> > > > > > reason?
> > > > >
> > > > > Yes, we would like to keep the original scripts, as they are also used
> for
> > > > stopping/starting matrix GUI when running GUI based demos
> > > > (/usr/share/matrix-gui-2.0/execute_command.sh):
> > > > >
> > > > > if [ $program_type == gui ]
> > > > > then
> > > > >   /etc/init.d/matrix-gui-2.0 stop
> > > > > ..
> > > > >
> > > > > if [ $program_type == gui ]
> > > > > then
> > > > > ...
> > > > >   /etc/init.d/matrix-gui-2.0 start
> > > > > fi
> > > >
> > > > Any plans to completely moving to systemd and calling systemctl
> > start/stop?
> > >
> > > With the current patch, "systemctl start/stop matrix-gui-2.0 " can
> > > start/stop matrix successfully.
> > > execute_command.sh can be updated to use systemctl start/stop.
> > >
> > > As for /etc/init.d/matrix-gui-2.0 (attached), I am not seeing anything
> > > specific to init.
> > > We can install it to /usr/bin instead of /etc/