Re: [meta-freescale] [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Berton]

Hi Fabio!

Ok, I'll explain in commit log.

Thanks!

On Wed, Feb 28, 2018 at 9:26 AM, Fabio Estevam  wrote:

> Hi Fabio,
>
> On Tue, Feb 27, 2018 at 5:40 PM, Fabio Berton
>  wrote:
> > Signed-off-by: Fabio Berton 
>
> Please add a commit log explaining why this patch is needed.
>
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Berton]

Hi Theodore,

I'll look to add this to imx-base.inc

Thanks!

On Wed, Feb 28, 2018 at 9:04 AM, Theodore A. Roth  wrote:

> On Tue, Feb 27, 2018 at 1:40 PM, Fabio Berton
>  wrote:
> > Signed-off-by: Fabio Berton 
> > ---
> >  conf/machine/imx25pdk.conf | 4 
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/conf/machine/imx25pdk.conf b/conf/machine/imx25pdk.conf
> > index e22d9f4e..bd7ae0ee 100644
> > --- a/conf/machine/imx25pdk.conf
> > +++ b/conf/machine/imx25pdk.conf
> > @@ -18,6 +18,10 @@ SERIAL_CONSOLE = "115200 ttymxc0"
> >  MACHINE_FEATURES = "usbgadget usbhost vfat alsa touchscreen"
> >
> >  WKS_FILE = "imx-uboot.wks"
> > +
> > +# Do not update fstab file when using wic images
> > +WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
> > +
> >  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " \
> >  kernel-image \
> >  kernel-devicetree \
> > --
> > 2.14.2
> >
> > --
>
> Fabio,
>
> Should this sort of patch also be applied to the
> 'conf/machine/include/imx-base.inc' in meta-freescale? I got bit by
> this a couple of weeks ago on an 'imx7dsabresd' machine build using
> systemd which would not boot and I did not see anything in your patch
> set that touched on that.
>
> Thanks.
>
> Ted Roth
>
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Estevam]

Hi Fabio,

On Tue, Feb 27, 2018 at 5:40 PM, Fabio Berton
 wrote:
> Signed-off-by: Fabio Berton 

Please add a commit log explaining why this patch is needed.
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-freescale] [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Theodore A. Roth]

On Tue, Feb 27, 2018 at 1:40 PM, Fabio Berton
 wrote:
> Signed-off-by: Fabio Berton 
> ---
>  conf/machine/imx25pdk.conf | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/conf/machine/imx25pdk.conf b/conf/machine/imx25pdk.conf
> index e22d9f4e..bd7ae0ee 100644
> --- a/conf/machine/imx25pdk.conf
> +++ b/conf/machine/imx25pdk.conf
> @@ -18,6 +18,10 @@ SERIAL_CONSOLE = "115200 ttymxc0"
>  MACHINE_FEATURES = "usbgadget usbhost vfat alsa touchscreen"
>
>  WKS_FILE = "imx-uboot.wks"
> +
> +# Do not update fstab file when using wic images
> +WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
> +
>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " \
>  kernel-image \
>  kernel-devicetree \
> --
> 2.14.2
>
> --

Fabio,

Should this sort of patch also be applied to the
'conf/machine/include/imx-base.inc' in meta-freescale? I got bit by
this a couple of weeks ago on an 'imx7dsabresd' machine build using
systemd which would not boot and I did not see anything in your patch
set that touched on that.

Thanks.

Ted Roth
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale

[meta-freescale] [PATCH 1/4] imx25pdk: Add wic option to not update fstab

[Fabio Berton]

Signed-off-by: Fabio Berton 
---
 conf/machine/imx25pdk.conf | 4 
 1 file changed, 4 insertions(+)

diff --git a/conf/machine/imx25pdk.conf b/conf/machine/imx25pdk.conf
index e22d9f4e..bd7ae0ee 100644
--- a/conf/machine/imx25pdk.conf
+++ b/conf/machine/imx25pdk.conf
@@ -18,6 +18,10 @@ SERIAL_CONSOLE = "115200 ttymxc0"
 MACHINE_FEATURES = "usbgadget usbhost vfat alsa touchscreen"
 
 WKS_FILE = "imx-uboot.wks"
+
+# Do not update fstab file when using wic images
+WIC_CREATE_EXTRA_ARGS_append = " --no-fstab-update"
+
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += " \
 kernel-image \
 kernel-devicetree \
-- 
2.14.2

-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale