Re: [meta-freescale] [meta-fsl-arm-extra][PATCH v3 2/4] u-boot-variscite: Add u-boot recipe for variscite

2016-04-13 Thread Daiane Angolini
On Wed, Apr 13, 2016 at 9:16 AM, Fabio Berton
 wrote:
> Signed-off-by: Fabio Berton 

> diff --git a/recipes-bsp/u-boot/u-boot-variscite_2013.10.bb 
> b/recipes-bsp/u-boot/u-boot-variscite_2013.10.bb
> new file mode 100644
> index 000..1c07058
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot-variscite_2013.10.bb
> @@ -0,0 +1,28 @@
> +require recipes-bsp/u-boot/u-boot.inc
> +
> +DESCRIPTION = "bootloader for imx platforms"

Please, change the DESCRIPTION. It's not "bootloader for imx
platforms" as its target is only variscite boards.

Take a look in the other u-boot recipes to get some inspirations to
write this description.

> +LICENSE = "GPLv2+"
> +LIC_FILES_CHKSUM = 
> "file://Licenses/README;md5=025bf9f768cbcb1a165dbe1a110babfb"
> +COMPATIBLE_MACHINE = "(mxs|mx6)"
> +
> +PROVIDES += "u-boot"
> +
> +UBOOT_MAKE_TARGET = "all"

I'm not sure you need or want to set UBOOT_MAKE_TARGET to all.
u-boot-inc already set this with override possibility.

For the other boards we use to define UBOOT_MAKE_TARGET in the machine
conf file instead.


> +UBOOT_SUFFIX = "img"
> +
> +SPL_BINARY = "SPL"
> +
> +SRCREV = "a2bb081c08f8e18cee3ffbf577adb9bdb7d5a6f9"
> +SRCBRANCH = "imx_v2013.10_var4"
> +
> +SRC_URI = "\
> +git://github.com/varigit/uboot-imx.git;protocol=git;branch=${SRCBRANCH} \
> +file://u-boot-002-gcc5-use_gcc_inline_version_instead_c99.patch \
> +file://0001-Add-linux-compiler-gcc5.h-to-fix-builds-with-gcc5.patch \
> +file://0002-ARM-asm-io.h-use-static-inline.patch \
> +file://0003-gcc5-no-unalligned-access.patch \
> +"
> +
> +S = "${WORKDIR}/git"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale


Re: [meta-freescale] [meta-fsl-arm-extra][PATCH v3 2/4] u-boot-variscite: Add u-boot recipe for variscite

2016-04-13 Thread Fabio Berton
Hi Daiane,

I need to set UBOOT_MAKE_TARGET to all, it doesn't call the all target by
default.

I'll move UBOOT_MAKE_TARGET to machine conf file and send v4


On Wed, Apr 13, 2016 at 9:59 AM, Daiane Angolini 
wrote:

> On Wed, Apr 13, 2016 at 9:16 AM, Fabio Berton
>  wrote:
> > Signed-off-by: Fabio Berton 
>
> > diff --git a/recipes-bsp/u-boot/u-boot-variscite_2013.10.bb
> b/recipes-bsp/u-boot/u-boot-variscite_2013.10.bb
> > new file mode 100644
> > index 000..1c07058
> > --- /dev/null
> > +++ b/recipes-bsp/u-boot/u-boot-variscite_2013.10.bb
> > @@ -0,0 +1,28 @@
> > +require recipes-bsp/u-boot/u-boot.inc
> > +
> > +DESCRIPTION = "bootloader for imx platforms"
>
> Please, change the DESCRIPTION. It's not "bootloader for imx
> platforms" as its target is only variscite boards.
>
> Take a look in the other u-boot recipes to get some inspirations to
> write this description.
>
> > +LICENSE = "GPLv2+"
> > +LIC_FILES_CHKSUM =
> "file://Licenses/README;md5=025bf9f768cbcb1a165dbe1a110babfb"
> > +COMPATIBLE_MACHINE = "(mxs|mx6)"
> > +
> > +PROVIDES += "u-boot"
> > +
> > +UBOOT_MAKE_TARGET = "all"
>
> I'm not sure you need or want to set UBOOT_MAKE_TARGET to all.
> u-boot-inc already set this with override possibility.
>
> For the other boards we use to define UBOOT_MAKE_TARGET in the machine
> conf file instead.
>
>
> > +UBOOT_SUFFIX = "img"
> > +
> > +SPL_BINARY = "SPL"
> > +
> > +SRCREV = "a2bb081c08f8e18cee3ffbf577adb9bdb7d5a6f9"
> > +SRCBRANCH = "imx_v2013.10_var4"
> > +
> > +SRC_URI = "\
> > +git://
> github.com/varigit/uboot-imx.git;protocol=git;branch=${SRCBRANCH} \
> > +file://u-boot-002-gcc5-use_gcc_inline_version_instead_c99.patch \
> > +file://0001-Add-linux-compiler-gcc5.h-to-fix-builds-with-gcc5.patch
> \
> > +file://0002-ARM-asm-io.h-use-static-inline.patch \
> > +file://0003-gcc5-no-unalligned-access.patch \
> > +"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
>
-- 
___
meta-freescale mailing list
meta-freescale@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-freescale